Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 2 May 2023 17:27:29 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Dominique Martinet <asmadeus@codewreck.org>
Cc:     Eric Van Hensbergen <ericvh@gmail.com>,
        Latchesar Ionkov <lucho@ionkov.net>,
        Christian Schoenebeck <linux_oss@crudebyte.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, v9fs@lists.linux.dev,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 3/5] 9p: virtio: make sure 'offs' is initialized in
 zc_request
Message-ID: <ZFEr4X1s4dVgr+Vg@corigine.com>
References: <20230427-scan-build-v1-0-efa05d65e2da@codewreck.org>
 <20230427-scan-build-v1-3-efa05d65e2da@codewreck.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230427-scan-build-v1-3-efa05d65e2da@codewreck.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Mxk1lXFonpp8vWyJQ8JEDLbnv4I0XV/t2iQ3W9NFOTYG1N8DuMxAJbf1hXke?=
 =?us-ascii?Q?4rcKwl3yU9NYtPiq1G+kUQlSOPOL2pUB0WR7f1xIEXWeXqCL/6U+Ayhgo416?=
 =?us-ascii?Q?8MY2+3zESExB2dJDGZzkSNOcVTffQsw6WMYHA6pOszhAL0778LH+Auh3PMX5?=
 =?us-ascii?Q?aUdg044KtFzKQvSydMmx7u5Sh1DpAI6cPcF6zkIL8khdfGs5cd1Rsk7E4BUz?=
 =?us-ascii?Q?NksooMQEz6A1VGNjlu+Us0AtvFCUBHbVi8B6wBNSmR6AxMhm2zJBksHZua6m?=
 =?us-ascii?Q?ty/XVZ0++YBLIU1dcTtZAp+SjY97tkk0cRYSvzrN1tNIxUwq0TzMmyzQjzK3?=
 =?us-ascii?Q?wskqExAjfhes2lypgmSZEvN9hbMSp4uDtwetWZe8eItbPgX1BH3ECzoEPc67?=
 =?us-ascii?Q?/6Gt6rwN2VnOLnXCA7gAiwcIoRiHT+yt848uzKf3b/3W4OjUlJkI8t8CN7HW?=
 =?us-ascii?Q?eVDFENGzK7EEwszulLFcAWVKTyd2NP+nvFBHWMTEWathXMSMUvWQ6a369q/g?=
 =?us-ascii?Q?pOQoCfhso9zGC44EbmjZ070353J5PDJQLJd/1QaIpF/+z+BFZ8ZsPviPbuLJ?=
 =?us-ascii?Q?OqTzauokRcKVUYrl0j+UXYfPh3LV872cOodj2/5BCUwAGRm+yaVcQ/whhwsk?=
 =?us-ascii?Q?eeN6Oo1qf/KoVcvsr2dWZ+No37/Su/84xOkuwsTHTSqYJ70v9qTQe7LYzjBp?=
 =?us-ascii?Q?ZnEaJGDRkZiPa/tTwrkJ6bgVrO6XkmwZwouhAWhZ4ZQA/muh3k/K/dayWa0s?=
 =?us-ascii?Q?qxsLTFptVCsG//ufUV8A0AgskJkIQ9UF2Wiw9AluPUl1jYjWqaupzRrirzoo?=
 =?us-ascii?Q?7XPiZjzeJqsQrRUA0Sts0XFCcxaQt0/b0CiDd6M5UvEpFxsOS76ZnmPORYow?=
 =?us-ascii?Q?R5PbKEsCwVoEMhIBtZWp3wp+jsKSVhuPrfBqIKSLepjw5QSkOBfyFTHOlfBH?=
 =?us-ascii?Q?8xhV+g0NfcRmE/0YxiHL9/tzZ2MzXdxz2eZTBw8/Cpyg8Axaarlo9fbBn9GA?=
 =?us-ascii?Q?mjgugpuo9slH95f0IF9Hwvzy0ohUvuG4NAFMreJ3R502o8pzftMPN/XDpGLz?=
 =?us-ascii?Q?YKYq5A6iCsbt0r4a+KLY4vwQ5EehASPZyHCfPZBbMYnbYV7jg2jjgZFJxpp3?=
 =?us-ascii?Q?zCa9TA4CHch4zUaVjzNy4qRvk9mhvQErIvcHOf9AD3epXwNplcgPr9U4Z/6C?=
 =?us-ascii?Q?3WOOp4zsCh4nTxhAWe3WmpqhgKgEC0aEL6JJLO1l3Bc+S0n3+BhzSf4IdQ6A?=
 =?us-ascii?Q?IsteCsIDMumxY9QAe3dPukO9Y9b2F0jHY+d6plTzQ/x3vcsKKYBy+K/7NsOr?=
 =?us-ascii?Q?2Wie119vpp2DP8VWNuajN+UzxFBH7ewcipZ5UvimVyLcuynfFOh+J3E+BrEk?=
 =?us-ascii?Q?p13MAVLB/hylpASyrGnohLkfhYfCedZishoaI9GcjlcKAZFERVIZUlaSqcUn?=
 =?us-ascii?Q?Kkj+HPG8Xvd5vtZDTRz30J+CE7ag89LF0ajpL3UVbtAE4g+SImp2NmaQ3IgK?=
 =?us-ascii?Q?0MCZfu6BQoAws3vrCYRoXeB0pTyR4JJJKgSJEx+qD6Dohu3fuRU2YwFKzDOe?=
 =?us-ascii?Q?Luy5Sm2Sz6VlTxmP/xOcX4dTuLfKqSlWfjMhf1wI6Y3G0yrptaPn3nBCw46o?=
 =?us-ascii?Q?VVhcF7e5IjVfFu21BjUYHjE8Lo+uLOQiK3uYSkgAHAi0crUtRTYgYd3/SMeo?=
 =?us-ascii?Q?FKi5sg=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 47bf60e7-f2b0-42f7-7d75-08db4b21c233
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 15:27:36.8687
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EjJlaxOGzxNXTa7agX4NjXWUYbw0//+1CXMou62eFeHlVT5ji5A0dA+j6yn1Ie33enTLwgo/6QXHmGgD08RPgiBaJ63zhOrYYrBZj4BkCow=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR13MB3782
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Apr 27, 2023 at 08:23:36PM +0900, Dominique Martinet wrote:
> Similarly to the previous patch: offs can be used in handle_rerrors
> without initializing on small payloads; in this case handle_rerrors will
> not use it because of the size check, but it doesn't hurt to make sure
> it is zero to please scan-build.
> 
> This fixes the following warning:
> net/9p/trans_virtio.c:539:3: warning: 3rd function call argument is an uninitialized value [core.CallAndMessage]
>                 handle_rerror(req, in_hdr_len, offs, in_pages);
>                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> Signed-off-by: Dominique Martinet <asmadeus@codewreck.org>

Reviewed-by: Simon Horman <simon.horman@corigine.com>