Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp7047536rwr; Tue, 2 May 2023 08:49:09 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5Nsq4ZK7tu2xkHlpAyDEQcD3rXDyNrW05oNvm4Mm6xT0PjWuNqlN9fcz6vCX4W5h75M02F X-Received: by 2002:a17:902:e74e:b0:1a6:f93a:a136 with SMTP id p14-20020a170902e74e00b001a6f93aa136mr29868356plf.22.1683042549546; Tue, 02 May 2023 08:49:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683042549; cv=none; d=google.com; s=arc-20160816; b=fQduF/xDdUtXJfOxA0GMp1/d1knL3uwsIkKhHQIWR70x5dgpHQJ5mGPEvxf9YfvgYX C4E0jVRVl+W3KV726yAMa9ix53dBTh7z++YY+PwXZxbHYd+j7TYK0R+ywMJ7Uc6jkOj8 3xIYJbguwhvrz5bBH0X31xINEQbgll5HAS44tPdhELIc0+47qSp+9yhxMwtoHNUChpqF tLmIKIgRDXl01dOzCAFIWaiJab5mmNcY8nPdeZ8WcNnpLc97qnVVdlA02ObfpvTJz+Gy QxCGtejIZPczeYXw/m4tZfSk00bEFWCVOnZJ/079tMeJ8MP2Md5vnq0Wr0wIhTf81dU4 vpHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=7GV0p3ia07I1yPELx7AFJWOA2shLP4Nxkstuv8IxJK8=; b=Vn4fUNUEonf94BP0wLA6eRo02rAkKjXy3LkK23DFdmPOb08sRTJLkN/QHqHlkILIAk 0s/adEAzzVIJq8MX9oHhOrcIpAjejmeBADpfm9FaquM3GEisxAd3O4bXTUOOz3XkoHsd vDIxNfn+8u2de4fM51ma7+DWJXar6BT5JUzjfHIyipHtSD9UYN9xKESNjlP9yr3xCPQY xhVpjlTQYrQ/CsXcWmwF6dn7LQ8vZo4n+7vexCmDRb3lRd3c27qiorsy2NQlUDidlDCo 4d7jEO77omArJlhZcoTstYu77oyGjYxI3aoi25N8EMH6Ob5NV33tRaj4yZ6fny7Wf11o JeVA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@z3ntu.xyz header.s=z3ntu header.b=jFIjUf8j; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=z3ntu.xyz Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bt8-20020a17090af00800b00246d776cbdcsi3692798pjb.57.2023.05.02.08.48.57; Tue, 02 May 2023 08:49:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@z3ntu.xyz header.s=z3ntu header.b=jFIjUf8j; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=z3ntu.xyz Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234508AbjEBPfl (ORCPT + 99 others); Tue, 2 May 2023 11:35:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50510 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234212AbjEBPfj (ORCPT ); Tue, 2 May 2023 11:35:39 -0400 Received: from mail.z3ntu.xyz (mail.z3ntu.xyz [128.199.32.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB172E7; Tue, 2 May 2023 08:35:37 -0700 (PDT) Received: from g550jk.localnet (unknown [62.108.10.64]) by mail.z3ntu.xyz (Postfix) with ESMTPSA id C6C53C76A8; Tue, 2 May 2023 15:35:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=z3ntu.xyz; s=z3ntu; t=1683041706; bh=R9A1qU0xozFT1PTNbx8XF9Yii7u7muqM0dWSf6l21ug=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=jFIjUf8jPNHIGqUtQXcb8eZaH6a3cBc0gsQnwtR3J6XeKHROAfT8XhpfZKOzuGZUS yZR6YajptRLzaksDUpkSSO0xitf2v3baxLFVVj/o6lOLNJAdgNvfU9i1dLacrFivVZ 3IORo94VhcuvJTJr3OFMmXTniCwvBXIXx/4V18Cs= From: Luca Weiss To: Dmitry Torokhov Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Sebastian Reichel , Andy Gross , Bjorn Andersson , Konrad Dybcio , Brian Masney , linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH 3/4] Input: pwm-vibra - add support for enable GPIO Date: Tue, 02 May 2023 17:35:04 +0200 Message-ID: <841522397.0ifERbkFSE@z3ntu.xyz> In-Reply-To: References: <20230427-hammerhead-vibra-v1-0-e87eeb94da51@z3ntu.xyz> <20230427-hammerhead-vibra-v1-3-e87eeb94da51@z3ntu.xyz> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Dienstag, 2. Mai 2023 02:47:29 CEST Dmitry Torokhov wrote: > On Thu, Apr 27, 2023 at 10:34:28PM +0200, Luca Weiss wrote: > > Some pwm vibrators have a dedicated enable GPIO that needs to be set > > high so that the vibrator works. Add support for that optionally. > > So this is not simply a power supply in your case controlled by a GPIO? > We truly can have both GPIO and a separate regulator? Yes it appears to be the EN pin on the ISA1000A, see https://electronics.stackexchange.com/q/380475 On apq8026-lg-lenok there is a similar setup for the vibration motor although there I don't know whether it's actually a fixed-regulator or not, but since the two devices were built in a similar time (without checking further) I could assume they both contain the same IC. Regards Luca > > Thanks.