Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <202305021414.EuPdM9kv-lkp@intel.com>
In-Reply-To: <202305021414.EuPdM9kv-lkp@intel.com>
From:   Evan Green <evan@rivosinc.com>
Date:   Tue, 2 May 2023 08:42:49 -0700
Message-ID: <CALs-Hsuw5WCmphzFNEnM5dRzqvoBscppcKb2ukVrU+uyGXBedA@mail.gmail.com>
Subject: Re: arch/riscv/kernel/cpufeature.c:34:1: sparse: sparse: symbol
 '__pcpu_scope_misaligned_access_speed' was not declared. Should it be static?
To:     kernel test robot <lkp@intel.com>
Cc:     oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org,
        Palmer Dabbelt <palmer@rivosinc.com>,
        Heiko Stuebner <heiko.stuebner@vrull.eu>,
        Conor Dooley <conor.dooley@microchip.com>,
        Paul Walmsley <paul.walmsley@sifive.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Conor, this one was fixed by your patch to include cpufeature.h in
cpufeature.c, right?
-Evan

On Mon, May 1, 2023 at 11:50=E2=80=AFPM kernel test robot <lkp@intel.com> w=
rote:
>
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.gi=
t master
> head:   865fdb08197e657c59e74a35fa32362b12397f58
> commit: 62a31d6e38bd0faef7c956b358d651f7bdc4ae0c RISC-V: hwprobe: Support=
 probing of misaligned access performance
> date:   13 days ago
> config: riscv-randconfig-s052-20230430 (https://download.01.org/0day-ci/a=
rchive/20230502/202305021414.EuPdM9kv-lkp@intel.com/config)
> compiler: riscv64-linux-gcc (GCC) 12.1.0
> reproduce:
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbi=
n/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # apt-get install sparse
>         # sparse version: v0.6.4-39-gce1a6720-dirty
>         # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.=
git/commit/?id=3D62a31d6e38bd0faef7c956b358d651f7bdc4ae0c
>         git remote add linus https://git.kernel.org/pub/scm/linux/kernel/=
git/torvalds/linux.git
>         git fetch --no-tags linus master
>         git checkout 62a31d6e38bd0faef7c956b358d651f7bdc4ae0c
>         # save the config file
>         mkdir build_dir && cp config build_dir/.config
>         COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dgcc-12.1.0 make.cro=
ss C=3D1 CF=3D'-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=3Dbuild_dir ARCH=
=3Driscv olddefconfig
>         COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dgcc-12.1.0 make.cro=
ss C=3D1 CF=3D'-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=3Dbuild_dir ARCH=
=3Driscv SHELL=3D/bin/bash arch/riscv/kernel/
>
> If you fix the issue, kindly add following tag where applicable
> | Reported-by: kernel test robot <lkp@intel.com>
> | Link: https://lore.kernel.org/oe-kbuild-all/202305021414.EuPdM9kv-lkp@i=
ntel.com/
>
> sparse warnings: (new ones prefixed by >>)
>    WARNING: invalid argument to '-march': '_zihintpause'
> >> arch/riscv/kernel/cpufeature.c:34:1: sparse: sparse: symbol '__pcpu_sc=
ope_misaligned_access_speed' was not declared. Should it be static?
>
> vim +/__pcpu_scope_misaligned_access_speed +34 arch/riscv/kernel/cpufeatu=
re.c
>
>     30
>     31  /**
>     32   * riscv_isa_extension_base() - Get base extension word
>     33   *
>   > 34   * @isa_bitmap: ISA bitmap to use
>     35   * Return: base extension word as unsigned long value
>     36   *
>     37   * NOTE: If isa_bitmap is NULL then Host ISA bitmap will be used.
>     38   */
>     39  unsigned long riscv_isa_extension_base(const unsigned long *isa_b=
itmap)
>     40  {
>     41          if (!isa_bitmap)
>     42                  return riscv_isa[0];
>     43          return isa_bitmap[0];
>     44  }
>     45  EXPORT_SYMBOL_GPL(riscv_isa_extension_base);
>     46
>
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests