Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 2 May 2023 17:56:30 +0200
From:   Daniel Wagner <dwagner@suse.de>
To:     Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Cc:     "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        Chaitanya Kulkarni <kch@nvidia.com>,
        Shin'ichiro Kawasaki <shinichiro@fastmail.com>
Subject: Re: [PATCH REPOST blktests v2 8/9] nvme-rc: Move discovery
 generation counter code to rc
Message-ID: <4txznlflpzliiljmqstfd3q2eqa75oihig6oe2shwux3x2udoa@qpsbmbmacjl4>
References: <20230421060505.10132-1-dwagner@suse.de>
 <20230421060505.10132-9-dwagner@suse.de>
 <2nqdgwhiuvjsupuunxzzcoeumxqz3cosx52nhgtrv35u7nqsiq@2is3qc5gftl6>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2nqdgwhiuvjsupuunxzzcoeumxqz3cosx52nhgtrv35u7nqsiq@2is3qc5gftl6>
Precedence: bulk

On Fri, Apr 28, 2023 at 04:23:27AM +0000, Shinichiro Kawasaki wrote:
> (Let me repost this message, since vger.kernel.org declined it due to too long message).
> 
> On Apr 21, 2023 / 08:05, Daniel Wagner wrote:
> > Move the discovery generation counter code to rc so that we can reuse
> > it in 002.
> 
> I think the core change in this commit is the removal of discovery related
> messages from tests/nvme/002.out. It removes the dependency to the iteration
> number constant 1000 in tests/nvme/002, and prepares for the next commit.
> If this understanding is correct, I suggest to note it in the commit message.

This change is really just changing nvme/002 to use the same infrastructure
as nvme/030 uses. The number loops isn't changed.