Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 2 May 2023 19:00:24 +0300
From:   Matti Vaittinen <mazziesaccount@gmail.com>
To:     Matti Vaittinen <mazziesaccount@gmail.com>,
        Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Cc:     Matti Vaittinen <mazziesaccount@gmail.com>,
        Jonathan Cameron <jic23@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] iio: bu27034: Ensure reset is written
Message-ID: <ZFEzmA/0whRO6IFv@fedora>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="dohUr8GHFqpjSqLp"
Content-Disposition: inline
Precedence: bulk


--dohUr8GHFqpjSqLp
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

The reset bit must be always written to the hardware no matter what value
is in a cache or register. Ensure this by using regmap_write_bits()
instead of the regmap_update_bits(). Furthermore, the RESET bit may be
self-clearing, so mark the SYSTEM_CONTROL register volatile to guarantee
we do also read the right state - should we ever need to read it.

Signed-off by: Matti Vaittinen <mazziesaccount@gmail.com>
Fixes: e52afbd61039 ("iio: light: ROHM BU27034 Ambient Light Sensor")

---
I haven't verified if the reset bit is self-clearin as I did temporarily
give away the HW.

In worst case the bit is not self clearing - but we don't really
get performance penalty even if we set the register volatile because the
SYSTEM_CONTROL register only has the part-ID and the reset fields. The
part-ID is only read once at probe.

---
 drivers/iio/light/rohm-bu27034.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/iio/light/rohm-bu27034.c b/drivers/iio/light/rohm-bu27=
034.c
index 25c9b79574a5..740ebd86b6e5 100644
--- a/drivers/iio/light/rohm-bu27034.c
+++ b/drivers/iio/light/rohm-bu27034.c
@@ -231,6 +231,9 @@ struct bu27034_result {
=20
 static const struct regmap_range bu27034_volatile_ranges[] =3D {
 	{
+		.range_min =3D BU27034_REG_SYSTEM_CONTROL,
+		.range_max =3D BU27034_REG_SYSTEM_CONTROL,
+	}, {
 		.range_min =3D BU27034_REG_MODE_CONTROL4,
 		.range_max =3D BU27034_REG_MODE_CONTROL4,
 	}, {
@@ -1272,7 +1275,7 @@ static int bu27034_chip_init(struct bu27034_data *dat=
a)
 	int ret, sel;
=20
 	/* Reset */
-	ret =3D regmap_update_bits(data->regmap, BU27034_REG_SYSTEM_CONTROL,
+	ret =3D regmap_write_bits(data->regmap, BU27034_REG_SYSTEM_CONTROL,
 			   BU27034_MASK_SW_RESET, BU27034_MASK_SW_RESET);
 	if (ret)
 		return dev_err_probe(data->dev, ret, "Sensor reset failed\n");

base-commit: 7fcbd72176076c44b47e8f68f0223c02c411f420
--=20
2.40.0


--=20
Matti Vaittinen, Linux device drivers
ROHM Semiconductors, Finland SWDC
Kiviharjunlenkki 1E
90220 OULU
FINLAND

~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~
Simon says - in Latin please.
~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~
Thanks to Simon Glass for the translation =3D]=20

--dohUr8GHFqpjSqLp
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEIx+f8wZb28fLKEhTeFA3/03aocUFAmRRM40ACgkQeFA3/03a
ocU1Awf8D8Y7JyIoqDRcOcZTe1sTfU4Kamm+vdjzMCK/0HfzX23JKyK5OhOez80x
3XWGmzOklKTlRRlMSd/f7HsGozK6FNtdf2WS5kJBCsxp1DTO1w32lujTDcbQyzOF
anoxRgLhDB5JQAKbBmpU/PGWrkUwa47mdgCKP1iCXQQoSKnDHGt8GYm+4lEX77zU
jp2kTfuZaoLaXBgcMcZeiYRBwuWVHk1bmmXq6QXtrwAn7OuPk265vt2qhtSBx13k
lFts4Wgeoc5TChH3AAstXFB6CU+AIXE4V1OklhCaFDHvdVvf4I88lGWh2k8b8S29
TGWVa+VrNpfhyibdsrXCSiizoTdBdw==
=dBhE
-----END PGP SIGNATURE-----

--dohUr8GHFqpjSqLp--