Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 3 May 2023 08:31:24 +0900
From:   Dominique Martinet <asmadeus@codewreck.org>
To:     Jason Andryuk <jandryuk@gmail.com>
Cc:     Eric Van Hensbergen <ericvh@kernel.org>,
        Latchesar Ionkov <lucho@ionkov.net>,
        Christian Schoenebeck <linux_oss@crudebyte.com>,
        v9fs@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs/9p: Remove INET dependency
Message-ID: <ZFGdTDrPa1LD899y@codewreck.org>
References: <20230501190602.86281-1-jandryuk@gmail.com>
 <ZFAWaQbDR1_r5jf-@codewreck.org>
 <CAKf6xptMDRVet-C_1H7txPb_J_xq+XnNxwrQVbNWL_2JGnbHgw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <CAKf6xptMDRVet-C_1H7txPb_J_xq+XnNxwrQVbNWL_2JGnbHgw@mail.gmail.com>
Precedence: bulk

Jason Andryuk wrote on Tue, May 02, 2023 at 08:03:15AM -0400:
> > Good catch.
> > Could you add depends on INET to NET_9P_FD in net/9p/Kconfig?
> 
> trans_fd.o builds without INET and without UNIX.  Looks like trying to
> use either TCP or UNIX sockets would lead to runtime errors, but it
> also supports generic file descriptors.  That could be useful for
> someone.   Since it builds, would it be okay to leave this patch
> unchanged, or do you still want the depends added?  Leaving the patch
> unchanged provides more flexibility, though the runtime errors may
> surprise users.  While I built a Xen kernel without INET or UNIX, that
> is an unusual scenario.  Typically INET and UNIX sockets will be built
> in anyway even without a depends.

Hmm, good point; the socket interface is common between INET and
UNIX.. And you're right about the ability to use plain fd as well.

How about 'imply INET'? That will automatically select INET when
enabled, but allow someone to disable it explicitly.

It's rare enough that I didn't know about it though, just found it in
Documentation/kbuild/kconfig-language.rst ...
I guess this version is fine as is if you think it's too minor, I agree
kernels without INET ought to be rare enough and if it builds for
randconfig tests I'm fine with this.

-- 
Dominique Martinet | Asmadeus