Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 3 May 2023 09:27:48 +0900
From:   Mark Brown <broonie@kernel.org>
To:     Shenghao Ding <13916275206@139.com>
Cc:     lgirdwood@gmail.com, perex@perex.cz,
        pierre-louis.bossart@linux.intel.com, kevin-lu@ti.com,
        shenghao-ding@ti.com, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org, x1077012@ti.com, peeyush@ti.com,
        navada@ti.com, gentuser@gmail.com
Subject: Re: [PATCH v1 3/5] firmware: tasdevice_fmw: tasdevice firmware
 loading lib
Message-ID: <ZFGqhM0VYFdorkRa@finisterre.sirena.org.uk>
References: <20230502053235.27066-1-13916275206@139.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="jHuLl3Qdr+Gp3RDN"
Content-Disposition: inline
In-Reply-To: <20230502053235.27066-1-13916275206@139.com>
Precedence: bulk


--jHuLl3Qdr+Gp3RDN
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, May 02, 2023 at 01:32:35PM +0800, Shenghao Ding wrote:
> Create tasdevice firmware lib.

>  drivers/firmware/Kconfig            |    1 +
>  drivers/firmware/Makefile           |    1 +
>  drivers/firmware/ti/Kconfig         |    5 +
>  drivers/firmware/ti/Makefile        |    3 +
>  drivers/firmware/ti/tasdevice-fmw.c | 2380 +++++++++++++++++++++++++++
>  5 files changed, 2390 insertions(+)

Given how large this part of the code for these devices is it definitely
makes sense to split it into a separate commit like you've done but are
there any non-audio devices in this series which will share the same
firmware style?  If not then it probably makes sense to keep the code in
sound/soc/codecs, though a separate file would still make sense.

There's some devices that do keep firmware interface code in the
firmware directory but in those cases the devices have other, non-audio,
functionality which also uses the firmware (eg, always on monitoring)
but I've not seen any of the tas devices like that.  If there are some
then the split you've made here makes sense.

--jHuLl3Qdr+Gp3RDN
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmRRqoEACgkQJNaLcl1U
h9DwJQf/c04X1IDM9RQnB9HFoA2w4Yrd+wID6cNDcMHE05So35+rSAErad/PhU1k
1pu6mTeujT/5RanZL3cElVkqNaKgGy3bY0Aewu4BB6Jp0AkkM9+uk02lG6KHsnB3
ZPWke1iHD1uMIyNYAUm9mQM3pTYCmva2EI9/k6vBfAcfuVhBWDgke6GabRPtoaeh
tpND2K9ckr41xRW0s8GW+SJ+dH9E88V66qGoqez28A/iHjYUupdwEpQAzl6d7R5U
ICP0sv/RgamEp6yYLT/dj+muh/+gbyanTYvfKDPLfGKKUB8c84gCn4sKbQpEDaSf
anNb6TU9LQsQRxu8cijdPQ0YwrAvYg==
=KUlJ
-----END PGP SIGNATURE-----

--jHuLl3Qdr+Gp3RDN--