Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Xiaolei Wang <xiaolei.wang@windriver.com>
To:     aisheng.dong@nxp.com, festevam@gmail.com, shawnguo@kernel.org,
        ping.bai@nxp.com, kernel@pengutronix.de, linus.walleij@linaro.org,
        shenwei.wang@nxp.com, bartosz.golaszewski@linaro.org,
        peng.fan@nxp.com
Cc:     linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [v2][PATCH] pinctrl: freescale: Fix a memory out of bounds when num_configs is 1
Date:   Wed,  3 May 2023 09:21:27 +0800
Message-Id: <20230503012127.4157304-1-xiaolei.wang@windriver.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ZMZ7iVZr5M4dG24LzrjBdwbvIaX4qsFhL3dXZg9ycTk/L4nj5aoH8hCv8Iqf?=
 =?us-ascii?Q?aZFSIp6mH3IGKiomTJ5YXn3egJ86Qdt7nBt788//dayCQNqnPhXiYwyamQP1?=
 =?us-ascii?Q?pVJwjGJhqE+vO5wBMlPL3X75jaLBY/kqGueM6mLg3PYPe1H0vEwyauBibvSa?=
 =?us-ascii?Q?tepm7lgqWTUEaY1IVDAra/Ugn2i3w7L9mVpAoyR6OSaGK+kTJn7EfkCf+p5G?=
 =?us-ascii?Q?7gQt3X1sfS/5wJ6PuVFE8nx2Ypeqs7XnEMzJwQTQdf9omXHpNGwLeLj38Vmv?=
 =?us-ascii?Q?Bpyi9qycrEOkw4oE27XPlnMiAs8b25DOqM9WRzp04OexzGRMSiwevsCoKNUk?=
 =?us-ascii?Q?/ivFjFiEMBQ5HOb8eUonyxaTFfolHGBfwmYViMUor71shKJxJcn1CQKJi2GH?=
 =?us-ascii?Q?ztvGO9zyo65KoY0IYXnazSIIy+2WFxa09BWmJA2/rLHFcvZBmtaIr6rpWXAz?=
 =?us-ascii?Q?C+4pWRE5jgJ6lIGdVCn5/mAiD/AaSr5FtRLwI3Z6yA5wOyYbu1+pKhCPu7eU?=
 =?us-ascii?Q?kHS3Gcry6FxaX7RJjJI5PaP/2ES105Nqv8kGzUky+5ipkNHtJF2pTvBo+Lhn?=
 =?us-ascii?Q?FFQsnlQMKP4AsQUd7g2wMI1sehgZvGOPgBJrstaolha7MMFu2Ian8C+jMBis?=
 =?us-ascii?Q?xK9vMxtqQwsS+KlKzOJblGPsx8gymaVKV5LIEjeYrcyR2xf3bQx57AdTeU67?=
 =?us-ascii?Q?av4Co3p8JY3g/4nu7B9b2HR/ilVquGuXsJuVfWKezdSXyU94U79wFXYbYpT/?=
 =?us-ascii?Q?A1lfT4tURct2jaEiTAJGIdNvttPOigSJRYnteQnShY+ufaWRWN1GKPOwYsXC?=
 =?us-ascii?Q?nxrGLhL/3n7sbrXqG00lTUC2ypTAm+7HDbfRu2rGhA31YCQWmWEOsNVpxiK7?=
 =?us-ascii?Q?l/fQCK/R4k43OYV7FvHelSpCf3jVXiTEYk6Tr0r3vME+52U4NJ7JEWqhySKY?=
 =?us-ascii?Q?TgfYQG5+Qt331O0OZEBhCbPFnp+sQVy7SZInvwWarIwNxDhMtUvBB3CuNkD5?=
 =?us-ascii?Q?zkfyNNzQs/88JwPrfnc5kKanQwcBC9vGo8XQi+EQ5tlP8JFt7aB188Ain42V?=
 =?us-ascii?Q?499gHMGFYoFO3wAihdoHBBtzsIAFZTkrbL+x+x8xsMClHiFASSRT/04nM17c?=
 =?us-ascii?Q?jagqhObI6vLuzLF1qU8CkVL3BH3Ji97Jgtt81sxY0a66lITmNcd5LRs1n3xS?=
 =?us-ascii?Q?XcsXZEtZIJe0aHkw7yhaE2p6b8l8ugMt7CRrt7VJGzq6RmhZnz1rWnqFCF1d?=
 =?us-ascii?Q?r8Hp0xDt+n8Jvx0shft4yV6SYarmsb3wjaKgQwPnd1rzaT/VgbniB3gNbBYw?=
 =?us-ascii?Q?hIPmKY74H6CUwIgGWOrcdqn+qZhsskSKChCZbtuUZAaAVXWzfAYW0BwUNlm0?=
 =?us-ascii?Q?U9l1HcB4QAvCIwcp1anB0PfLVMqppedNwS7aZLFK4LxvvSmcmxz6IvOavHBv?=
 =?us-ascii?Q?2taozG9y3Y31FmLoW4FjeAd/yLOI3tgNWCkTMCvwD4qVIAvp4NGbi4nZIo8H?=
 =?us-ascii?Q?KKvlkHHmrHzVrRqKHQ8TmHLSBm2e/gkGpDRbnyrF2nkzrAuitWrJCNVmoSVa?=
 =?us-ascii?Q?HKidAia3pmwq0ItOu1Tx/gBPz5PAhJmJFmLWNk+kHDniCwkRKM874JMCAR85?=
 =?us-ascii?Q?RA=3D=3D?=
X-OriginatorOrg: windriver.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 85e9c5d2-84fd-4276-f8f6-08db4b74c7d1
X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5764.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2023 01:21:54.6533
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sjPE3ccb0ldYqO/EsqqN0HBQO7paD8nsIGjwI8/RbGlJgUAkSSnWRlbDHCp8/8D6BUn4/oex+8qChB5sN6jbnQaTMzsSqWTD5P+l8jynnsw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR11MB5711
X-Proofpoint-ORIG-GUID: iXhrNyVLBJ4qkcJjRqCTKc2TSY_LDZ53
X-Proofpoint-GUID: iXhrNyVLBJ4qkcJjRqCTKc2TSY_LDZ53
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-05-02_14,2023-04-27_01,2023-02-09_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0
 lowpriorityscore=0 spamscore=0 clxscore=1015 suspectscore=0 mlxscore=0
 phishscore=0 priorityscore=1501 mlxlogscore=590 adultscore=0 bulkscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2303200000 definitions=main-2305030009
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,
        SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The config passed in by pad wakeup is 1, When num_configs is 1,
configs[1] should not be obtained, which will generate the
following memory out-of-bounds situation:

BUG: KASAN: stack out of bounds in imx_pinconf_set_scu+0x9c/0x160
  Read size 8 at address ffff8000104c7558 by task sh/664
  CPU: 3 PID: 664 Communication: sh Tainted: G WC 6.1.20 #1
     Hardware name: Freescale i.MX8QM MEK (DT)
  Call trace:
    dump_backtrace.part.0+0xe0/0xf0
    show stack+0x18/0x30
    dump_stack_lvl+0x64/0x80
    print report +0x154/0x458
    kasan_report+0xb8/0x100
    __asan_load8+0x80/0xac
    imx_pinconf_set_scu+0x9c/0x160
    imx_pinconf_set+0x6c/0x214
    pinconf_set_config+0x68/0x90
    pinctrl_gpio_set_config+0x138/0x170
    gpiochip_generic_config+0x44/0x60
    mxc_gpio_set_pad_wakeup+0x100/0x140
    mxc_gpio_noirq_suspend+0x50/0x74
    pm_generic_suspend_noirq+0x4c/0x70
    genpd_finish_suspend+0x174/0x260
    genpd_suspend_noirq+0x14/0x20
    dpm_run_callback.constprop.0+0x48/0xec
    __device_suspend_noirq+0x1a8/0x370
    dpm_noirq_suspend_devices+0x1cc/0x320
    dpm_suspend_noirq+0x7c/0x11c
    suspend_devices_and_enter+0x27c/0x760
    pm_suspend+0x36c/0x3e0

Fixes: f60c9eac54af ("gpio: mxc: enable pad wakeup on i.MX8x platforms")
Signed-off-by: Xiaolei Wang <xiaolei.wang@windriver.com>
---
 drivers/pinctrl/freescale/pinctrl-scu.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/pinctrl/freescale/pinctrl-scu.c b/drivers/pinctrl/freescale/pinctrl-scu.c
index ea261b6e7458..3b252d684d72 100644
--- a/drivers/pinctrl/freescale/pinctrl-scu.c
+++ b/drivers/pinctrl/freescale/pinctrl-scu.c
@@ -90,7 +90,7 @@ int imx_pinconf_set_scu(struct pinctrl_dev *pctldev, unsigned pin_id,
 	struct imx_sc_msg_req_pad_set msg;
 	struct imx_sc_rpc_msg *hdr = &msg.hdr;
 	unsigned int mux = configs[0];
-	unsigned int conf = configs[1];
+	unsigned int conf;
 	unsigned int val;
 	int ret;
 
@@ -115,6 +115,7 @@ int imx_pinconf_set_scu(struct pinctrl_dev *pctldev, unsigned pin_id,
 	 * Set mux and conf together in one IPC call
 	 */
 	WARN_ON(num_configs != 2);
+	conf = configs[1];
 
 	val = conf | BM_PAD_CTL_IFMUX_ENABLE | BM_PAD_CTL_GP_ENABLE;
 	val |= mux << BP_PAD_CTL_IFMUX;
-- 
2.25.1