Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 2 May 2023 22:02:24 -0500
From:   Jeff LaBundy <jeff@labundy.com>
To:     Tomas Mudrunka <tomas.mudrunka@gmail.com>
Cc:     dmitry.torokhov@gmail.com, linux-input@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] Fix freeze in lm8333 i2c keyboard driver
Message-ID: <ZFHOwEu6tKDjoPA4@nixie71>
References: <ZEnErxfnSn2JOpvm@nixie71>
 <20230428102015.810686-1-tomas.mudrunka@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230428102015.810686-1-tomas.mudrunka@gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?gQHsAFAPeB4waTIB/SZTKyrEHg0FvrGTegbo9EVYJ3F2uk+YKH0I605OlnFt?=
 =?us-ascii?Q?ZpgiXInzG/vwrNV6IZnJdN5kwvysybNItn2LeZ+4SWnIWN+VOw5GK5yKXVru?=
 =?us-ascii?Q?Qft4DkInxve0ztltPXyks3OJLXJC9OfIHG/Y/gIywYXcR44v7h1oCWuoAw+m?=
 =?us-ascii?Q?V1GSb4WgAZ91GmAL6GNAHQdqN/oKFpFTOrxiMM63PGt+NUbR/J56aMABf1U9?=
 =?us-ascii?Q?ah3s7jHduO5jtE2S8rWSwKiO71GUv/IJT+mMyYLqxmFOne87Lfo54iDOO9gm?=
 =?us-ascii?Q?F4amCSjOFkONSk+4dGjDfjusizDOQUzd/zFT5E/HmCnfMaY+6Zt0usWhfCZg?=
 =?us-ascii?Q?lV5gSZ4yYYIhvBtYvqOT4+pHJDRY1SZ7LuNg934MEv+daEcS5V88xhS0DO91?=
 =?us-ascii?Q?jwMWVmbQX2Xb8rY5/h3V1MV91vcvOuuSBWAUt7TbyuEIccITE62KY2bqksxH?=
 =?us-ascii?Q?NbuNptqA4yuARMRge9adlyp3A86sm9SReiQlNwfncsQupssefuFKnvqoF58S?=
 =?us-ascii?Q?gBsahIhjIhmPE+ioCR1M86xc3CVWMDh5aMUr3Zx7MJOGVgQHNiHRodpZB8Rr?=
 =?us-ascii?Q?ggDQjMKcydRLqYTUlY2H8xBp8+0PfuP5zGY5SNfCNPRI5ppdiqMgS+Ol0dQl?=
 =?us-ascii?Q?Sx/P0ylXspgU9lG0XM0k1qpiXkpqbejWJO/WyHsbkuzWvstsfeI06F8k0mN5?=
 =?us-ascii?Q?V4ToarEgfhuRCovVy7pW4AIqiJ1lNT7O49EgJAxh6JcypaIxQis8eAiMYHk6?=
 =?us-ascii?Q?FHoetNQ/GlUbi6HRWix+8t91hZ454ccz3opvFa93HqqDy5khNMooCesKeMXj?=
 =?us-ascii?Q?TnjzaoLpm8z8xzl5hpntKCk1z2eflV92ng9nq5inRAJ7GWKYkLkmosUqoNH0?=
 =?us-ascii?Q?hE7gcWSXfJ+htGIPkMXRmtTefHtgwBG0PA9ebnpbyPTOCS9kbyHEv/earmfp?=
 =?us-ascii?Q?uV96G9XroSuwHA6dHM4qw+3mlkywM/FcQs0sW+5YvnGDiHXbAjEiZ0f5zh8/?=
 =?us-ascii?Q?rplY/8XKNCT6B+Isrdy+3qo+HSZmNr0dR2bBA0A8JXVNfMeogdRw4V9RT4PL?=
 =?us-ascii?Q?RoNqwuZK8BhKFV4SCUFMuvWKyHU7cUXkNk8sK8dZuFz3UyWS3YgsjcgnG7wf?=
 =?us-ascii?Q?PTR/WCTSn9Lm66Jg+ossG2Xipq4bYq2/yrQ3zv7Ez1fwN5WYrYm+E5YXlsu+?=
 =?us-ascii?Q?AB8+RiV0Ip21EhkHoTwJ3oFINrhCdvhVQhkx2lLHzrFFgpkQTxYsYYh3752/?=
 =?us-ascii?Q?z6wJ0PNI7tmJhfEpScOsjZ1dmjWQi+4pRi8Ujm8mKfg42F0TVivXfRS3pssg?=
 =?us-ascii?Q?vhNXumIdk9oIMgGBDr7e01hC4YbQupurO3cbiKlO3C7peAOzywWVdMUhuUDz?=
 =?us-ascii?Q?GA6bHHlrHicFlXp3gtEPNBWIN/c0saCVPHSIxaGWfJ/E1IjWYwnRexfCx1jR?=
 =?us-ascii?Q?q3EnVTBO29Vb7hp0uRaixd0PuFHe+RHWV58NbGUFCvi9y9P6R9Ucd+2Noozg?=
 =?us-ascii?Q?cTlzx5MraAdw92YM3eRSOMo8TORmsQgvewIgVLs72vRTvV+P/LutqgFN6njb?=
 =?us-ascii?Q?CZdP9mirXUBNnb7zRDrD1tBIBCKi+5hQbSTCiAF/?=
X-OriginatorOrg: labundy.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d12f2c65-f5d8-4f10-bbe2-08db4b82d691
X-MS-Exchange-CrossTenant-AuthSource: SN4PR0801MB3774.namprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2023 03:02:32.2560
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 00b69d09-acab-4585-aca7-8fb7c6323e6f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Iig3eWN92VpzEuHrNaNodnasX2vwRzacEAaW6UApjG/YvhmEUIk7uRF52N+P83Giyr73Ihyob1DUyueAgFHVnw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR08MB7214
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Tomas,

On Fri, Apr 28, 2023 at 12:20:15PM +0200, Tomas Mudrunka wrote:
> LM8333 uses gpio interrupt line which is triggered by falling edge.
> When button is pressed before driver is loaded,
> driver will miss the edge and never respond again.
> To fix this we run the interrupt handler after registering IRQ
> to clear the interrupt via i2c command.
> 
> Signed-off-by: Tomas Mudrunka <tomas.mudrunka@gmail.com>
> ---
>  drivers/input/keyboard/lm8333.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/input/keyboard/lm8333.c b/drivers/input/keyboard/lm8333.c
> index 7457c3220..9a810ca00 100644
> --- a/drivers/input/keyboard/lm8333.c
> +++ b/drivers/input/keyboard/lm8333.c
> @@ -184,6 +184,8 @@ static int lm8333_probe(struct i2c_client *client)
>  	if (err)
>  		goto free_mem;
>  
> +	lm8333_irq_thread(client->irq, lm8333);

Just to clarify, my stance is that this call should go _before_ the handler
is registered. Your earlier statement that doing so would steal any pending
status from the handler is correct; however, it is a moot point because the
handler cannot do anything with that status until the input device has been
registered anyway.

Any events that come before then are off the table, and this is OK because
user space isn't going to start consuming key events until well after this
driver has probed anyway.

The reason behind my assertion is that as a matter of best practice, you
should not have two asynchronous threads that can in theory access the same
register. You are correct that the handler would simply return IRQ_NONE in
such a race, but it sets a bad precedent and opens room for bugs in case
this driver is modified in the future. It also creates one unnecessary I2C
read.

This is why it is much more common to register the handler _after_ manually
accessing read-to-clear registers; the register access remains synchronous.
In case you feel I have misunderstood, please let me know.

> +
>  	err = input_register_device(input);
>  	if (err)
>  		goto free_irq;
> -- 
> 2.40.0

Kind regards,
Jeff LaBundy