Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
To:     Daniel Wagner <dwagner@suse.de>
CC:     "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        Chaitanya Kulkarni <kch@nvidia.com>,
        Shin'ichiro Kawasaki <shinichiro@fastmail.com>
Subject: Re: [PATCH REPOST blktests v2 3/9] common-xfs: Make size argument
 optional for _xfs_run_fio_verify_io
Thread-Topic: [PATCH REPOST blktests v2 3/9] common-xfs: Make size argument
 optional for _xfs_run_fio_verify_io
Thread-Index: AQHZeX1i8rG2HytVkkq4pAqFsLjcxK9G/3mAgAD2XAA=
Date:   Wed, 3 May 2023 04:04:50 +0000
Message-ID: <i426otrfqbck2q5cwgzre52zsiaqviqz4jchszqmvbvgc64cue@a7d3frn6b64x>
References: <20230421060505.10132-1-dwagner@suse.de>
 <20230421060505.10132-4-dwagner@suse.de>
 <le6qqxhkbdaacsifz4b3mody53gllg4rzhowm2j62y56y56y6k@pmlukhvwjw24>
 <clh6gmnivvi5e4o7pzr3mxfale3vlymgepdntkjtvub4cazyvk@myovldb6bcnx>
In-Reply-To: <clh6gmnivvi5e4o7pzr3mxfale3vlymgepdntkjtvub4cazyvk@myovldb6bcnx>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?EOD6OyDL311BZkJ6g25fliG+HiaCTSvGuKydoA6TVnEXPYqvJ4o2TzlYTTWc?=
 =?us-ascii?Q?9Qv6rWsEQn25rhhydhD8RVP3jktaYWU4SXnSYJ8+OQPVnJ7QzJ6e42hINbHm?=
 =?us-ascii?Q?3M3+8ZDu90f3pqZ426H6fVjTtoOpNLpmDCjLqabJFJu260TL+b4ygzaVGoUj?=
 =?us-ascii?Q?N/WNHVI/bjhu0zJ84noPCyjZTw2FW7EV2DgiHgg72P7fVw+SQ0y8NRfrWkzt?=
 =?us-ascii?Q?u8gaqPMHxxjKMFbLuhJDlHQjl/+MKYNqukf/37Fj9ZE8BBo/HUavndk8rkI2?=
 =?us-ascii?Q?hH1o/PhbfSKvPeVtHGP6ix5fSPRS+lxvgdB16yGp4qYqtRi0mrEK0QM5TNdL?=
 =?us-ascii?Q?k0epKJGCTsFybLplo0YrBQCUYB1GmXQJUQcKBQnuavc0+NNtORqB0sv2fwcj?=
 =?us-ascii?Q?e9ZNdJZjsrKbj2MiCthQueYNVxYwHzuvTlJOJQ3WKyHlGZDM0lZGre6tIxZH?=
 =?us-ascii?Q?LLGkufwNvK51qkhyxdzLnXLfeElocq0fyt3CIJ936v6PSzyvP6Q+AiYLChb8?=
 =?us-ascii?Q?BrGlb3JJ2F3+v2WAJN+ixIRZ5pPFbeEYxcakLqlxMjfKJQG4WvndrEahZb72?=
 =?us-ascii?Q?mLT4X0A/L355CHzEqFV8ZRIoC6JpJ3oEsJocr2IV9aybrweTxhFmpMEKlO7f?=
 =?us-ascii?Q?zYuU/wU4yOj9omVilj53/maoZbZ8u3qyVJNHv3Q5ZJKdycdfXAxvQEQ2aHZ4?=
 =?us-ascii?Q?dYU7cZuWPncFBdnimDX3KRIQPw983806DWzsE51dI6VAHU6Faq7DhDIIXses?=
 =?us-ascii?Q?9wVvgy1nrVZwVYkeYZyRAS2ditrdikMcNI3csd0WngSLnZv9ANzuOWhs7cuP?=
 =?us-ascii?Q?Ael10GfYFGan9ymdKZ1dtChYSjS2eGXaFI2G9qHictJyjdj+akSxPjZP1bTa?=
 =?us-ascii?Q?nlMiZiRs7Tlc3gpKlTMhq5gD5vE0yXrR+1SLcM3YZEiHWclIU70VmKZ/ID+Q?=
 =?us-ascii?Q?R91aDaGRoS0BbkGvB9KV502FAxSTBAkfYiP2m0JbIFjaWPSXPZMH0iDWczOT?=
 =?us-ascii?Q?wkd1V2MIUNBa0r+szg6xnJ38UcxE6OyohKSabHq7Z7kN0fpT+POT837H7CJQ?=
 =?us-ascii?Q?7xqRuY7ZqkR9CHH1R2sH27pzw5YoOc+5LQOCAsJlqhmdBtMdXt8UomN3GUF6?=
 =?us-ascii?Q?7Qis2hWAC8Wk8/ZkGkmeEqhVE6mpkRZOx8ksmQdgfCXM7bzxafkz/2Aq/m+L?=
 =?us-ascii?Q?zCwS/Em+P1IACbmfCWyX0miRU7ILdPone0mgWuTSqTXIUwtmzU+9kpnsuIfb?=
 =?us-ascii?Q?5WUBj6vZlhXV0gf29dFr7BwGyYdj7e4MbkrF8jk98f6MWAi/U7xeYr14H3Go?=
 =?us-ascii?Q?X4PMGD5VIIbtE4cWM+D9DqXj0XgflTyGpgghorlXPbUohy5Honfao2So7rFF?=
 =?us-ascii?Q?q58wkpCqW62SRP4mHK2UdHAT1vY1iTe6hqPbxIkFdytSfS7GVUoEAFc3VFPQ?=
 =?us-ascii?Q?YKP38KsRoCsnU/GwM58pjGhrmwjiZfDeZXtD1tuuTYYWGJoS6GofYASngbEH?=
 =?us-ascii?Q?9Hd8oP80QYML20oJGz586164MySMHga1HX8ubEz3akb/FGFR7pKLG4bfwXST?=
 =?us-ascii?Q?amZHxojUapK8ON9zUvgrUgN7XorOFHZgWcW9FO5gM/GCX/orsk6ZI7hGe6Fc?=
 =?us-ascii?Q?Cg=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <74ADC7857196C149AECC5FE2E5E8767C@namprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: TXEVRRNuCkv7LCNCxfzBwYrjjTXnt0sTgqa3f+hzraKl4CISTLoi8aURxqhkx/34L8AQMFRHvDu0RJJX5tXcXU3R6SZhgEYXagd6ZUhe2DYUnrwGdbuJCiHJkDgxePeb4k41YfqYPnmpt0z1FdVWUOVmya9eC9DtMZhLA43v9gYaMdsPsfgd0crmFIgiOmqZgrxNGE9V1lQpfG4NT0zxlESIEt9UmFqTf3nxzu2bB3bfCSAWq0PurUDnn+Lox0Lk+dpjIdZoODGgFFqfI8UVEBLY2zs/YKXO09dWQu8pt34FzX+wuIo3rM8+7Vx6S0y5+F2TxslMH/7mlHAuZeyawwwJFx5bPBl0sZ4Gi2CxVnFaI8tpOyUvuA1/LSRLgIHFGMUXWoW3R4Gi4ennJsSYrx4TkCIS2TYmFHFxSoYs6MdDtZEAquZo0dX/AuQIaWYgt5b7/bw2ST4z8l0RCh+VfD44ye5PfCT/50ZG+4vXWjNeURdx/ZqZ0GdnJJAhBAOFzlH/HiUy4rHCFsQqpo9CgHfyeDunpTY39OqFxzNC0tutmBlJ8hW1YXDVDKFzK3/npNEDNN8n2f2/JHYVvmwor+ZwfV4GZfAQaim9ccFDy3uPm8slCYQLpxpfjclRYtkC+o+Gua8+Dl9xZFTLrn9/YkbnYTtrL+Doiwe3+CCfOuJyBkCI0JbspBt0RPoRaMn7HXsEww3CvcfpPTWBVN71MImvYVZAB/nczUWSvXfil9wSsKYeMtTRBkAiiEs/RK4l9zp+K8Qguz1KfZaNXgrtLQm41eGQRxbwPf6kH+MDnoMJ3gHt78eATjvvWLMNZP8T2fPwtq4VwqccoRGL4WNHEc4ZuZwpAJNIyobiUnU9o5OAAzMIuNjqtjf4I3wqKe6zhRqE238pU5ha7ETvFuwTBwBBwynTmaVV53FzIE8hfAQ=
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM8PR04MB8037.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 613e3431-8cbf-4aac-93b7-08db4b8b8b13
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 May 2023 04:04:50.8622
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: z5uS/HbTeU39l/91slA8qw7m2mez4tBVEdDVdCemM+XnfRR8JMaCxistmBSnsfX+lW1Kf9DaQTtw6cHzBowhRQ05+SUZz1SGrBKdROO/3W4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR04MB6880
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On May 02, 2023 / 15:23, Daniel Wagner wrote:
>  > --- a/tests/nvme/035
> > > +++ b/tests/nvme/035
> > > @@ -32,7 +32,7 @@ test_device() {
> > >  	port=3D$(_nvmet_passthru_target_setup "${subsys}")
> > >  	nsdev=3D$(_nvmet_passthru_target_connect "${nvme_trtype}" "${subsys=
}")
> > > =20
> > > -	_xfs_run_fio_verify_io "${nsdev}" "900m"
> > > +	_xfs_run_fio_verify_io "${nsdev}"
> >=20
> > On the other hand, this change for nvme/035 does not look good. It runs=
 the
> > test on TEST_DEV, which may take very long time without TIMEOUT config.
>=20
> I'll add the nvme_img_size argument here instead (nvme: Make test image s=
ize
> configurable)

If TEST_DEV has the size same as nvme_img_size, xfs log data will consume s=
ome
part of the TEST_DEV, then _xfs_run_fio_verify_io with nvme_img_size will f=
ail.

I think the size argument of _xfs_run_fio_verify_io should be,

   min(size of TEST_DEV, nvm_img_size) - log data size of xfs

But I'm not sure if we can do this calculation correctly.

If the calculation is not possible, it would be the better to leave the har=
d
coded constants (1GB for TEST_DEV size and 900mb as fio I/O size) in this t=
est
case, because nvme/035 is rather unique in the nvme group, which uses TEST_=
DEV.=