Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 3 May 2023 09:07:39 +0300
From:   Tony Lindgren <tony@atomide.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     Julien Panis <jpanis@baylibre.com>, arnd@arndb.de, olof@lixom.net,
        soc@kernel.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org,
        linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH] arm: dts: Add am335x-boneblack-pps.dts
Message-ID: <20230503060739.GM14287@atomide.com>
References: <20230428105453.110254-1-jpanis@baylibre.com>
 <8e1ee169-603f-4aa4-9f02-68520d708d57@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <8e1ee169-603f-4aa4-9f02-68520d708d57@linaro.org>
Precedence: bulk

Hi,

* Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> [230428 13:50]:
> On 28/04/2023 12:54, Julien Panis wrote:
> > From: Lokesh Vutla <lokeshvutla@ti.com>
> > +		compatible = "ti,omap-dmtimer-pwm";
> > +		pinctrl-names = "default";
> > +		pinctrl-0 = <&pwm7_pins>;
> > +		#pwm-cells = <3>;
> > +		ti,timers = <&timer7>;
> > +		ti,clock-source = <0x00>; /* timer_sys_ck */
> 
> Why this is hex? Should be just 0/1/2?

I think the ti,clock-source can be left out now, this can be done
with assigned-clocks and parents instead. Please grep for some
examples in the current mainline kernel dts files.

Regards,

Tony