Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 3 May 2023 09:15:57 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Justin Chen <justinpopo6@gmail.com>
Cc:     netdev@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
        dri-devel@lists.freedesktop.org,
        bcm-kernel-feedback-list@broadcom.com, justin.chen@broadcom.com,
        f.fainelli@gmail.com, davem@davemloft.net, edumazet@google.com,
        kuba@kernel.org, pabeni@redhat.com, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, opendmb@gmail.com,
        andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk,
        richardcochran@gmail.com, sumit.semwal@linaro.org,
        christian.koenig@amd.com
Subject: Re: [PATCH v2 net-next 3/6] net: bcmasp: Add support for ASP2.0
 Ethernet controller
Message-ID: <ZFIKLRqFaJSHEIwp@corigine.com>
References: <1682535272-32249-1-git-send-email-justinpopo6@gmail.com>
 <1682535272-32249-4-git-send-email-justinpopo6@gmail.com>
 <ZFFn3UdlapiTlCam@corigine.com>
 <CAJx26kV9E7M5ULoPqT8eJ5byaUEZDtW6v25f3DT04xs4NGcd6g@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAJx26kV9E7M5ULoPqT8eJ5byaUEZDtW6v25f3DT04xs4NGcd6g@mail.gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Wms2cXpHNG9Fbk1ycEwwdTlBSGlQN2VuT0Fia1hIaEN5V0U5cnREK2dVajEw?=
 =?utf-8?B?WTh3cGlZWXRIT0dmbGFJelYwbkw5YXQ5TUJLam5EZGJLUi84U3ZFTXNnN1Ey?=
 =?utf-8?B?cjRFZHY0MFJTUHNVaDc2STVrVUdzL3lGaHBHM1p5TXNyWmdyc3hicW1Ta3ZC?=
 =?utf-8?B?Y3hYZDBYR3A4WFJNTXpmSFlveFNsdXoxSitCWFNnb2RXU001UmlPTnQybSt3?=
 =?utf-8?B?Zk04REpTMXp4TjVlRU1XcG9yOG5xTTlTUFMzOVpIL2lOcUJ0RWdCTDBlNmQ2?=
 =?utf-8?B?OFZldFJjVE1nR2lWdlZlZTV1NzUvVlROeGxBYTM5Z0dWYisxeWh0ay9pbjBK?=
 =?utf-8?B?b3haQ1dzRGQ1elhza25QUE1LcWwwampRZTFWOTV0dlRIc0RFN3p4eWQxWFNU?=
 =?utf-8?B?eGhGSVo0eERBR2cwNlk2L0hsNTR4S0JrWit4OFh3VUZjR3FZNk05SFdJdUNo?=
 =?utf-8?B?UTFYaVZYZFFxb1JyRGhFNVRDYVpFTndOMjdQS2Z5MHc5MlViSnRleTltUGNx?=
 =?utf-8?B?Vk13ZmMvYVdacjJSS2U3T1NITis0ZkEwNjhZcjRxZS9wVTQyZEE4SXBvM3NU?=
 =?utf-8?B?WnMxZTNFd3RZR09VQWE0dm1IY1B2UzdYN1hXM0dJYU1CYkVWeW42WEdZVjlk?=
 =?utf-8?B?SWIrT24xamZhZWR5c3p4YVNVaU0zTGttanpCOFNwK0VvalJzUnR0MjgxZ0po?=
 =?utf-8?B?WW00SnlFQm9CeU41eFFGdnR3aW9QazV1aXZPanUrNzBHeGFPczV5TGxhcWVx?=
 =?utf-8?B?Q2hlc2d3THRvMjZCRFNTYVNJZzdYREhwYjVpSGxpM3F2d2NPak5oVDJHclM2?=
 =?utf-8?B?S2x5Z1FzekowZEFwcDEveDRhaFJQLytTRklQaWY2OTlwSlo4ejk0RUxoYURw?=
 =?utf-8?B?dDUwb3RwTE9zT21tMjRVOFdVM2paWUVEcmdlZUQ3QWcwK3hXV1JBYUh1dnZI?=
 =?utf-8?B?OVd6Z05OcGRIMjZRN1NJZFlTc0EyZ3drblVPR1Y2dXcvU2ZjdXRhQzE4dzMz?=
 =?utf-8?B?aWZXYk45UUorS0hIL3d6YW1yaEtKc3RWdFFEdFcrTTNmUE9KaU9CY3VtcitH?=
 =?utf-8?B?bFQyaWQyZnBSWXFHWTQ2cVNxRjFBWWVlYmhIRy9rOUNoQVYxS0IwVVZqeVVC?=
 =?utf-8?B?NXhqbjFPV3Z1RUJTS2xYOWZNb29xc2xJdXJpdHREVzc2ck1CNUszQXJKbFcz?=
 =?utf-8?B?Vjk4Ymk5TUdPWXI2OUNybTBobjRkemZtQ2lwVVF1YVpRRXNrVytCNXl1M2lT?=
 =?utf-8?B?ZDd5T253RHRLbUlpOTRjbTdMVDNBUHAvR0hlRkNvRHpWTUMwM1YvR0FnVHZw?=
 =?utf-8?B?ZFFtcFNnRTdsV3V2VnJKeGgxSmNCVnJvTzVEa2xHdU1PaWZhVHZWUjh1V1RC?=
 =?utf-8?B?OXlhWGFTeXk3QVFDYlFyVkI5c0xZUmhvZzd3SXQyNDVrSGs3VGJhaVZ0OEd2?=
 =?utf-8?B?WHRJdjRpMHlSd0JONlY2cklLM3V2ZklQZzF5YzF6SE5oY3VtMTROalFIZFhh?=
 =?utf-8?B?ZW43bzdFTndZZmlJNCtLM1NZemNtZWN5M2tjRXVCa3pUcmE0NUN1UENnbkh5?=
 =?utf-8?B?aXJiUkllSlRXcDBuYVBGUEpSTCtvd0NpSW1ENGVQWEdtYWZ0VjF3d1d0M0dN?=
 =?utf-8?B?WjlQWEJiZmFJUjJoK2xuQzhGYklocVNIVmZZZW1CbmxtUEdJTUUwSkF6YmM1?=
 =?utf-8?B?OXhKT2pRNHVndVlVOUxaaHk0a1F2QWlOTEZNYjV0TzVuTGlHYkJONTMrcWFs?=
 =?utf-8?B?NlFTVjhCU0Z3SnZMUk53YWtRM1RFUGRoNko3RGtQUnk2MnB1cnhuZ1FCUVVz?=
 =?utf-8?B?R0crYWRMd0xGVmVIb2pOcy9QMDhVZWlDKzJZeHVwaHRPNHdQTExmNXViTitl?=
 =?utf-8?B?d3F1eC95RE4vd2dKNW1SR1gxM2d3b0VBVWoxZU44N01VM0gyNHlrUmlCM3hY?=
 =?utf-8?B?ZVRDcjN5NDJ4cDNjSWxYUlR1QXRsSGUvZmFCU3drQm0zMHI4U1lNc0N3R0cv?=
 =?utf-8?B?ZW9OMXJybGdDZGNlNkR1dmY2WVI5eUg0aFZwTTlUaVpUNXZTZGI4SGUwQTRo?=
 =?utf-8?B?UDVUTjR5QXVIM3pzcFQxQm5hVndhNyt0Y3dDb1pzRWhaZ25ZVHFheEhQU011?=
 =?utf-8?B?SC9BQ3M0bXVmYXJmbi81cllZbW13SkUva2FNM1lwcEZsQ0tqSkhGeGR1dDlD?=
 =?utf-8?B?V3BFNnRlWXNZNzNXMUI4OUE3VDJKdVA2NkFrbXJ1WnBSbG9ibU1CVVZvaVds?=
 =?utf-8?B?bkI5Um5hRFROTEsxQm4yYldvL0VnPT0=?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 36667392-9ee6-4680-c186-08db4ba6424e
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2023 07:16:05.5082
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Xg+Ir7FE+BGLC3j5W8ZwwwS1wTTev3pAr+MzqvBFu2veFyyppeAgT8HDC06OLHgLz/7TXq3rqSKek5iU2P3h5c/wCdSuWPYTfk+tGAHl2b8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR13MB5972
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, May 02, 2023 at 02:26:53PM -0700, Justin Chen wrote:
> On Tue, May 2, 2023 at 12:44 PM Simon Horman <simon.horman@corigine.com> wrote:
> >
> > On Wed, Apr 26, 2023 at 11:54:29AM -0700, Justin Chen wrote:

...

> > > +static void bcmasp_update_mib_counters(struct bcmasp_intf *priv)
> > > +{
> > > +     int i, j = 0;
> > > +
> > > +     for (i = 0; i < BCMASP_STATS_LEN; i++) {
> > > +             const struct bcmasp_stats *s;
> > > +             u16 offset = 0;
> > > +             u32 val = 0;
> > > +             char *p;
> > > +
> > > +             s = &bcmasp_gstrings_stats[i];
> > > +             switch (s->type) {
> > > +             case BCMASP_STAT_NETDEV:
> > > +             case BCMASP_STAT_SOFT:
> > > +                     continue;
> > > +             case BCMASP_STAT_RUNT:
> > > +                     offset += BCMASP_STAT_OFFSET;
> > > +                     fallthrough;
> > > +             case BCMASP_STAT_MIB_TX:
> > > +                     offset += BCMASP_STAT_OFFSET;
> > > +                     fallthrough;
> > > +             case BCMASP_STAT_MIB_RX:
> > > +                     val = umac_rl(priv, UMC_MIB_START + j + offset);
> > > +                     offset = 0;     /* Reset Offset */
> > > +                     break;
> > > +             case BCMASP_STAT_RX_EDPKT:
> > > +                     val = rx_edpkt_core_rl(priv->parent, s->reg_offset);
> > > +                     break;
> > > +             case BCMASP_STAT_RX_CTRL:
> > > +                     offset = bcmasp_stat_fixup_offset(priv, s);
> > > +                     if (offset != ASP_RX_CTRL_FB_FILT_OUT_FRAME_COUNT)
> > > +                             offset += sizeof(u32) * priv->port;
> > > +                     val = rx_ctrl_core_rl(priv->parent, offset);
> > > +                     break;
> > > +             }
> > > +
> > > +             j += s->stat_sizeof;
> > > +             p = (char *)priv + s->stat_offset;
> > > +             *(u32 *)p = val;
> >
> > Is p always 32bit aligned?
> >
> 
> Nope. I can make sure it is 32 bit aligned.

I'm not sure if it helps, but you could also consider put_unaligned().

> Acked, the other comments. Will submit v3 when net-next window is
> open. Thank you for the review.

Likewise, thanks.