Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 3 May 2023 09:17:28 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Dominique Martinet <asmadeus@codewreck.org>
Cc:     Eric Van Hensbergen <ericvh@gmail.com>,
        Latchesar Ionkov <lucho@ionkov.net>,
        Christian Schoenebeck <linux_oss@crudebyte.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, v9fs@lists.linux.dev,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 1/5] 9p: fix ignored return value in v9fs_dir_release
Message-ID: <ZFIKiBXbgtFLymLg@corigine.com>
References: <20230427-scan-build-v1-0-efa05d65e2da@codewreck.org>
 <20230427-scan-build-v1-1-efa05d65e2da@codewreck.org>
 <ZFEiOdK0/UxKiPQQ@corigine.com>
 <ZFGdob9PRHSR-6ff@codewreck.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZFGdob9PRHSR-6ff@codewreck.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+mZUB9CcoB8ZaoyVB4PtMPNpu2lJZ0695WnczzDjGAE6RA9qIRTD8jFcm+NS?=
 =?us-ascii?Q?Gr2w9pMcZnAfb9xiXP+aGFFDjtvOJBh2kZq0vjV0iYbR9wdlJfMfkw3Js6dT?=
 =?us-ascii?Q?3yGFuYj9Wjj4mRRUnK1pcNyI0RJZB5ZFUyDsXU4MneUAC0yjfJifdT5xQqNn?=
 =?us-ascii?Q?FBWLeuK5m+tfBNfd9e5lr/pJvzn8biAn8PooU8d8Hp+N8RfymKadDJjpHQLl?=
 =?us-ascii?Q?S4Y/DxPQSOIFifi7IFr7jU7vGsFT/qQNiqCmSFuVW+6gECIwOrsrx00zOYrf?=
 =?us-ascii?Q?ZSukoU1LWUSn504wI8Lfq3AaqIVnMp5lgaSLKIYB7bQrLcCw+acYawC2RmnM?=
 =?us-ascii?Q?hdpWRXKIPJYtG7fBtbjHDaoY5fF6pOtPX9FppVCe0DQ4J8FLWQhiDOrm2Fi0?=
 =?us-ascii?Q?ILvrxEPTrj6ov5wBhDQayLBaj6FFlZKkiACNnajsXf23/+uOPkhc6JnntT8l?=
 =?us-ascii?Q?pfndtFq7Tae+PY1mneVYjq+a/HYtlcVTQOnexzavXxvw0pgAA/mX7ZGYfEow?=
 =?us-ascii?Q?DTEvSQh7d6sl8aMbTYDdrSvxGuB/71yZ05MlRygpBojTioXNIlWEktgtn3Ge?=
 =?us-ascii?Q?sNeXpw3rvY3yj/XX5oCra0+u53UDfPG7u/+U8GAHewhvYnCBNpSKaBZVDnDJ?=
 =?us-ascii?Q?a8HTYODYS0w7ueNeC4PB3K+nGku2SbxGsfBdEmDGqUdlTXRedsu1HPjA/djW?=
 =?us-ascii?Q?5eHx7kE6sjDmjCSUOBIjqNYQpvzUKcNhIj5zxDEclHqllnicyWmHbuQzm9Ed?=
 =?us-ascii?Q?7ELAOBKEoPu9hIU/BShfB2tP/L+P20qpsyzKHavmdVkk+ZmxTiPNdnLIgFV8?=
 =?us-ascii?Q?MHBW3u5mnZpDSfFaOucV2K0vOON7D+sydtl+aA4+tGh/Zc04shNfmvODMba/?=
 =?us-ascii?Q?1cObK3yMj3QKdMQPv5U/pgxvZw5PHbpWG1qIMQ7Q3uhrZ4oXYu5PxN57Tzt8?=
 =?us-ascii?Q?auYpF+rPKd3WXAVXwtA1D0Dpug2GH84LH1C543i/YGLtqLPz3RWFH+VWX/p9?=
 =?us-ascii?Q?yQkvjYhx8M7VYe1AMTNNlmk48eOJeJRQlhkTEouqfsrkpOaEr1Ikibgn7bB2?=
 =?us-ascii?Q?nW8KUIDCKhJGjpoUqJI3i7PRGeFsTUwwbwNL4R1qDpNzUDUlnhW40DV8hDti?=
 =?us-ascii?Q?bimBTwvOt14vnpP4ocIKIgWooIYNAkRlgFMwpwxhsQWiELQb4a2eJY+fkUEN?=
 =?us-ascii?Q?Hxzwfdj6hSRHOTo8G07mtgPoSQXTUx4yZmFqAcLC+a0HNpoHxhU/maARsNKy?=
 =?us-ascii?Q?syQlSjHh1cGYajM/S36dv/41hb3cGCXRGmo476S3XegyT+guburOzvOpEUwy?=
 =?us-ascii?Q?734Sb/WzjUdG15SkPeY+LMiLbMq6M9KJas75xCBSYBM0epjL65bfQhHDcEya?=
 =?us-ascii?Q?jTqws/uVCmak6Dwv0vJBUQxxjPU9EBKgDvFcVMYA7B5lBzIevTVrfvKysu26?=
 =?us-ascii?Q?b3KT/K0q4P8aC30WQUu92o+npBYHIlZR7Q7TD3v7II+IZ8MDF1NQb1YTq3Zf?=
 =?us-ascii?Q?BnWkFhGiSjz4T/ld//NH93KGQsqJ//iF+1G8/NpaOdCE/HCk59K3urg4F4Iv?=
 =?us-ascii?Q?SnZgdTvoU+JKJVcP0eKoQ8Is4GrvlnJ1mP+5K/laSGLRgZsmn0FJb0cR9iKm?=
 =?us-ascii?Q?z+KFrVETTls495Zc2eiTRQKLnF7A7Ez3TFbtJcv25bRn7ZvCbDguorUQd+2D?=
 =?us-ascii?Q?Owaezw=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6d3ff749-f42b-4a6d-3c46-08db4ba677b3
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2023 07:17:34.9285
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tbQhf+bE+0pFuZZ4jx7DTygxt7G1dK69JiqkLvoCTbVtVp0G+/Bh7aqvm3AHSK79xRl2LesD2BnwsHPL30l5OaK0k3rcLCtSn6Y03RIvRJw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR13MB5972
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, May 03, 2023 at 08:32:49AM +0900, Dominique Martinet wrote:
> Thanks for all the reviews!
> 
> Simon Horman wrote on Tue, May 02, 2023 at 04:46:17PM +0200:
> > On Thu, Apr 27, 2023 at 08:23:34PM +0900, Dominique Martinet wrote:
> > > retval from filemap_fdatawrite was immediately overwritten by the
> > > following p9_fid_put: preserve any error in fdatawrite if there
> > > was any first.
> > > 
> > > This fixes the following scan-build warning:
> > > fs/9p/vfs_dir.c:220:4: warning: Value stored to 'retval' is never read [deadcode.DeadStores]
> > >                         retval = filemap_fdatawrite(inode->i_mapping);
> > >                         ^        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > 
> > Perhaps:
> > 
> > Fixes: 89c58cb395ec ("fs/9p: fix error reporting in v9fs_dir_release")
> 
> Right, this one warrants a fix tag as it's the only real bug in this
> series.

Hi Dominique,

Yes, I agree that this seems to be the only patch in this series
that warrants a fixes tag.