Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <77ebe99f-9034-990e-533e-544d75e564b2@amd.com>
Date:   Wed, 3 May 2023 14:02:52 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
From:   Ravi Bangoria <ravi.bangoria@amd.com>
Subject: Re: [PATCH v3 1/3] perf/core: Rework forwarding of {task|cpu}-clock
 events
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     namhyung@kernel.org, eranian@google.com, acme@kernel.org,
        mark.rutland@arm.com, jolsa@kernel.org, irogers@google.com,
        bp@alien8.de, kan.liang@linux.intel.com, adrian.hunter@intel.com,
        maddy@linux.ibm.com, x86@kernel.org,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
        sandipan.das@amd.com, ananth.narayan@amd.com,
        santosh.shukla@amd.com, Ravi Bangoria <ravi.bangoria@amd.com>
References: <20230425142205.762-1-ravi.bangoria@amd.com>
 <20230425142205.762-2-ravi.bangoria@amd.com>
 <20230502153422.GE1597538@hirez.programming.kicks-ass.net>
Content-Language: en-US
In-Reply-To: <20230502153422.GE1597538@hirez.programming.kicks-ass.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UUFwZVl0R2NwZTVsaXI2OTNtUVhJbDY1S3Y4NEd1VmNZNFo2SmxFL216UlBQ?=
 =?utf-8?B?VTg2cmlIS2FQRERyTUFjZ3JLWXpGdW54elFDTnNxbFhwTUhKQU1KZzVDUVJt?=
 =?utf-8?B?VzQ2V1JOUnBoUWo2NTVtM0svSHJEeFQ2UkR2QUo5NE1ubjMvWHlEQUN0ZWov?=
 =?utf-8?B?TXYyTGhzS0YzUFMvNko4WjdWemowbGtRcjEyUlVoOVNQSGd6cVpCT1BJK3FD?=
 =?utf-8?B?R3J1cEhOR242QUZNUzdwUlJDazNUOGRmSkhmdU9TYWNvellFTTdCN2Z4Ym1m?=
 =?utf-8?B?TFE4a3c0Um9GT2NFL0hFbDhvVlMvUHB4eEtjcmdDNWc5dHExVUNCZ0RKN2Vw?=
 =?utf-8?B?RUV6eEUyR2duTExGdnNiSjFVdVVqRzZGZEZXRjZvZU50Qk9rZFhyVVhNY1Nu?=
 =?utf-8?B?WStDTVFRS29ScUdJQUFFblBnZGFtWTRqRW1EUjZPM3NlalRWbHZTVEUyY1J3?=
 =?utf-8?B?S0Uxa25td21penN4T1lYUW5oQ3l0L3YxSjFjY0tDa0UrVzV4OERVM2xzckpZ?=
 =?utf-8?B?UDkrZ0ZSc1JzQko3cTFLb0dBQmxWMHVjdkxmTXBwZ3lIc0hNWVVSTy9vaW1N?=
 =?utf-8?B?K29Xc0llUVExN3RDOHpCQzRWNHk0UDZtbGxEd1gvRWc1UW40cU9lc3lDeHI4?=
 =?utf-8?B?UU9zeDBmNm9lY29nY2ZVL3ZvODBtRzUzN3BTYlQ0YlI3UHpwbHFMb1UycU9V?=
 =?utf-8?B?NnNtMng1NExzVExJYTJrT3M0L2pjQXloYkc5YXZ5d2hEZGszR3FlT09HalZW?=
 =?utf-8?B?QjlRaGxPb3hsdUdUZDg3MCtDcnNqZnVFOHVhcUNYOHZMWDBLYURPTDNKTCtP?=
 =?utf-8?B?NjZMU2xjUTBRVmxaanpUU3dKeTBodzg3cWpETHJWcWk4TDdma3FWajB1U1R5?=
 =?utf-8?B?NHZpUDNQb2g3dXdYVUViZnFsb1phTkhZYlN1Z2RmQ3lyZG0vWTNIUWRHdUgv?=
 =?utf-8?B?bmlOQ1JlME1yVVppbzRxQU1CTlJhbDBLOGFIWHFsOVUvVWZvMCthTlNlVUdk?=
 =?utf-8?B?MTJCVzVqWkxDRHY0OWtRRVluNTZqdDNZRGs0RDJpOTNoeWpzU0tySmU5MytI?=
 =?utf-8?B?YU0xRUluOVFFUHBGYXFlbHh0SkZvQnphYjJVakN2eGZKQTlqdG81NlBaV0Js?=
 =?utf-8?B?ZnMvaE1jZytNNFRrall0Q3FuM2VXVFJvK2Rna1pnd0N1R05ISkZ2SkV6RVF1?=
 =?utf-8?B?cXlzejBSNzcxeWZ6S3BVdExTS2QvSExYR0RJTkcxSGZCY2tzeG9tSkhVZFJx?=
 =?utf-8?B?V2VFdzNtcmE4S2hjMHZXbGwyamI2L2RYZjVwUHRkMnpYWE02a3hpeDNtS1dK?=
 =?utf-8?B?emhjditERzRmSFRNKy95eW10cHVINXZhV09TamhzbmwwVFZVb0kwVVllVGxD?=
 =?utf-8?B?bUZ1U0xJMTkwWERoZklEWTQ1UTV4Rno2YVNuOUtNU0sxTEN0MlhRWXRuU1VU?=
 =?utf-8?B?UGdQZ3VaTXFPUXo0cTQ1VnhQcUN4ZFA2Q0tlbmpiTE9kNFNDTWRyZ08rY2Zt?=
 =?utf-8?B?R2dwdG5xZHB4dWFWdHJEcmxGSE9jRDZKTjZ2aml3b0FyS0tITXd5NU5SamJU?=
 =?utf-8?B?b2VCODZiOGNWa3RHZHpvOSt3MjJRb3YwbU5KRWExTHgxcmVwR0pjYzkyVnlL?=
 =?utf-8?B?bkhDTU5GUkQzcjZzRWt5M280aXhoellydllUYUVLYTFiODVobWpLR1pCcS85?=
 =?utf-8?B?Wk5kMGFyNDIwczk5SGlKeFhBSE1CcUVIeU9rTlNxSXlCUVZLZUVYcXgzOERB?=
 =?utf-8?B?aFhTc0JLZk1yYUo0Si9ibnVqbnlWNCtPNW1KYzdJdHJVd21scklKVWxiSXdI?=
 =?utf-8?B?NEROMUNoZlVSV1lFOEU5WHgwT0VNU1hjdDhML1h5YnRrN0xjekd3VXdHYmtD?=
 =?utf-8?B?bVZNR0k0bS9TK3lLNWF5QXl0REVFTlNXdk9UbVoxMnFSOVJVbm9INlpRQjJx?=
 =?utf-8?B?b2hWbU5JNHhmYW5ZRklLZUV0OFc3Um9HMzZLbm5TQUE5VHArdGg0YXRDZjUr?=
 =?utf-8?B?eUdHY0JzNFVXWDhldEEvRWlRODMwWGZBTThqRWtIRVg5eHNUWSszeFZnR2U4?=
 =?utf-8?B?Y3hxbHFrdk0vQ3hHYkwxelFvblM0bUNESC82YkpwQVcxYzhjUE9OVE5EdnR5?=
 =?utf-8?Q?gqcjIr5KGPRIcApJyMrhB6Y7Y?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ccc512e5-1bca-4cf0-858d-08db4bb1149a
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB6588.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2023 08:33:33.3402
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HvLag7e4E/mDJW7Ts5oqedWCDtVE/FPyjQ9NQfsUNBomztP7B0kjaBQuNvigaIwZdhYTP+NEFetvvCANCkWNgw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4308
X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> @@ -322,6 +322,9 @@ struct pmu {
>>  	/* number of address filters this PMU can do */
>>  	unsigned int			nr_addr_filters;
>>  
>> +	/* Skip creating pmu device and sysfs interface. */
>> +	bool				skip_sysfs_dev;
>> +
>>  	/*
>>  	 * Fully disable/enable this PMU, can be used to protect from the PMI
>>  	 * as well as for lazy/batch writing of the MSRs.
> 
> Does this make sense?

Yes! Will respin with this included.

Thanks,
Ravi