Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Pucha, HimasekharX Reddy" <himasekharx.reddy.pucha@intel.com>
To:     "Rix, Tom" <trix@redhat.com>,
        "Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [Intel-wired-lan] [PATCH] igb: Define igb_pm_ops conditionally on
 CONFIG_PM
Thread-Topic: [Intel-wired-lan] [PATCH] igb: Define igb_pm_ops conditionally
 on CONFIG_PM
Thread-Index: AQHZehEN7celIw7m6UydX9TN+8wQDK9IRUCg
Date:   Wed, 3 May 2023 08:57:05 +0000
Message-ID: <BL0PR11MB3122EBD87EC2CC05F6DB2645BD6C9@BL0PR11MB3122.namprd11.prod.outlook.com>
References: <20230428200009.2224348-1-trix@redhat.com>
In-Reply-To: <20230428200009.2224348-1-trix@redhat.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?zMR2+IzDPl+pLDCD78MlzQBRGmLKJMZJ3IsPYLrjqrQTnFq6iTnN5ZJxUtyY?=
 =?us-ascii?Q?SWyvYAyBERwV/3OfPFvmKX92BTM0L0CvIPWgHKvEA4x/oBl3w04VHJwwyFZq?=
 =?us-ascii?Q?DQupOEScyC37AkEHUC3YNjp2HAk4V1VvOfv9PTI+c+zYztaNZMBJp5g+14p7?=
 =?us-ascii?Q?tZUPgCbpkYu9YP8v9MEw44G/zRkTsRyysxp3eoqY2WV4eFU2H/qFMblp37G1?=
 =?us-ascii?Q?IUkv9O2JDNkwKy2LvyzkZD+FrwzkOoEPxQ+8E4sBTHMqzWXHBtrzEKC2TqZ4?=
 =?us-ascii?Q?ptKyWEzu8y7UF9dW7K4bK13h5IokuBGH/809BUQPeZQCbO0myK+nyqQrXv7P?=
 =?us-ascii?Q?DQD4biO+SdLvIQDKHHBHtnWV/fJWhiek1V7m5oP/q39YmM7+7L0+cZ9Cx08e?=
 =?us-ascii?Q?pnT0dnTu0tManj9hPumXygA0aoupmGQzN7HigMVR/WfqILzjtdjk1hay2w4r?=
 =?us-ascii?Q?qT22g2qkk1KJ+HxnBY9ZyeObzNmtjsCzenkIKho4HViHp2pf71aJeNCU/O/i?=
 =?us-ascii?Q?yAt6ZzPcGTg+NOvOYQX8b8YyYvtQ1nzFrCr3dkFNaW0lcws9PD52miKqLY4j?=
 =?us-ascii?Q?R7+QTTbb0CcjRZOSZD8MVTVPLzZSHj6dIbeDzvUY5SqXFRRHg77u7g58LmLP?=
 =?us-ascii?Q?j3o3SHXr8YVsopHb9sZvtUbloJz6JGy0t2S39LeXpNbKhJmS6FtaBT8iWxjM?=
 =?us-ascii?Q?fmTnDaBf0ytaXOf7LAyHRnatyVfdYXxIHw/RMtX84eZ1KBP4hTYLMhaTXSL1?=
 =?us-ascii?Q?uTJmcqyshkXmLFVc0xi1btSF/1FmADbOY0K5BmO743msDKkXES/3D280t7vU?=
 =?us-ascii?Q?Ix1WwziWu+Dl7s+GGIeI5chRH9XHics+paDEk44f386AU0mjLquOA0UXXUgP?=
 =?us-ascii?Q?X9R0nmjsU+tlbqvM7GGruZFJ1RDohg5iOgfIRAcGdHr746L1ZZkRytAwmLpn?=
 =?us-ascii?Q?wx9p6mLghcxkaiE5qKCBSdxsT7Cdj47efcKFHvRGPV4hwud9Y2VYGXuq/2ae?=
 =?us-ascii?Q?awsvwAk9mqRnhFbZIurQzZ9QRcV+nnongxfdlMLAABbci4t+Jf9DM5+PykNR?=
 =?us-ascii?Q?zPRFrUhQNdrHzV8zecyD19YdYjQAtxpvQvKmYGjy9jWvGZrC1g35M/cSNY6w?=
 =?us-ascii?Q?yxaWF836AsAfxm/HI/odwyGn/C41JTVp+RHCGEO4qPugoeS8xd1f86aKnOV7?=
 =?us-ascii?Q?iJOiAVEKhsh0HhtEz+q1ri4klOJEfkSTU3dvb9siTTWsnPLMugoo1+MJR7F2?=
 =?us-ascii?Q?3C9thdTfawOWDQT298TIk1oFM87NpMO3WPT5TjEu+D62jNRgtHxnJs3M2Qpc?=
 =?us-ascii?Q?Q8SWQOxB1JJcKoogigxw4zY6bmADLb5ZkOrt0YeYaDSv7GWFujGOuergo/Rs?=
 =?us-ascii?Q?4prcKtYET/+ZP7V7yMytoH6Yh9aURBgmqkm5cZ1ZDGY2msNTEofkCkf058Ca?=
 =?us-ascii?Q?wg9+1K7vidclsH4Aco6gJD3C9INNc8NNUN3jAOAsYkHUrgv7MIO/2p+PYhS5?=
 =?us-ascii?Q?C9fYlR4MKz6NQgPWULu6S0hL+kmFFGrq03XXCkYD6D0jLqEPEmHBFBAnv2qc?=
 =?us-ascii?Q?f2Pvib0O1X5t7dDhRkEyX4z2F2K2Fh3Vwxg7DpusT+tdrlYLRRqGimYBW6I8?=
 =?us-ascii?Q?aw=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BL0PR11MB3122.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a24d188e-e699-471d-85f1-08db4bb45e84
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 May 2023 08:57:05.4388
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: FxhfgrtC69lWmdszCo3DxiZLXrcZaJO3g8lZNH7JJVdo/Jcf3Hb8o/dEzZA3+RN94zRmexjgj245xqIOr7YPMnTJD8hWNBY7lsxg5masha3b/cY6bc+DK3CEJbq9jK8c
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7898
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of R=
ix, Tom
> Sent: Saturday, April 29, 2023 1:30 AM
> To: Brandeburg, Jesse <jesse.brandeburg@intel.com>; Nguyen, Anthony L <an=
thony.l.nguyen@intel.com>; davem@davemloft.net; edumazet@google.com; kuba@k=
ernel.org; pabeni@redhat.com
> Cc: netdev@vger.kernel.org; intel-wired-lan@lists.osuosl.org; linux-kerne=
l@vger.kernel.org; Rix, Tom <trix@redhat.com>
> Subject: [Intel-wired-lan] [PATCH] igb: Define igb_pm_ops conditionally o=
n CONFIG_PM
>=20
> For s390, gcc with W=3D1 reports
> drivers/net/ethernet/intel/igb/igb_main.c:186:32: error:
>  'igb_pm_ops' defined but not used [-Werror=3Dunused-const-variable=3D]
>  186 | static const struct dev_pm_ops igb_pm_ops =3D {
>          |                                ^~~~~~~~~~
>
> The only use of igb_pm_ops is conditional on CONFIG_PM.
> The definition of igb_pm_ops should also be conditional on CONFIG_PM
>=20
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> drivers/net/ethernet/intel/igb/igb_main.c | 2 ++
> 1 file changed, 2 insertions(+)
>

Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com> (A Co=
ntingent worker at Intel)