Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Florian Weimer <fweimer@redhat.com>
To:     Arnaldo Carvalho de Melo <acme@kernel.org>
Cc:     Ian Rogers <irogers@google.com>, linux-perf-users@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Adrian Hunter <adrian.hunter@intel.com>,
        "Justin M. Forbes" <jforbes@fedoraproject.org>
Subject: Re: [PATCH v2] perf: Avoid implicit function declarations in
 lexer/parse interface
References: <87sfcn7uot.fsf@oldenburg.str.redhat.com>
        <CAP-5=fXZv+KCdCN05wVUcAwDCZAgXjWunoaviGBQEiUPqNwOmg@mail.gmail.com>
        <ZEx0IQAtBatrRDCR@kernel.org> <ZEx0xAamEl66qk2w@kernel.org>
Date:   Wed, 03 May 2023 11:36:03 +0200
In-Reply-To: <ZEx0xAamEl66qk2w@kernel.org> (Arnaldo Carvalho de Melo's message
        of "Fri, 28 Apr 2023 22:37:08 -0300")
Message-ID: <874jot69ks.fsf@oldenburg.str.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

* Arnaldo Carvalho de Melo:

>> Thanks, applied. BTW b4 coulnd't find this message (nor the original):

Yes, vger drops the message after accepting it for some reason, probably
something in the patch contents.  I tried to resubmit from a completely
separate account, no luck.

> Not so fast, removed it for now:
>
>   CC      /tmp/build/perf-tools-next/util/parse-events-bison.o
> In file included from util/pmu.y:14:
> /tmp/build/perf-tools-next/util/pmu-flex.h:496:1: error: unknown type nam=
e =E2=80=98YYSTYPE=E2=80=99
>   496 |
>       | ^
> /tmp/build/perf-tools-next/util/pmu-flex.h:498:19: error: unknown type na=
me =E2=80=98YYSTYPE=E2=80=99
>   498 |
>       |                   ^
> /tmp/build/perf-tools-next/util/pmu-flex.h:546:17: error: unknown type na=
me =E2=80=98YYSTYPE=E2=80=99
>   546 | extern int yylex \
>       |                 ^~
> util/pmu-bison.c: In function =E2=80=98perf_pmu_parse=E2=80=99:
> /tmp/build/perf-tools-next/util/pmu-bison.c:69:25: error: implicit declar=
ation of function =E2=80=98perf_pmu_lex=E2=80=99; did you mean =E2=80=98per=
f_pmu_free=E2=80=99? [-Werror=3Dimplicit-function-declaration]
>    69 | #define yylex           perf_pmu_lex
>       |                         ^~~~~~~~~~~~
> util/pmu-bison.c:1007:16: note: in expansion of macro =E2=80=98yylex=E2=
=80=99

This appears to be related to some BPF filter stuff that is only in
perf-next, not mainline.

Is this the right tree on which to base the patch?

  <https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git/>

Branch perf-tools-next?

Thanks,
Florian