Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 3 May 2023 18:15:39 +0800
From:   Herbert Xu <herbert@gondor.apana.org.au>
To:     Cai Huoqing <cai.huoqing@linux.dev>
Cc:     Thomas Graf <tgraf@suug.ch>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rhashtable-test: Make use of rhashtable_walk_peek
Message-ID: <ZFI0S6T101+JPcYT@gondor.apana.org.au>
References: <20230425135617.77907-1-cai.huoqing@linux.dev>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230425135617.77907-1-cai.huoqing@linux.dev>
Precedence: bulk

On Tue, Apr 25, 2023 at 09:56:17PM +0800, Cai Huoqing wrote:
> Add an example usage of rhashtable_walk_peek to test_bucket_stats.
> 
> Signed-off-by: Cai Huoqing <cai.huoqing@linux.dev>
> ---
>  lib/test_rhashtable.c | 8 ++++++++
>  1 file changed, 8 insertions(+)

This is supposed to be testing rhashtable code, it's not meant
to be an example of how to use the API.

> @@ -192,6 +193,13 @@ static void test_bucket_stats(struct rhashtable *ht, unsigned int entries)
>  			break;
>  		}
>  
> +		/* Here's an example usage of rhashtable_walk_peek */
> +		obj = rhashtable_walk_peek(&hti);
> +		if (!obj) {
> +			pr_warn("Test failed: rhashtable_walk_peek() error\n");
> +			break;
> +		}
> +

What is this meant to test?

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt