Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230426224748.34056-1-materoy@proton.me> <dIXozfBEyCqYQ9-l0IgxfaoL6paYc_6NjXMxHp3qUqAxQdF-c5qRoULMp4K_Lv4bCOPRez2c_4v4PuFKMysFxhNkK2r1t0grU89YosKzTbE=@proton.me>
In-Reply-To: <dIXozfBEyCqYQ9-l0IgxfaoL6paYc_6NjXMxHp3qUqAxQdF-c5qRoULMp4K_Lv4bCOPRez2c_4v4PuFKMysFxhNkK2r1t0grU89YosKzTbE=@proton.me>
From:   Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Date:   Wed, 3 May 2023 13:08:12 +0200
Message-ID: <CANiq72k5LyriTgTnYwVVzJLROoq-VEZra=WbwKBGh-O6a+guqQ@mail.gmail.com>
Subject: Re: [PATCH] rust: bindings: fix sorting of rust/bindings/bindings_helper.h's
 #includes
To:     Benno Lossin <benno.lossin@proton.me>
Cc:     materoy@proton.me, Miguel Ojeda <ojeda@kernel.org>,
        Alex Gaynor <alex.gaynor@gmail.com>,
        Wedson Almeida Filho <wedsonaf@gmail.com>,
        Boqun Feng <boqun.feng@gmail.com>, Gary Guo <gary@garyguo.net>,
        =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= <bjorn3_gh@protonmail.com>,
        Alice Ryhl <aliceryhl@google.com>,
        Martin Rodriguez Reboredo <yakoyoku@gmail.com>,
        rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, May 3, 2023 at 12:45=E2=80=AFPM Benno Lossin <benno.lossin@proton.m=
e> wrote:
>
> A couple of nits for the commit message (these can be
> applied by Miguel when picking the patch, if he agrees):

Given this is one of the "get yourself familiarized with the kernel's
development process" issues that I create from time to time, it is a
good opportunity for Roy to fix those and send a v2.

Roy, could you please do that? Please pass `-v2` to `git format-patch`
when you do so, then also collect the two `Reviewed-by`s you got and
put them above your `Signed-off-by`.

> - capitalize 'Rust',
> - add a `.` at the end,
> - remove the newline between the tags.

Also: typo "idoms" -> "idioms", and the title could be improved to:

    rust: bindings: sort `#include`s of `bindings_helper.h`

since "rust/bindings" is already given by the prefixes etc.

However, what does it mean "...and rust idoms"? This is C code, not
Rust code, and thus it should follow kernel C idioms (which, in some
cases, do sort the `#include`s too, so that is fine).

Perhaps remove that bit, or say instead "Rust subsystem idioms"
instead (since we do want to keep them sorted :)

Thanks!

Cheers,
Miguel