Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Niklas Cassel <Niklas.Cassel@wdc.com>
To:     Andreas Hindborg <nmi@metaspace.dk>
CC:     Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
        Keith Busch <kbusch@kernel.org>,
        Damien Le Moal <Damien.LeMoal@wdc.com>,
        Hannes Reinecke <hare@suse.de>,
        "lsf-pc@lists.linux-foundation.org" 
        <lsf-pc@lists.linux-foundation.org>,
        "rust-for-linux@vger.kernel.org" <rust-for-linux@vger.kernel.org>,
        "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        Andreas Hindborg <a.hindborg@samsung.com>,
        Matthew Wilcox <willy@infradead.org>,
        Miguel Ojeda <ojeda@kernel.org>,
        Alex Gaynor <alex.gaynor@gmail.com>,
        Wedson Almeida Filho <wedsonaf@gmail.com>,
        Boqun Feng <boqun.feng@gmail.com>, Gary Guo <gary@garyguo.net>,
        =?iso-8859-1?Q?Bj=F6rn_Roy_Baron?= <bjorn3_gh@protonmail.com>,
        Benno Lossin <benno.lossin@proton.me>,
        open list <linux-kernel@vger.kernel.org>,
        "gost.dev@samsung.com" <gost.dev@samsung.com>
Subject: Re: [RFC PATCH 00/11] Rust null block driver
Thread-Topic: [RFC PATCH 00/11] Rust null block driver
Thread-Index: AQHZfbL6Xhz5/nlop0GOn95gYQsxBg==
Date:   Wed, 3 May 2023 11:32:44 +0000
Message-ID: <ZFJGWwlRbSS3zFnc@x1-carbon>
References: <20230503090708.2524310-1-nmi@metaspace.dk>
In-Reply-To: <20230503090708.2524310-1-nmi@metaspace.dk>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?gTbDkUWlBUeDmf9VchwbPmNwqkOHVet+pam0gX8xKdy3pJ2DYVcnxaVCwQ?=
 =?iso-8859-1?Q?y7z6+sgqF23E5sdETYTvTOHKoyAnvPiew1TYFlcDctNYvAxzg+ecFVB/p6?=
 =?iso-8859-1?Q?dbXQ/W6ZqV9ryFH0I9xN3VGDTbwExLDFzHshLsjLlgaT6eMZ+hz8KGohj5?=
 =?iso-8859-1?Q?2v3fzTa3jNbB2MYlv40m6BN2uSURw7uIhjUPubnRrBE+3MN/sRNbMuxnEE?=
 =?iso-8859-1?Q?xRFfwTzgbdgNgTQDToM9gIj3/ROGTtU0iL086TAYVg1KESZm5hC91HwAk8?=
 =?iso-8859-1?Q?8u3WMoDFPtXhq9TJFjA1YTzJp7fa0OrXurNsbGngh0ZxIO0dhHwYn+kc0p?=
 =?iso-8859-1?Q?9F2FPrXestvC3KaCgfUzqE3uPqnyLG2XdVErtWStCDJGPOumPXxtsbU4g7?=
 =?iso-8859-1?Q?PkBX3BcdylpIwidGucGpmuw36FwgTpP9vnwuGv2APiGNHT/2iKppKfE3o1?=
 =?iso-8859-1?Q?naaY72fv/cSHtRAYYCdjwj11y/ducz2APrkCDERoJaYOuIOElVMUe5Pz+t?=
 =?iso-8859-1?Q?eLStWfUrwCA2nxb+Hu49hnL/c06nBTHAAb3zUWQP3Qr4JgCILfd4VHEnJ5?=
 =?iso-8859-1?Q?EJ67OddzTjq/INKBT3RDAiBtKzzBrPmCnBoWY70kFHUQQkuS4RlCSsXiKu?=
 =?iso-8859-1?Q?M0YlCjkX42ca9JLPN8XDD5dN/ePgwlZaopToU2Q8X+YShLVean34wo6PvB?=
 =?iso-8859-1?Q?7kcdpjlCH4WyKVGk8a/V7CKm4u8trrfr+6yvrcUqjH8cr3Y7S2XlwBzYr2?=
 =?iso-8859-1?Q?CDFOLkDSuvQHNrpyVBS/EK/ZMGf0ltLGFkMnkzWvTi8bNJ+C+xqrK8+zjr?=
 =?iso-8859-1?Q?hYDHKPHH2FKHv4U7pS/67jQhizSj3sMRam3pvq9oWJWz1WkxU9SSkIIbmR?=
 =?iso-8859-1?Q?bI2In6hN+Dk+hMw/amQHxeP1s0Ugf3Y4+oeExmRuGSuXd+uuMNfjVWLsCo?=
 =?iso-8859-1?Q?LPtI94l/6HMCgrkmnpIY8vCV7DK1AZfgz+YBK801JvLDxOq95GJ3hJTjDn?=
 =?iso-8859-1?Q?jnezxX+jqmF/SIXowLA8cFyicYKinA+6naHLd/daikghczsdgsymoyLF7O?=
 =?iso-8859-1?Q?N305VcNNnfgyRu3w9QBmFngOojb8PIeF434yd1r78ST7PYxsw9stiVejMV?=
 =?iso-8859-1?Q?C66JP76HYcR+UgwXvz8DDpOmHVKbbJdNCBZZqGAKbRAXGp8JfZH8mcT8d8?=
 =?iso-8859-1?Q?JmDZRdrLl5J+bKnPnK7t9IZPEIVtqlRAxelhmfGx8zYWBSxVo0CL8m9dFr?=
 =?iso-8859-1?Q?r3oeXNasXMelTbdK4ZgKUFD816WZI7MqfuTJ/L95WrufXITgg7TtxYuupV?=
 =?iso-8859-1?Q?Yf0gk+qZFbVQVHuPT3aQx1+OTMDNtx1vEQN6NBe2TGIK1QFq3Z6h7qD12f?=
 =?iso-8859-1?Q?vSgEKkTZNWrY5v22rEz+/H9e4vv+vJRCyvBI0TxLAX42OUkhjwuY41qVpU?=
 =?iso-8859-1?Q?Nn3yPI5uWYLlND1AzipFrnQg9pyXn2bjC00GTZNMNS9Vb3iB2GgWJeq8Db?=
 =?iso-8859-1?Q?/i3tnmXxkW7Yd8vb6B60oEIw6EX1U+h79rDPUnHv1ufjnK1ttK/XYg9gVk?=
 =?iso-8859-1?Q?war3PkbPSgpkx0YCgQvcIWG2mMWb2JsHyNCcG+ZhkiHegu78U+EWTveH3I?=
 =?iso-8859-1?Q?5e4OYxA9ZRFEnq+6dWfjUSwr3hCc8JPDyoROJC5Mch8VGozY3e4PoBrA?=
 =?iso-8859-1?Q?=3D=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <8F324F0731079E4CB5C4F759138173B2@namprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?iso-8859-1?Q?kPkuPU17y06GjJ8HthIFj3LPHw/H1145IfXtcHk+P5vd+EdfaP3huMt51h?=
 =?iso-8859-1?Q?dYICBy2qaZg9DzdS4A3qPRaD84H33yGlMIDPuLfg2LigGmshBUEhjejoBc?=
 =?iso-8859-1?Q?l9aQELkVorGNphl4iq1tsxii36nfhpf+X7iDzYMDqXcO6R4NNQ4LkofNPZ?=
 =?iso-8859-1?Q?8H8ddbPH2RCrwbItCzzymL6DXZfFaAvw210M3mbEDoNAgbvOxr8F4LZsHk?=
 =?iso-8859-1?Q?4yNGqR2ZEfuZsm9RK8QkiXijf143r9AL6Fbp5TFSEt0H3kK6G9bGorQ+xo?=
 =?iso-8859-1?Q?8IESJXONmr0JczBPeZYduB//4zRlgbC32MtV9murnff5avLcUD6o5/Z7G9?=
 =?iso-8859-1?Q?++S5iFksWNYwwPduBrkQS9hG/kyMQIuXRxAiCl5yGgs0KsHlhB83vWTukP?=
 =?iso-8859-1?Q?61EGdaa2krZ0pSfB/oNkRoAoEwewblNM0N6C0RTBgidcJ8M3Z6jIm5wRlW?=
 =?iso-8859-1?Q?chKaFbNNCd9S39D99EkCWfEKg8Akj9wSn8AEX2Bri8t0WDIaOQu5qgtq5g?=
 =?iso-8859-1?Q?dw7b77mfFOyfrijfAGtxJsFuhH/zfLFnqsn/WyzA0yE42tm/HJ/ARLFHJo?=
 =?iso-8859-1?Q?NOCKMixC9hQ4AY/uWwlvVImxNQm9sW/Zi/RsTtRntMY5j2EsA8q0VHhpjT?=
 =?iso-8859-1?Q?y7wAKqHgoGT5PpGVcIc0rrS/Ww+QfyVnPiIheK9ni9Tt0VTh0YBsnaXhd/?=
 =?iso-8859-1?Q?2cnrS8zRtX2Nn5SZdmkxdV/WmWEcNO4ox1lhqw8bOrLtNAqCkieWfs1INF?=
 =?iso-8859-1?Q?y684vkYlhkw6mzCiShAO6aQ00LQasVQWOla/QILat+44y9g1mhHwnOZ17Q?=
 =?iso-8859-1?Q?hEdmZL1sxKcvKFfSjjREP2XWRk4wdzpaSj8wKIv+BDEOhjNhHk1LtwsMwc?=
 =?iso-8859-1?Q?ITBKpVmYtO51cxySxcwdwiH4CSazoOphx+YThvhuk1e0KH5OQs+dM87PbV?=
 =?iso-8859-1?Q?42zHRFqIAzlpRVGEWmBwi0pcavzMftlWHWbpzgWsScbH0cjAqHKQIoV7Ro?=
 =?iso-8859-1?Q?uVGAj0iMxFwe2rMJcp20HOA+vH0uZUKQ6AFJRd1akty7HyZFhwSGGIhvN/?=
 =?iso-8859-1?Q?+VmZbT+ToL8wAbRuG1dubEDa9GJ3Jy0869lGqinFMyz5GU6waZoG1zSdFN?=
 =?iso-8859-1?Q?O4gSHF8uRppWIvDkO6YWy74IdHq5o31MJUoIlGVygKkKed1e86FOK7FQA1?=
 =?iso-8859-1?Q?T99qXW6JLSDI2+5hDFWNWWyCbCN/GcOQPo8=3D?=
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MN2PR04MB6272.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0866aa84-fea2-4dbc-9de8-08db4bca1d4e
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 May 2023 11:32:44.9935
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: U3IBgO1AhwQVgdpKFkWm9QuLNoqk3H5bM8wBVTwYuKsMWrhqT1OUUW6ASYA/JZWEEDDJsKe0GHRHbjHbw/G4SQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR04MB7635
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, May 03, 2023 at 11:06:57AM +0200, Andreas Hindborg wrote:
> From: Andreas Hindborg <a.hindborg@samsung.com>
>=20

(cut)

>=20
> For each measurement the drivers are loaded, a drive is configured with m=
emory
> backing and a size of 4 GiB. C null_blk is configured to match the implem=
ented
> modes of the Rust driver: `blocksize` is set to 4 KiB, `completion_nsec` =
to 0,
> `irqmode` to 0 (IRQ_NONE), `queue_mode` to 2 (MQ), `hw_queue_depth` to 25=
6 and
> `memory_backed` to 1. For both the drivers, the queue scheduler is set to
> `none`. These measurements are made using 30 second runs of `fio` with th=
e
> `PSYNC` IO engine with workers pinned to separate CPU cores. The measurem=
ents
> are done inside a virtual machine (qemu/kvm) on an Intel Alder Lake works=
tation
> (i5-12600).

Hello Andreas,

I'm curious why you used psync ioengine for the benchmarks.

As psync is a sync ioengine, it means queue depth =3D=3D 1.

Wouldn't it have been more interesting to see an async ioengine,
together with different queue depths?


You might want to explain your table a bit more.
It might be nice to see IOPS and average latencies.

As an example of a table that I find easier to interpret,
see e.g. the table on page 29 in the SPDK performance report:
https://ci.spdk.io/download/performance-reports/SPDK_nvme_bdev_perf_report_=
2301.pdf


Kind regards,
Niklas=