Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 3 May 2023 14:23:37 +0200
From:   Jan Kara <jack@suse.cz>
To:     syzbot <syzbot+48011b86c8ea329af1b9@syzkaller.appspotmail.com>
Cc:     akpm@linux-foundation.org, hch@lst.de, jack@suse.com,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-mm@kvack.org, netdev@vger.kernel.org,
        syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] [mm?] [udf?] KASAN: null-ptr-deref Read in filemap_fault
Message-ID: <20230503122337.fxyfchh4ximvnuwn@quack3>
References: <00000000000090900c05fa656913@google.com>
 <0000000000004a34a305fac69bcb@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <0000000000004a34a305fac69bcb@google.com>
Precedence: bulk

On Wed 03-05-23 02:23:19, syzbot wrote:
> syzbot has bisected this issue to:
> 
> commit 66dabbb65d673aef40dd17bf62c042be8f6d4a4b
> Author: Christoph Hellwig <hch@lst.de>
> Date:   Tue Mar 7 14:34:10 2023 +0000
> 
>     mm: return an ERR_PTR from __filemap_get_folio
> 
> bisection log:  https://syzkaller.appspot.com/x/bisect.txt?x=15220608280000
> start commit:   865fdb08197e Merge tag 'input-for-v6.4-rc0' of git://git.k..
> git tree:       upstream
> final oops:     https://syzkaller.appspot.com/x/report.txt?x=17220608280000
> console output: https://syzkaller.appspot.com/x/log.txt?x=13220608280000
> kernel config:  https://syzkaller.appspot.com/x/.config?x=d1c8518c09009bad
> dashboard link: https://syzkaller.appspot.com/bug?extid=48011b86c8ea329af1b9
> syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=137594c4280000
> C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=10cfd602280000
> 
> Reported-by: syzbot+48011b86c8ea329af1b9@syzkaller.appspotmail.com
> Fixes: 66dabbb65d67 ("mm: return an ERR_PTR from __filemap_get_folio")
> 
> For information about bisection process see: https://goo.gl/tpsmEJ#bisection

Actually looking into commit 66dabbb65d67 it seems it has two problems -
one in filemap_fault() where in:

               if (IS_ERR(folio)) {
                        if (fpin)
                                goto out_retry;

we need to clear folio so that we don't try to folio_put() the error
pointer. And another in afs_dir_get_folio() where the changes effectively
make that function return ERR_PTR instead of NULL as well which will then
confuse afs_edit_dir_add() and other callers (which were not updated).

								Honza
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR