Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Shenwei Wang <shenwei.wang@nxp.com>
To:     Andrew Lunn <andrew@lunn.ch>
CC:     Wei Fang <wei.fang@nxp.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Clark Wang <xiaoning.wang@nxp.com>,
        dl-linux-imx <linux-imx@nxp.com>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Jesper Dangaard Brouer <hawk@kernel.org>,
        John Fastabend <john.fastabend@gmail.com>,
        Alexander Lobakin <alexandr.lobakin@intel.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "imx@lists.linux.dev" <imx@lists.linux.dev>
Subject: RE: [EXT] Re: [PATCH v2 net 2/2] net: fec: restructuring the
 functions to avoid forward declarations
Thread-Topic: [EXT] Re: [PATCH v2 net 2/2] net: fec: restructuring the
 functions to avoid forward declarations
Thread-Index: AQHZfUKo4ZwVUtEG3EOjLFQNjL7Wpa9HnlQAgADiOCA=
Date:   Wed, 3 May 2023 12:53:57 +0000
Message-ID: <PAXPR04MB9185BD38BA486104EE5B7213896C9@PAXPR04MB9185.eurprd04.prod.outlook.com>
References: <20230502220818.691444-1-shenwei.wang@nxp.com>
 <20230502220818.691444-2-shenwei.wang@nxp.com>
 <6dff0a5b-c74b-4516-8461-26fcd5d615f3@lunn.ch>
In-Reply-To: <6dff0a5b-c74b-4516-8461-26fcd5d615f3@lunn.ch>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?jn2VxE1MgBcVsYfoLFXZ489C/gxCdrRgJTmgXJ9r1HMblrU8BTtCaHtOy2XU?=
 =?us-ascii?Q?ziJcuxZzwiqstisYo6UrbzwQRSIAPVZk3SFK8qUqiWVELyjA0+muFk+eY4XG?=
 =?us-ascii?Q?49JmJasyZqaNrZcyz0DEnss8D2La6ymeTPyp/gda5uIzNuMOU2RRHMTuBBDe?=
 =?us-ascii?Q?EhVVqJNsYfBoClaC5EYHqmbaqq1CG+Jwh7b/cTBM0UsTmw6V4b/BWLJLIeZN?=
 =?us-ascii?Q?8EIu5jfwXqazZTSfPKFeEQkrVAvKMreR5aXntfPCM/HkMJGAkiMCV8oQT15p?=
 =?us-ascii?Q?s0OfgGBit3lZRT1q7CcR/zQzpcAjP4C2Nq9sw+NlvsdBhGhNd09pV0hobe8/?=
 =?us-ascii?Q?YU3SOcDuhfg2BEO9WMexTyTk4cxljoEP9pPQL4cN5Bv9CffXWsMq1aHQpAAu?=
 =?us-ascii?Q?Y1DKDVaTq4gxUtazEKqVWtx6WOaAYifwRS3c2nO8ksm4PRg3kMAGCa2x0PyY?=
 =?us-ascii?Q?xNXiffXcVOBHvVLAXhR4JFGaJHr89rVO462wB0TzPxUNN6FKEdDg4isQ0fcj?=
 =?us-ascii?Q?wkOjKBwXztC6Xn72ZTy8xnL8VsIzfzRkl1whHATT+hCXhj0zdfKuqYKo2YSw?=
 =?us-ascii?Q?ScRnYrZpeDJVbPn7eA/Fcy534/CKUqWi+S0GmW56CRFFUX87V7ehVPN6wSsQ?=
 =?us-ascii?Q?gU2uBjPJWGD68CdYJCLqgS4gRm2fR6MZkzToShe2qkDv2o62CxD4iMQn5fW7?=
 =?us-ascii?Q?+QOAvlxSuuVxgTleCbb/TCyP8cQ5V59cPENhh2lqwZU3jJYswAeFRbm54i7X?=
 =?us-ascii?Q?xEiMHlcrzW5vkihxLT/dotsST1ZmP9Fpixyz493s2M2gZ6sDHvvLLl8K7fZQ?=
 =?us-ascii?Q?6NWIaUfx8slUbb379sT6/lVLsQjT0VsYAG02N9Ua8g6kl/z75HRFs38idVq8?=
 =?us-ascii?Q?7S2mGVPfbKph9VsjY9IG4nC3Q7NhKx4MI/TwcGuJC/puGcPk/4Ak0LQwG+Mu?=
 =?us-ascii?Q?wz6C0cBaLjJibR8IqbQS6YWsfUf+WUGbm390s3QL8wKa4pkV/TCt8Isgroj2?=
 =?us-ascii?Q?szy6OvMtiNPBcB7UGwnclhK2ddvuKB50P1MYLOYRfAs2FyQ8jxYRAu1dbYcy?=
 =?us-ascii?Q?nYSswr7nWLlFjsiaEWyw8voUxPjSBMM6xiOcWUt4EmyJIOnyQUAzZX8xx3cK?=
 =?us-ascii?Q?TMm04bCF/izysY75QzWxavDOzp8GuwaiVRUSxHLOznpHLP3UYyjbZ8CrsLka?=
 =?us-ascii?Q?FcvzzD8O8zGr5GSLNJmWcNF/tuIsrlYhHd6FmnbLXudHA4ussBqtk4l6gCMQ?=
 =?us-ascii?Q?X4JZOmrVHW8CmDJaqIw/ELVVvetjO1/yldy9S4OZguxMdRAJSl1eKeATNrSy?=
 =?us-ascii?Q?PgHv8BBezOg2aJ9lalr+7bFOBsGBLFCIVh7FtinrIncYWbpMxFcjZk1maoX3?=
 =?us-ascii?Q?kFHPfIXCg79cliMfZE3nz7VQlRrt/Yxo0FVcst0dQKqDcLO8MJ3nHQIagzMC?=
 =?us-ascii?Q?+vOJt3ZC/DQgsQ1EpC602rHlb+UvluW0RPHW1IWKWTYsRUlpm+VzwQKqU1iA?=
 =?us-ascii?Q?O4SwjpD4riW1zGLKIwPVlo1ZRqEMIbhqvECaQecwVx7CJvEQMt7p3zMVfaf2?=
 =?us-ascii?Q?CjbOfR9d54lOZv/PvLpukXQj2Sylx8R/9tRNfwxK?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9185.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1c7f7222-0086-4257-ff4d-08db4bd57551
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 May 2023 12:53:57.1304
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 2FKcXd7ufU308xLFhr+YeGi+r7AxahnecrE0nTd/n/3KW0t+Exb5nvoUnBv5bR7+w1nTZmSxPsig5IZRAYTqrA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS5PR04MB9998
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Andrew Lunn <andrew@lunn.ch>
> Sent: Tuesday, May 2, 2023 6:19 PM
> To: Shenwei Wang <shenwei.wang@nxp.com>
> Cc: Wei Fang <wei.fang@nxp.com>; David S. Miller <davem@davemloft.net>;
> Eric Dumazet <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>;
> Paolo Abeni <pabeni@redhat.com>; Clark Wang <xiaoning.wang@nxp.com>; dl-
> linux-imx <linux-imx@nxp.com>; Alexei Starovoitov <ast@kernel.org>; Danie=
l
> Borkmann <daniel@iogearbox.net>; Jesper Dangaard Brouer
> <hawk@kernel.org>; John Fastabend <john.fastabend@gmail.com>; Alexander
> Lobakin <alexandr.lobakin@intel.com>; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org; imx@lists.linux.dev
> Subject: [EXT] Re: [PATCH v2 net 2/2] net: fec: restructuring the functio=
ns to
> avoid forward declarations
>=20
> Caution: This is an external email. Please take care when clicking links =
or
> opening attachments. When in doubt, report the message using the 'Report =
this
> email' button
>=20
>=20
> On Tue, May 02, 2023 at 05:08:18PM -0500, Shenwei Wang wrote:
> > The patch reorganizes functions related to XDP frame transmission,
> > moving them above the fec_enet_run_xdp implementation. This eliminates
> > the need for forward declarations of these functions.
>=20
> I'm confused. Are these two patches in the wrong order?
>=20
> The reason that i asked you to fix the forward declaration in net-next is=
 that it
> makes your fix two patches. Sometimes that is not obvious to people back
> porting patches, and one gets lost, causing build problems. So it is bett=
er to have
> a single patch which is maybe not 100% best practice merged to stable, an=
d then
> a cleanup patch merged to the head of development.
>=20

If that is the case, we should forgo the second patch. Its purpose was to r=
eorganize=20
function order such that the subsequent patch to net-next enabling XDP_TX w=
ould not=20
encounter forward declaration issues.

Thanks,
Shenwei

>    Andrew