Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp791419rwr; Wed, 3 May 2023 06:17:34 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5Y3LdtwaZKtmAqYC2YdEm1q63sJExnBElKnDbJ6DjNc0SJypsmEq9rr5MgwXJlH5yGgosz X-Received: by 2002:a17:903:2449:b0:1a9:3916:c2d1 with SMTP id l9-20020a170903244900b001a93916c2d1mr2827336pls.54.1683119854288; Wed, 03 May 2023 06:17:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683119854; cv=none; d=google.com; s=arc-20160816; b=j0uF1TtXlvwqwBAe49XWeoBKl+C8Mrbc/Ji7GvyyICsOuLykY66Q3y45knYbjkA7Bu +qraMvsL3VfbUmyjrqr3QtYEPHeYXIPhuHQ2m6V/TEv8UJr2NGBtaUNN4iUQOudlIydW TtwubZ7ByEjTtIrZ1WSLW4XxTHxIBb08RWlGJ5oEv+ITS/H69A+QIQtv8H2VKP5/eTfL IVsTqKs0GnhbLesXIaw78H7gZTh4V2uiRpqqprFtI278VE4hCZ0hy2HCdaEPgLg29RHN pylaBB2QtQLFPZn1pggaDnGzigXqVqpvxCeeI3reXsbdOo6c2Em/vAf1yqE31/PgTD3i ITOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=ruBfoULHrvsSndfcredgfVfHpySb2+zITXmPupumaC0=; b=vfl7CvmL4Ynw6qGcmE83aTXufd/sqwaoURyeoOYpu39o6kiLPg9Ny3J3WVqAcWYzU0 x3uLA6GODnBihOWPESLqOO8aTn1Z4JAXnZoN6VTCY0k5vV1OWFC5FSiKPaL4CQz7Xx1u cGJEejzZwty6Sar6lXk2BuN9VyM7Kq+Ee+RsJQf81ZbrZyvXs+wMYohEpxZTe842WYGL drR0pEOR7p3LvcXLNGXR18AwYRnA8raoona6hu8MkzCXah5sUnL/dVjeDzJMBfSh+cKn sVR2BjlpJAYzvpe9OHIp+vd/bZVFX6ws6rz5t9b3pXHM5zg7zAYRUJcr8iC5L+i3DM0Z LelQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="Yj/BVKS7"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id jh19-20020a170903329300b001a9a87d0c09si16452357plb.496.2023.05.03.06.17.19; Wed, 03 May 2023 06:17:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="Yj/BVKS7"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230028AbjECNNY (ORCPT + 99 others); Wed, 3 May 2023 09:13:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39496 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229873AbjECNNW (ORCPT ); Wed, 3 May 2023 09:13:22 -0400 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE2B56A4C; Wed, 3 May 2023 06:12:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1683119577; x=1714655577; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=IIXeI+ripUd8s4v1sJyWenwzfuWgZ/8pmxvBQG8Cqh8=; b=Yj/BVKS7YGvaeVXJrZkR5gH6AIu7KudYBTUqUG33fqWT4yzEwv0ZrRnB XdMgQ1LNHcq/GZ02FlId0mojO5fBAoxR+FpoWEnaoUU4cbvmP8TdoTldU Z42NGgvICtxnrWY84fV2PsI6QCCWFY9SDD3YuknBxsprPEDjWbr+i6LMI MIdSmHyUT7EC0a9I7MP4qMrsixcohd1SxWcQ5yBO/FQ75iS4/oVceS6cL oUViJFEnM4auFmGdzqyWr7OtMCfxSc+JyTKp6UoNIDei+1By2KnhKAEyH TSRyywVSaWxQB5ELTWz0REKbEPBdxSTbZsKtf2wngcbfkr5y51ZRQpNJe w==; X-IronPort-AV: E=McAfee;i="6600,9927,10698"; a="350727071" X-IronPort-AV: E=Sophos;i="5.99,247,1677571200"; d="scan'208";a="350727071" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 May 2023 06:12:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10698"; a="1026493664" X-IronPort-AV: E=Sophos;i="5.99,247,1677571200"; d="scan'208";a="1026493664" Received: from mattu-haswell.fi.intel.com (HELO [10.237.72.199]) ([10.237.72.199]) by fmsmga005.fm.intel.com with ESMTP; 03 May 2023 06:12:53 -0700 Message-ID: <8c4f85c1-32db-a84c-f77c-6e2aa556d2f4@linux.intel.com> Date: Wed, 3 May 2023 16:14:25 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.7.1 Subject: Re: [PATCH v2] xhci-pci: Only run d3cold avoidance quirk for s2idle Content-Language: en-US To: Mario Limonciello , Mathias Nyman , Greg Kroah-Hartman Cc: Natikar Basavaraj , Donghun Yoon , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230424214859.3109-1-mario.limonciello@amd.com> From: Mathias Nyman In-Reply-To: <20230424214859.3109-1-mario.limonciello@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-8.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25.4.2023 0.48, Mario Limonciello wrote: > Donghun reports that a notebook that has an AMD Ryzen 5700U but supports > S3 has problems with USB after resuming from suspend. The issue was > bisected down to commit d1658268e439 ("usb: pci-quirks: disable D3cold on > xhci suspend for s2idle on AMD Renoir"). > > As this issue only happens on S3, narrow the broken D3cold quirk to only > run in s2idle. > > Fixes: d1658268e439 ("usb: pci-quirks: disable D3cold on xhci suspend for s2idle on AMD Renoir") > Reported-and-tested-by: Donghun Yoon > Signed-off-by: Mario Limonciello > --- > v1->v2: > * Guard against CONFIG_SUSPEND not being set Thanks, Checkpatch complains that it wants a link to the issue after a "Reported-by:" tag. Is there any public report of this? Thanks Mathias