Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a5ff9c0f-6ee9-8b1a-5f77-fb56176bce22@amd.com>
Date:   Wed, 3 May 2023 15:27:03 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Content-Language: en-US
To:     Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc:     linux-kernel@vger.kernel.org, monstr@monstr.eu,
        michal.simek@xilinx.com, git@xilinx.com,
        Hyun Kwon <hyun.kwon@xilinx.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Vinod Koul <vkoul@kernel.org>, devicetree@vger.kernel.org,
        dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org
References: <30424f5886ef42419f65c2d5131ad30881c727a4.1683100816.git.michal.simek@amd.com>
 <20230503125125.GE32586@pendragon.ideasonboard.com>
From:   Michal Simek <michal.simek@amd.com>
Subject: Re: [PATCH v2] dt-bindings: dma: xilinx: Add power-domains to
 xlnx,zynqmp-dpdma
In-Reply-To: <20230503125125.GE32586@pendragon.ideasonboard.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YmJkLzBLSGJ1UWI5TmN6aDVIQ0R3Zk51NVozK2NmRzVsK2pZOHVyWU1KUC9H?=
 =?utf-8?B?SEZzTlZ0M1ZWQzdJUXRsVHhPL002dkd6QjdjMjZVVE5GQ0t0djYya0o3cE81?=
 =?utf-8?B?ZS9UMldXajVhcGpFVGVFbi90a0h2S2Z6ZGJLUGR5QUxBbkorMzc0d3BpeE5C?=
 =?utf-8?B?bjliQnpoTVpkMTJqK1BNV2V2OFY5QVkwTVFmNzVhN3VJREJXTDFqQ1htdVJX?=
 =?utf-8?B?M2QxaldaU3czdFlwcG9FMlgxNmZ4dmI4U1c2TTZsaHpNWUp2RDhlUmlWS2w0?=
 =?utf-8?B?dmJIRmF1WkJrT1ZGSHYyREFacjlTeFdqZ2ZFYklCNG5wTnlmM2QrSEREYWJF?=
 =?utf-8?B?d214ZDQwekZkaURCbkZ6TU15akRaTmdwdFBiYjVaSUJvZEF2T3hBdEczS2pu?=
 =?utf-8?B?TlBrbHl2TEVlYVRqZjgwbGNjMmF6dU56eGV3MysyeEJxVUNLZjlGU0NJUk5S?=
 =?utf-8?B?dzlaMCtkZlh2d0lmNU1oR2pzL1lsNnRjYkdnLzZneUR1M2tJYzR1Y2FwT1VL?=
 =?utf-8?B?TEtQV2JLWVUyNzROeE8vSzZEeDdqbVB0UkhlMTJPYTdjbmo1NU5ZSk9SeWVT?=
 =?utf-8?B?Lzh4V1dwVkVjeVFLWkVhRi9kSTc1cXV0bnRoa2U0ODJoNE5xUDhXSDAyUVVx?=
 =?utf-8?B?eDF4eEhaZ1R4NG1weVQxOENncXg3dCtwNHdTdXRCVFhpSVg0MTViRVVpVkpm?=
 =?utf-8?B?MGF0S25uSTZJT3YyNXdOK1ZRc3pGRGNVeE1Dc0ZwejZQakxCekR6blZxNTB4?=
 =?utf-8?B?UzFlZEh3Skx2bXg5alY3cC9ocjNMMTRVYS9XMWpWYnRxa3IrdWhqOVp5RWJI?=
 =?utf-8?B?WE00UTlOTlRSN3RoTGdIalM5N0w5S1ZidmE2L2ZRY1Fmb1FoRjJEU1lUNWcx?=
 =?utf-8?B?SnFyMzhRbnZSaGNhWXBoZlVGVTlrelFqdVdlTlp4VHJBVGhhcWZGUlV1RkFD?=
 =?utf-8?B?RUJVRjV2a0E0MjducGszR2h3T2xybTc1bm5UQ2V1aElQM0dsYVE5TUJ4ZitE?=
 =?utf-8?B?THdzUGtNMmRxb1Y4cUpxa2VLZE0wdGl3STEyRDEyekdWSWtab2RhRS9jQjN6?=
 =?utf-8?B?WE5CVVBPOTUvUzhJNkhZUGdObFFQQkI0NzlpSHJZOTZxbDh4aDRFZkM2c3lE?=
 =?utf-8?B?RGl2aGlPUWNwOUpmVVhTUE44aFZacFZwd0pEZUVqTmc3TjQyckRyNzV3bkpa?=
 =?utf-8?B?ZDdZb1ZPMHZkUjdTcVJzMEQ2WFdZME5ERERGd2ZsdEwveFZ2VXE1NDFMdmpo?=
 =?utf-8?B?QW05S2lKV3RZdmw4MjNjak4yVWdYbXFFNTNFSDVmWVNVNDMyZjRjTmxzSmFr?=
 =?utf-8?B?V2hOWXRGSjAva3gyN0pTR2R6RzZld2hXd1ZvZkRFTFY3eHBkaVFDQTZ1OGZF?=
 =?utf-8?B?b3MvZGlTRHl6Tk5NejhvYzM4bW5samM5eENhOTRNZGJESlZaNU1vVkpaaGxq?=
 =?utf-8?B?T1FJODJGTEtYaTUreHBvaWpjSmZSY2xrMWJnNmZ3M1JNYmZ5SmpVWWlkYk0r?=
 =?utf-8?B?QnBPY0R2N2NPVlhySTNPTmMvNC9TOUpQOTdDaTZNdVZzNGJhSzM1K3l4SDVq?=
 =?utf-8?B?Q1BPRGhLVzNYZjh0bHJWb29xRDdJY1daSFFnK1psZVEvVE1kYmVnQU92UjZU?=
 =?utf-8?B?OU4yWW4wMmhEZzQxNm1lc0dET0cxOFdyT3o2dWdRZEZHbVZWNmZDTXRoTFRj?=
 =?utf-8?B?QnNJemVVcWR1Nkl3NGh1dXpBZ2lNVDRrSGU4alVBdGZDcjlIdlBScEI1VWZi?=
 =?utf-8?B?KzhFWnBuTDVZdTZ5OUhvRTF2SXhSN3VRS2hmWFNubW9zU2JUbHdLRUI3YUxs?=
 =?utf-8?B?azFvcC9iRHVuWk16UGFERzFZQXlJMjd6L25TcElBQnFYVk9NMzIySC9wam5K?=
 =?utf-8?B?Mi9XT0YzZk40bWdCTENPeExLclZGQXpqZGtKT0M1NmxSMURpVGQzNTY3ZkJt?=
 =?utf-8?B?elhuZG9YdkhvNzlLcWc4bkFYNHl6TTJpelpXencwUzVUcHh0UHN6NitDQm5q?=
 =?utf-8?B?SlVTdng2SUxWa3UwckEwV3A4ZTBjdTVSVVVMYjdVN1IrM20vRHNnSUFQWjQ3?=
 =?utf-8?B?MUJ6eXJLMGFQbGhOWjlFL0x5MGFHaWdzZFh6ekdiY3NkQUhmS0E1cVFjZEpG?=
 =?utf-8?Q?bu54msCDNtXrINPw771k6Lotd?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1f4a5ca4-5a66-4ba6-3674-08db4bda1e2e
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB4758.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2023 13:27:18.5818
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yuTXoqUC3KaQMSWXPFhzNF1896hZebfvNHGwLTgLxv9YzGPByau2WxnaWRJSa2WO
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB8151
X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

On 5/3/23 14:51, Laurent Pinchart wrote:
> Hi Michal,
> 
> Thank you for the patch.
> 
> On Wed, May 03, 2023 at 10:00:20AM +0200, Michal Simek wrote:
>> DP DMA has own power domain that's why describe optional power-domain
>> property.
> 
> As far as I understand, the property should always be specified, the
> only reason why it's not mandatory is backward-compatibility (I would
> make it mandatory, as I think proper validation of new DT is more
> important than avoiding breaking validation - but not operation! - of
> old DT, but that's a separate story). If my understanding is correct,
> could you please update the example in the bindings to add the
> power-domains property ?

backward compatible - of course
always specified - if pd driver is enabled it must be there. If not it doesn't 
do anything - just describes it.

I am not in a position to decide this. But if dt folks agree with your ask I am 
happy to make it mandatory and extend example.

M