Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ac090da4-6cec-8c5a-22ac-36e130cb201a@amd.com>
Date:   Wed, 3 May 2023 08:59:13 -0500
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.1
Subject: Re: [PATCH v2] xhci-pci: Only run d3cold avoidance quirk for s2idle
To:     Mathias Nyman <mathias.nyman@linux.intel.com>,
        Mario Limonciello <mario.limonciello@amd.com>,
        Mathias Nyman <mathias.nyman@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Natikar Basavaraj <Basavaraj.Natikar@amd.com>,
        Donghun Yoon <donghun.yoon@lge.com>, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20230424214859.3109-1-mario.limonciello@amd.com>
 <8c4f85c1-32db-a84c-f77c-6e2aa556d2f4@linux.intel.com>
Content-Language: en-US
From:   "Limonciello, Mario" <mlimonci@amd.com>
In-Reply-To: <8c4f85c1-32db-a84c-f77c-6e2aa556d2f4@linux.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YkRIVDlETHlqb2gxZWxPRURyT25wdlpoTVFtSk9ESFI5b3J5TEZsbWowdGY0?=
 =?utf-8?B?OXNzNGdpTGtxOHZMNllyMkI2djRvdnRocWc5QnFmeHdoNVRWb2pBV1VFU1lL?=
 =?utf-8?B?c3hIZnl6dEhCaTdoRkhzWFFZc281U01iU2RRTWttWU5xZTgweGsxeWg1QUhj?=
 =?utf-8?B?OGxqdmVRTWU4ZmpMZ3dZYzluZzhFclVXQmpzRjMwanFZVkNCbXEvcE5TZDBH?=
 =?utf-8?B?VHRQYjdxNlRWZ016emMwb2hoVGJhdGxUK09oNS90UFBKYUJGTUNMZzYrZ1dW?=
 =?utf-8?B?VU00bGRjQjZTRFZiR2tKSVZrTjJ3Wnd0RzZVcThsSjJxRWlCRkN5R2ZQMDZr?=
 =?utf-8?B?eG4vSE9qUWVYYTNLTTdXZGdRVEFoNk5BQVczUHJTNFRpTTMwWFNaMFI4MFVO?=
 =?utf-8?B?azdGR1JiVmRyUzJkZTFCWk5GVjZTWGg0TkpLOERJRldjTTBDTWNkdnYzeHAw?=
 =?utf-8?B?MEh0OXhWMGJVS1BUVVNMbG9VcSs5U1N1aDdXRS9lSk1mczFkaFdzcU5IWWxv?=
 =?utf-8?B?L2g0UFpZcGFLV0hZMG9Qc2U3eHJNOEZ6c2owM2tqTmFjVzFvdG5kRDdUanNt?=
 =?utf-8?B?SjFua3JWZ1Yyb2FnOTZIdW54Zm9YcERyb28zcVhnZTZiWUMrZDBiWk1EUmhM?=
 =?utf-8?B?cUdMdTBkay9kUW1hU2xpdDcxNWFUMHp4V1NGN3Z5QUVhR0F0ZVpzTVRSRm9v?=
 =?utf-8?B?ektZdFU5MnF3a1p5WEQzUHNWRWJZNmVxRGdncnJVL2phb3FYOFIzbmI3OU9U?=
 =?utf-8?B?dnJzUmNBYTFIWTRGUkJLNExBRkhhVkQyMWV3U0xmV1hPbzZGbE5jaGhvaW1M?=
 =?utf-8?B?SkpwSmRHVGovUi9YV1ZSMmpsLytURjQzYjJ5enozVXRHK3BmMU5ycm0vbXNu?=
 =?utf-8?B?a25MUUtQVGg1UUFJK0EwWmUzMmxBTzRtWkx2UGQ0Y3p1elJncXBORUhRenc3?=
 =?utf-8?B?QjZDVkVjUHo4aGR4TGd4eXBuS0tsUjlxWjlkQjZXeXJ3MVlUdmxoS3FsSnRN?=
 =?utf-8?B?MmxVNWlLcDBmeXlocjczaWFLbFZmblJUSEZKbThOSHJaRTB6SnlYUmNxaElk?=
 =?utf-8?B?VVAwdis5VnFXak55cDlSRUJ6U2JKTFBlN0MwSUVObCtUOHdhMDdEWjh0OGtu?=
 =?utf-8?B?WGFldWs4NnFQM0QwYkptTDJnN1VWTHJHY01BNGdINGNlMjNUbDhidXBBbWI4?=
 =?utf-8?B?MEZVU3pDUTVxbWZkZDZ6K1BCd1BhM3IrSHRMVjhqRVl1Z0ExekI3VmRDREtm?=
 =?utf-8?B?YWxDbFIrMlJnMHUzeHFFbDlFakpKRjhKZHREc2dzMkFzN0NwaUVOQUF1RlNC?=
 =?utf-8?B?bGYxR1gzek9hajZvb2Fnc2NYRXBWb1ZTTElwVnV0eGR5TjlVRDZXNGo2NnhD?=
 =?utf-8?B?WVF3bHpEVzJxVVQ5SEpNRExUSnhSci9KTHpHSXFpd1duQm1lYndNYVNmK3Qx?=
 =?utf-8?B?eFdTUkRRMW5CV082cmNNRTJQRTQ3RDJaWEJkRGJkR1dyK3VVNVI0TkdJZnZT?=
 =?utf-8?B?VytTdyt6YnZkU3pULzVHNzZLa21meHRJVE54TVhSMmI2bWJiQ3p2cnR3dzNT?=
 =?utf-8?B?UHFlOXF3Q3E1MDQvRnVPdzh4ZjlCbUw1NWpaMkV2SllBOTNkandVVnFJMmxq?=
 =?utf-8?B?NGZRQUpzRm9oOFlBTEFiWGFIUmVIbGxtQkM1Z214bXFVTlRTRWtwckFNTFBa?=
 =?utf-8?B?ZmNqemJqQlVWS3YvUEdTTit1bldhcHRkYzFzV1FZVXFDUWRjY3dzMFFVK3Bs?=
 =?utf-8?B?UEl5ZVhSNVJQUno1Q0kvcHJwYUJrLzJSY2pncDh1bkwwRytKUklkS2dxWWxS?=
 =?utf-8?B?emFYc0JpL0Mvc1hFWGxoNDZaM3Q4N3UxMmJnT253aUxXc0pNUXhSRzNRQmVq?=
 =?utf-8?B?OXA3TVhMY1V0SUhRQ2ZrdmtPU25PaVNDdktIZUxJZ1VyV0tqNlhwZE4rLzF0?=
 =?utf-8?B?Ny9sYVdpSHExVnBnZkltSEcwR3ZwRFc0aS84ak1QR004YnNJK0FHaWxybkNX?=
 =?utf-8?B?VGxOVGxIZWNMQzE4M2RyUWtzWitrYzJ5RGxhOS9XWFlmS0h6WWU4NTZRQ05U?=
 =?utf-8?B?TGt1ODBPeWhDQlRycFFxNGlseEU5S3BTbG05bDUwQ2lkUXFQK1JFdm1VYnlH?=
 =?utf-8?Q?ojeVLuVz5qjXTlGLb0RDZxHO8?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7a7e161d-bb83-4809-e469-08db4bde98fc
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2023 13:59:22.6210
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5jpcLmeT/Fup18b+zNgI4QAXuqP19i9KSOsl2vGjvTBulMa2l/yXtI5KBn5/4JvfPRFGXoOhs9OFjE9qpyz/ag==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB7447
X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 5/3/2023 8:14 AM, Mathias Nyman wrote:
> On 25.4.2023 0.48, Mario Limonciello wrote:
>> Donghun reports that a notebook that has an AMD Ryzen 5700U but supports
>> S3 has problems with USB after resuming from suspend. The issue was
>> bisected down to commit d1658268e439 ("usb: pci-quirks: disable 
>> D3cold on
>> xhci suspend for s2idle on AMD Renoir").
>>
>> As this issue only happens on S3, narrow the broken D3cold quirk to only
>> run in s2idle.
>>
>> Fixes: d1658268e439 ("usb: pci-quirks: disable D3cold on xhci suspend 
>> for s2idle on AMD Renoir")
>> Reported-and-tested-by: Donghun Yoon <donghun.yoon@lge.com>
>> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
>> ---
>> v1->v2:
>>   * Guard against CONFIG_SUSPEND not being set
>
> Thanks,
> Checkpatch complains that it wants a link to the issue after a 
> "Reported-by:" tag.
>
> Is there any public report of this?
>
> Thanks
> Mathias
>
>
It was reported privately to me by Donghun, and they confirmed from 
private testing
that this change helps the issue.

I noticed that message from checkpatch too before I sent this up, but I 
figured it's better
to give Donghun attribution rather than drop the tag.