Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <1683092380-29551-1-git-send-email-quic_rohiagar@quicinc.com>
 <1683092380-29551-3-git-send-email-quic_rohiagar@quicinc.com>
 <CAHp75VegxMgAamS3ORiJ2=D4MH7asD9PiWrM+3JAm-QOuEgcrg@mail.gmail.com> <20a45e1e-6e62-9940-33d8-af7bad02b68d@quicinc.com>
In-Reply-To: <20a45e1e-6e62-9940-33d8-af7bad02b68d@quicinc.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Wed, 3 May 2023 16:53:50 +0300
Message-ID: <CAHp75VekkTVzVCJs10GEi=1Andb2rWTwK8RELw6SqMzKYCPq2w@mail.gmail.com>
Subject: Re: [PATCH v5 2/3] pinctrl: qcom: Refactor target specific pinctrl driver
To:     Rohit Agarwal <quic_rohiagar@quicinc.com>
Cc:     agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org,
        linus.walleij@linaro.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, richardcochran@gmail.com,
        manivannan.sadhasivam@linaro.org, linux-arm-msm@vger.kernel.org,
        linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, May 3, 2023 at 2:14=E2=80=AFPM Rohit Agarwal <quic_rohiagar@quicinc=
.com> wrote:
> On 5/3/2023 3:11 PM, Andy Shevchenko wrote:
> > On Wed, May 3, 2023 at 8:39=E2=80=AFAM Rohit Agarwal <quic_rohiagar@qui=
cinc.com> wrote:

...

> >>   /**
> >>    * struct msm_function - a pinmux function
> >> - * @name:    Name of the pinmux function.
> >> - * @groups:  List of pingroups for this function.
> >> - * @ngroups: Number of entries in @groups.
> >> + * @func: Generic data of the pin function (name and groups of pins)
> >>    */
> >>   struct msm_function {
> >> -       const char *name;
> >> -       const char * const *groups;
> >> -       unsigned ngroups;
> >> +       struct pinfunction func;
> >>   };
> > But why? Just kill the entire structure.
> Got it. Can we have a typedef for pinfunction to msm_function in the msm
> header file?

But why? You can replace the type everywhere it needs to be replaced.
I can't expect many lines to change.

Also consider splitting struct pingroup change out of this. We will
focus only on the struct pinfunction change and less code to review.

--=20
With Best Regards,
Andy Shevchenko