Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0537e5be-87c3-c551-ac12-d2cdf5b18b07@linaro.org>
Date:   Wed, 3 May 2023 16:09:34 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.1
Subject: Re: [PATCH v2] dt-bindings: dma: xilinx: Add power-domains to
 xlnx,zynqmp-dpdma
Content-Language: en-US
To:     Michal Simek <michal.simek@amd.com>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc:     linux-kernel@vger.kernel.org, monstr@monstr.eu,
        michal.simek@xilinx.com, git@xilinx.com,
        Hyun Kwon <hyun.kwon@xilinx.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Vinod Koul <vkoul@kernel.org>, devicetree@vger.kernel.org,
        dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org
References: <30424f5886ef42419f65c2d5131ad30881c727a4.1683100816.git.michal.simek@amd.com>
 <20230503125125.GE32586@pendragon.ideasonboard.com>
 <a5ff9c0f-6ee9-8b1a-5f77-fb56176bce22@amd.com>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <a5ff9c0f-6ee9-8b1a-5f77-fb56176bce22@amd.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 03/05/2023 15:27, Michal Simek wrote:
> Hi,
> 
> On 5/3/23 14:51, Laurent Pinchart wrote:
>> Hi Michal,
>>
>> Thank you for the patch.
>>
>> On Wed, May 03, 2023 at 10:00:20AM +0200, Michal Simek wrote:
>>> DP DMA has own power domain that's why describe optional power-domain
>>> property.
>>
>> As far as I understand, the property should always be specified, the
>> only reason why it's not mandatory is backward-compatibility (I would
>> make it mandatory, as I think proper validation of new DT is more
>> important than avoiding breaking validation - but not operation! - of
>> old DT, but that's a separate story). If my understanding is correct,
>> could you please update the example in the bindings to add the
>> power-domains property ?
> 
> backward compatible - of course
> always specified - if pd driver is enabled it must be there. If not it doesn't 
> do anything - just describes it.
> 
> I am not in a position to decide this. But if dt folks agree with your ask I am 
> happy to make it mandatory and extend example.

By making it mandatory in the bindings only, not in the driver, no real
ABI gets broken. Linux won't stop booting if property is missing.
Therefore if device is always part of power domain and it is actually
required, then sure - making it required is useful.

Best regards,
Krzysztof