Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230501190602.86281-1-jandryuk@gmail.com> <ZFAWaQbDR1_r5jf-@codewreck.org>
 <CAKf6xptMDRVet-C_1H7txPb_J_xq+XnNxwrQVbNWL_2JGnbHgw@mail.gmail.com> <ZFGdTDrPa1LD899y@codewreck.org>
In-Reply-To: <ZFGdTDrPa1LD899y@codewreck.org>
From:   Jason Andryuk <jandryuk@gmail.com>
Date:   Wed, 3 May 2023 10:11:05 -0400
Message-ID: <CAKf6xps8Z8GJZV6SJDmh7cM6v8EDuE6=V8+h1adjivaB70wLsA@mail.gmail.com>
Subject: Re: [PATCH] fs/9p: Remove INET dependency
To:     Dominique Martinet <asmadeus@codewreck.org>
Cc:     Eric Van Hensbergen <ericvh@kernel.org>,
        Latchesar Ionkov <lucho@ionkov.net>,
        Christian Schoenebeck <linux_oss@crudebyte.com>,
        v9fs@lists.linux.dev, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, May 2, 2023 at 7:31=E2=80=AFPM Dominique Martinet
<asmadeus@codewreck.org> wrote:
>
> Jason Andryuk wrote on Tue, May 02, 2023 at 08:03:15AM -0400:
> > > Good catch.
> > > Could you add depends on INET to NET_9P_FD in net/9p/Kconfig?
> >
> > trans_fd.o builds without INET and without UNIX.  Looks like trying to
> > use either TCP or UNIX sockets would lead to runtime errors, but it
> > also supports generic file descriptors.  That could be useful for
> > someone.   Since it builds, would it be okay to leave this patch
> > unchanged, or do you still want the depends added?  Leaving the patch
> > unchanged provides more flexibility, though the runtime errors may
> > surprise users.  While I built a Xen kernel without INET or UNIX, that
> > is an unusual scenario.  Typically INET and UNIX sockets will be built
> > in anyway even without a depends.
>
> Hmm, good point; the socket interface is common between INET and
> UNIX.. And you're right about the ability to use plain fd as well.
>
> How about 'imply INET'? That will automatically select INET when
> enabled, but allow someone to disable it explicitly.

This sounds good.

Thanks,
Jason