Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d7d435be-e178-2666-f83e-af3b6cc37137@kontron.de>
Date:   Wed, 3 May 2023 17:43:05 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH V3 6/7] drm: bridge: samsung-dsim: Support non-burst mode
Content-Language: en-US, de-DE
To:     Adam Ford <aford173@gmail.com>, dri-devel@lists.freedesktop.org
Cc:     marex@denx.de, Neil Armstrong <neil.armstrong@linaro.org>,
        Robert Foss <rfoss@kernel.org>,
        Jonas Karlman <jonas@kwiboo.se>, aford@beaconembedded.com,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        linux-kernel@vger.kernel.org,
        Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
        Andrzej Hajda <andrzej.hajda@intel.com>,
        Chen-Yu Tsai <wenst@chromium.org>,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        Jagan Teki <jagan@amarulasolutions.com>
References: <20230502010759.17282-1-aford173@gmail.com>
 <20230502010759.17282-7-aford173@gmail.com>
From:   Frieder Schrempf <frieder.schrempf@kontron.de>
In-Reply-To: <20230502010759.17282-7-aford173@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dU82T2kxMUhraFB5dWNSakNUUncyK2Z1aHlZMFNmMnNQYUdzSjZ5N2VzeEI1?=
 =?utf-8?B?bmE5UmY5eU9BVzFOQ1dNa3djcXhXK25OTmpOTDJzeTJ6UUwzU0xUUEhGOXV0?=
 =?utf-8?B?T21PUk52Tk9UNWxsbU8vMmJtSjVWWmhMS3hHZzRiM1FOeGNSZjNDNFdIUWNP?=
 =?utf-8?B?V1hZREJjVnFZUlBBa0JXNm4yR3ZtZ2p4MkdaajhXV2FoNXM0T1VJWXJ0bkNn?=
 =?utf-8?B?cSt5MkVWRFphNjBEWkFjR1dFcHNEcWwvOU5peWNSaTY3elRxcVNjd2Vlamc3?=
 =?utf-8?B?R0VlKzY2UGdMLy9ZeEVyNzdZbVpBcGtnRXIzRkxhZWJFczc5Rmo5UlhOa252?=
 =?utf-8?B?eXErcllqWjN0V21SOXZCZ09HZDllUk53OXlxbEtXRTRGS1NaQzhwOTZVajN2?=
 =?utf-8?B?eUZiRTAyRXNTU1gzanBrTmRZTUNmVVNMT09LNGpzc3pQVjRxc1drdHR0dUVR?=
 =?utf-8?B?M1VsS01DRTFHR094OUJBcEVXeE5aM3UxU0hwU0tyNTlXN0llSzdldVhpYzZO?=
 =?utf-8?B?a1UzM2tVdlFsUmMwM0llMkllUG0rbTFFMnhyNzFSWDNKVkthczlQUERvSGg1?=
 =?utf-8?B?clRzeW90cU9yblZ2emdSeFMzTElpOU9Ddyt5Q0Z0RUZZY2srU1BTZit3SlhR?=
 =?utf-8?B?ZUs1NWZGVWU0MWM2TUpzU0ZSOTlQcEJVUjBxSFNKN1lrSFZXcGFXTVArVmZl?=
 =?utf-8?B?LzBVNXRLL05qL0hTK2lJM0JIbGN5ZlVBY2QvV0hsVGk2QzBGTmd2Sk9lWlpY?=
 =?utf-8?B?MGo0UVZDbzdPU0t0a0czQnlVTkNRUGxTSjhKY0N1UlpvTGRVaW5STExYQkln?=
 =?utf-8?B?aWpUNDBBaGFTeFhHL1BwZllqM3ZHdkI2L0hEbU11TEJJUFZHMm0zUDVsSlpj?=
 =?utf-8?B?ZnlRc1N5czhhRm1TUHV0MUNIRjZyTlU0NkQ4MHVjano5WmpWcTRxV3lXWDF1?=
 =?utf-8?B?OXRxNGhGYlZaNElud21Scm42Y3ZnVHlpVTRzY21XejBQZU9uUDhyd1ZpUWE0?=
 =?utf-8?B?Y0VERUpDNzhRRTh0aGRVODMzaHpjWm85NXdBaDE0TnFsQlNYWjdHb1JSRDE4?=
 =?utf-8?B?cnFCREVnRTFjR3A5bHREbjdpZ2g5Z1B5UTlCK1J2RE1Ba1NxaVBobUwwcDVy?=
 =?utf-8?B?SkszUFluMWM0dm8rMFplUldtOEM5TXdrQldlU3lrSC9JVi81dzlURm5FZWZN?=
 =?utf-8?B?ZHY0eXJvQStmcit6K0s5MDB3OXFia1FrNEw1QTNiYVNiakxGNmRPdm5LTXNw?=
 =?utf-8?B?Qnd1NnRXN0ZLdWFhNjVSK3JSK1JMbGZIakRzbjlOQ0tmcTZMNmxJdlYwZDFE?=
 =?utf-8?B?aEtaQ3FBaGFlL2d3ZW43WERHcHFObWl5TkxFUlNtWUx3SklYM2dJcXNFRVdr?=
 =?utf-8?B?UlMrUmRZRGYwaHl5aDFpSHlXNHhGWmhwbjhqdzh5ZWREeGd3S1F3a2lKUU5Q?=
 =?utf-8?B?YjFWWVl4U2VKQVBUb1diMzl6TDdrdWZQeG5sVGtETHpLWGlSUytiUWwxWE1N?=
 =?utf-8?B?dG5jM0NiQ1UxSHBLcUhSWXFwamRRcjBKOEJQTHBSbWJYOCtBWVVDRFkzVEpD?=
 =?utf-8?B?dTNFQnFpMmdub0djQTJ2QmJCcE0xR0NnWEQ4U2RhdXZWMW5CNUxPWWNETGtB?=
 =?utf-8?B?b1dYR1BheDNPQTd2SWd2VmFKamlrYkNPTVpMWXdDVzdnU2x2aFNaYmI5UTVi?=
 =?utf-8?B?WStTY1RhWXJCbmFhbDUySjZjWHpyOVVNdk9hZGorT1VDS3ovZzVEVC80QTNE?=
 =?utf-8?B?cy8zTXcrdjh4ZEFqdStBTDNuUGpUSUxVcjljMG5QdVlkZ0VUNXp4N09nYXlL?=
 =?utf-8?B?b1NFMDNocE52QnFkb0E5bkIrOEZqaUJBTEJzbHREalM0b29oVG1naS9XYVpX?=
 =?utf-8?B?dXFvQ0dYV2FhRUJraEdhZGRzbmxjVytYSmdVQmcrekxYSmlTMnhqcFVTV0Fw?=
 =?utf-8?B?MjZyZHJ1SXdZRHdlb1VOR3NzZi9pMlB1ZjZlTlBnY2FQdjFqcFRsbFNIT0Jw?=
 =?utf-8?B?dDQvbzRzRFZsUnptekxzVGp3NVM4MTFESHhOcmcyWEx5QzFCVlZtQnBWcUpx?=
 =?utf-8?B?R25taklJb0ZlWXRjM3dnSzUrOEo0UU1pcEZ4MmFoQ0VtejZnTEUvQmk4ZHN3?=
 =?utf-8?B?SXMrVm5LWW94ZWdlRjgxVWxNTERtT3d4WWJ3RE41bmlUQk5FeVhFMW44blJr?=
 =?utf-8?B?NHc9PQ==?=
X-OriginatorOrg: kontron.de
X-MS-Exchange-CrossTenant-Network-Message-Id: 02da4c02-30f9-401e-55f9-08db4bed17a1
X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5681.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2023 15:43:08.0323
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8c9d3c97-3fd9-41c8-a2b1-646f3942daf1
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1EwPiBsnl0rZYzFR7JIbQf/EAjsfyxILQzwnw9sy5dc3BAWVaHxoCU3MZUyC6eQHnFPQpgmyHW7e6SANA+nYYzjfDiszKUHSnN721Mrbtyw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR10MB3646
X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,
        SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 02.05.23 03:07, Adam Ford wrote:
> The high-speed clock is hard-coded to the burst-clock
> frequency specified in the device tree.  However, when
> using devices like certain bridge chips without burst mode
> and varying resolutions and refresh rates, it may be
> necessary to set the high-speed clock dynamically based
> on the desired pixel clock for the connected device.
> 
> This also removes the need to set a clock speed from
> the device tree for non-burst mode operation, since the
> pixel clock rate is the rate requested from the attached
> device like an HDMI bridge chip.  This should have no
> impact for people using burst-mode and setting the burst
> clock rate is still required for those users.
> 
> Signed-off-by: Adam Ford <aford173@gmail.com>
> Tested-by: Chen-Yu Tsai <wenst@chromium.org>

Tested on Kontron BL i.MX8MM with SN65DSI84 and ADV7535 bridges.

Tested-by: Frieder Schrempf <frieder.schrempf@kontron.de>
Reviewed-by: Frieder Schrempf <frieder.schrempf@kontron.de>