Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp1022144rwr; Wed, 3 May 2023 09:11:06 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4fczw+SzQz75ECGcpOj5Sn0GvIbwIir4DbCZOEF0exHq2tpQDTjE9ElX1ljQG4KbnBzaWy X-Received: by 2002:a05:6a21:32a2:b0:cb:af96:9436 with SMTP id yt34-20020a056a2132a200b000cbaf969436mr8694811pzb.0.1683130266126; Wed, 03 May 2023 09:11:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683130266; cv=none; d=google.com; s=arc-20160816; b=q58bl9iW6yPX58TyAnUEP2aXUuo+MdIHnhw+MUnmDobe3uv6raEKl2pcQe0Ri6qR8U reqF6hqkg2F74oO6HeD63nRz4kkUeJwQvlxNvisgV4/Ff73uteNR9SpNgrux8mw5MyGO 0s1v90SaDaXk8OYyka6nv03CZapwIqzfNGPtvKUCowIwmRaOIfwBSoSVZNH8ksCEGY7m cgtxSKnuJhBVGkjyuNKypUqegTuTVWvLdmirchZK9FVlIPfAzP4EtVIxwUPQSe7/UCa5 Gt+sNaLZICEkC4FwxkLzjU7EMtLFjB7toxKVceforpdlOSxrEj7FCUDqKyxgGU7lW/mG CVag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=9zti7q8ZyeKskrlUo5qOh/lOMsR3cQk6t/fkiOgVlZ4=; b=MZwGTIjSZfX2BsC0Twf8UAS0sUvn4QGzSVywsNm5QFnJkK9vm3aACNfkF4kA8BOsxz lK/NtixnfxXWHufmrwuUbzUUyhLiCWQuvMkNhFq4qAb9iP9CX1QrUtuH0zU/ATfTiQp+ uFWgdtPbpmZ34X3c4KhLyclzvw/CW5dStuIA4C4BLG7+QTSa7tyMIqPSS9lDlAkN14bZ iDzyIsYZnLalkB2W5DJXEnkR3o/hLSgqnaRFh8F+3fP+ONONj+39CIMXu7tMopx0xMcH uGHdL+bIMHLVGcAA2b6TIoBLMW5rtbRloHZZ8UdZgO0UdT3vsVPRh5oorSxdVfrGMWqD ILQA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w1-20020a63fb41000000b0051b83af33desi32543700pgj.246.2023.05.03.09.10.50; Wed, 03 May 2023 09:11:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229847AbjECQH6 (ORCPT + 99 others); Wed, 3 May 2023 12:07:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42138 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229813AbjECQH5 (ORCPT ); Wed, 3 May 2023 12:07:57 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C99D5598 for ; Wed, 3 May 2023 09:07:56 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id D258068AA6; Wed, 3 May 2023 18:07:52 +0200 (CEST) Date: Wed, 3 May 2023 18:07:52 +0200 From: Christoph Hellwig To: jiweisun126@126.com Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, kbusch@kernel.org, axboe@fb.com, hch@lst.de, sagi@grimberg.me, ahuang12@lenovo.com, sunjw10@lenovo.com Subject: Re: [PATCH] nvme: add cond_resched() to nvme_complete_batch() Message-ID: <20230503160752.GA683@lst.de> References: <20230502125412.65633-1-jiweisun126@126.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230502125412.65633-1-jiweisun126@126.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 02, 2023 at 08:54:12PM +0800, jiweisun126@126.com wrote: > From: Jiwei Sun > > A soft lockup issue will be triggered when do fio test on a 448-core > server, such as the following warning: nvme_complete_batch can be called from irq context, so I don't think a cond_resched is a good idea here.