Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 03 May 2023 17:46:53 +0000
To:     "Luke D. Jones" <luke@ljones.dev>
From:   =?utf-8?Q?Barnab=C3=A1s_P=C5=91cze?= <pobrn@protonmail.com>
Cc:     platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org,
        acpi4asus-user@lists.sourceforge.net, hdegoede@redhat.com,
        corentin.chary@gmail.com, markgross@kernel.org, jdelvare@suse.com,
        linux@roeck-us.net
Subject: Re: [PATCH] platform/x86: asus-wmi: add support for ASUS screenpad
Message-ID: <_BfjSVwlhmByGevAd1Yo_jhipUa3r6y5HHSi34xdeaYqelyPe1PRnOEru21Yw76x0spJwAAs3jr0MJ0f_jUc8QY75Q1J1ovT5QPvm0p2WhY=@protonmail.com>
In-Reply-To: <20230503040207.257406-1-luke@ljones.dev>
References: <20230503040207.257406-1-luke@ljones.dev>
Feedback-ID: 20568564:user:proton
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi


2023. m=C3=A1jus 3., szerda 6:02 keltez=C3=A9ssel, Luke D. Jones <luke@ljon=
es.dev> =C3=ADrta:

> Add support for the WMI methods used to turn off and adjust the
> brightness of the secondary "screenpad" device found on some high-end
> ASUS laptops like the GX650P series and others.

Is it this one: https://www.asus.com/content/rog-screenpad-plus/ ?
Or is the "plus" version something different?

If it's a "proper" screen, wouldn't it be better to add support for it
in the respective subsystems? E.g. why not register a backlight device?


>=20
> Signed-off-by: Luke D. Jones <luke@ljones.dev>
> ---
> [...]


Regards,
Barnab=C3=A1s P=C5=91cze