Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <bf6c8b74-a9fd-c4bd-9025-9e9702aba449@amd.com>
Date:   Wed, 3 May 2023 13:30:26 -0500
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.1
Subject: Re: drm/amdgpu: fix an amdgpu_irq_put() issue in gmc_v9_0_hw_fini()
Content-Language: en-US
To:     Hamza Mahfooz <hamza.mahfooz@amd.com>,
        amd-gfx@lists.freedesktop.org
Cc:     Alan Liu <HaoPing.Liu@amd.com>, Mukul Joshi <mukul.joshi@amd.com>,
        Tao Zhou <tao.zhou1@amd.com>,
        Felix Kuehling <Felix.Kuehling@amd.com>,
        "Pan, Xinhui" <Xinhui.Pan@amd.com>, linux-kernel@vger.kernel.org,
        dri-devel@lists.freedesktop.org, Le Ma <le.ma@amd.com>,
        Stanley Yang <Stanley.Yang@amd.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Alex Deucher <alexander.deucher@amd.com>,
        David Airlie <airlied@gmail.com>,
        =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>,
        Hawking Zhang <Hawking.Zhang@amd.com>
References: <20230502165155.200068-1-hamza.mahfooz@amd.com>
From:   "Limonciello, Mario" <mlimonci@amd.com>
In-Reply-To: <20230502165155.200068-1-hamza.mahfooz@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SnkwVXJFQk9IdWZheHkzWFcxQmVDcUU5NURIZjNJNXV0RTF6SlJTaWtnU3ZP?=
 =?utf-8?B?OFdKSlJHWEN0Z09MeFlNUHhJNnBuTnh6NjVpcW9hN29PSFFIajM0MFRRQS9v?=
 =?utf-8?B?SVpEaUV2cWpKeVdYZVM5SldISjBWRmZENHNjMWFPWUVEK3hiamdsUWg3Uy8z?=
 =?utf-8?B?aC90L3c1aWk0NC9NMU9RcE43L1ZiK29jTFdJckpDMG5TQ2dFYXN0QTY1cnBJ?=
 =?utf-8?B?czR0czgwcGFlWEdKbzlpcnpVVVk4Kzh4b0RoR1RWVENZQnNIbUNQUWVHNE5n?=
 =?utf-8?B?QVhNQzYwTURUdktlY2RXbFVqOHJXM29Zc1ZBSWxlR0RzY2ZkMmozbWNiU3Zh?=
 =?utf-8?B?cTlRb2owNWZJdVNocmg1dVJiZmVhRmxWN01GUURxeFlrOHVhZ2IrQ1lwQVd3?=
 =?utf-8?B?SVQ5NkV6STZURmVJVG1uMllzTktUVmE2L2d6M29vWVcveWFhU1FLSEpVRnF4?=
 =?utf-8?B?TCtQZ0pEbUpnQzRFVGpJYTYyZHBlOTFDZ1EreU54UzFvT3ZOU2tCVVN6Y0NR?=
 =?utf-8?B?MmlCeDJKN2t6UDYvVHI5UitGVHoxUkk2NlJoUm9EZ29HdnQyRGVySjQyeW1k?=
 =?utf-8?B?ZGxrdFZGQk12bzNiOHpZV0JQM29LRDVPU2ZYVG1pL0lqWEkzT1d2eEszSE5a?=
 =?utf-8?B?bjdNOGQ4WVlVUjdWQ1BtKzVaVG96dHFTRUlFdDJVQUpxOXBpS1ZnTWc0OXJt?=
 =?utf-8?B?cVpRUkJoaDFwT0NidFJWai9mdFJ2bEZSdXE0VDQ4R0syUmtqOWdrTThTNW91?=
 =?utf-8?B?cXl6Z0ZtY09FdzlhS0p6OW1yci9Ja0JsT21PUkNveWRwMGNYQmtsbnRUSVNL?=
 =?utf-8?B?K3hTdlVPclp5bkV2UTMzbGV2Zkt2d1BvaFo4bVRLa09mUGxCWXZ6VlUyU09W?=
 =?utf-8?B?cVRDcHVGcnZEMHhRTWYyaU5vMDhONzU0SWFaa3JNRzdURjE5SFJCTG9RSXV2?=
 =?utf-8?B?YmtOQkFDVUloaXU0YlQ4bC85cEdIVHBrbDZqNFE4Y1pYR0wwVHl4OVJYbVZ4?=
 =?utf-8?B?ZDNlcmdSUjVlWG5aeEFTVmlvS05odEpMWWNBVHQ5N09jN21qUEZyU3VtYTd5?=
 =?utf-8?B?cTRKY1Bsc3FPTDcwRnk5VFBNOWxnb1d0YVBEWTM2YzZnSGNjYlluK1QvVVdW?=
 =?utf-8?B?VzhIdjFKOUNDeGxnRHBpajBpTHA0MFU3MDZScWpuNVNFT04yQUNWeUp1SXUw?=
 =?utf-8?B?ODh0RGdBWlV3Vk9RZ1ZVcTR6ZHFmVkJuT1hJTlF2OUJweUdad1dwaDkrbFl2?=
 =?utf-8?B?b1FtTkpCcWE3N3FmRHB0V1NNKzdESEdoUjZEUm1YQlN2UnFLdWVnZTNnUkdw?=
 =?utf-8?B?c3YyYjZiNU5qcE5FeS8vVUE4UDRzMkRNNnZiV2NEODE0NUQxck9uMVFwL3Bq?=
 =?utf-8?B?V1BqbzdCNmRuaElMV1JIZWQzVHFDOGQ0SXlTUUp3UEhSWGFLWHlIQ1IrLzJL?=
 =?utf-8?B?c0lSNGFJNHNNbVhhSEhieGxNM0VCNWFqZ2ZEbzF6QU90dm53THBBMnlGbE15?=
 =?utf-8?B?ekxNMHVaZks3WmgrZlJCUkN2M0RaaEdxUGNtWUF2bGpST0tHb2NiTmdxb0RW?=
 =?utf-8?B?VmVZT254YkEyRFd4NEUrY1NQbi8zZU9SNFVSYW11MTVwQWt4eUR6L3ZBbng3?=
 =?utf-8?B?aGt1TzVSWU5SendPL3g2a3RLTmdFTURDenhMN3ozMDBpeVpQVER6WUFJRGh0?=
 =?utf-8?B?bXV4RWw4aDZZYnUyVnBxTDd3UkVsbHI1TW85RkpNRTFyQ0R6MTNaSnJ5cmhq?=
 =?utf-8?B?em9TZVV6SGNQaDVnRzc2ZGY4WHJJb0lSeDJIVGpsK1Rwem5HdGtBeHdHQlVV?=
 =?utf-8?B?K283Z2FRR0o0UFVGRGNiVTljdUc3QW8vVlF5eWZvbTRjejlCczd5bHM1NWlG?=
 =?utf-8?B?RUxoM1pQbGJ6ZXFraGtXUXhpRUNEZ2FQVzF2dzJaRFBxRTROQzN3UXRKb3Yx?=
 =?utf-8?B?SFBid0ZZZ2pLd1I3RzNIbFVTVy8vR3ZFbFVZYjBBMGNBNWlpRlNWSnU0K3ov?=
 =?utf-8?B?T3lKNU9vZlZRVkF0c2tiV2lmZkxvRVNqWWVSZ2IxdmN0MUE3M0dyZk0rNXVF?=
 =?utf-8?B?Nmt0UkFzWXRGaGd5QUJZaUpBdDZKWjdLRnhqWFhEeUVaaC9EdFJMTlhITXF3?=
 =?utf-8?Q?0WP8gdUir7EbTaYXvYx4G9Sh0?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 91df8763-1271-4b09-ff0b-08db4c047929
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2023 18:30:30.1154
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GZtR0gYdEl88pOkd6SLwCOzRVuWbLEX0zJNkRhOl2LgJVBKjWB2hmWmywX5qk4b3oaHxZekC9/OYkdKLu9wxAQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB9045
X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 5/2/2023 11:51 AM, Hamza Mahfooz wrote:
> As made mention of, in commit 9128e6babf10 ("drm/amdgpu: fix
> amdgpu_irq_put call trace in gmc_v10_0_hw_fini") and commit c094b8923bdd
> ("drm/amdgpu: fix amdgpu_irq_put call trace in gmc_v11_0_hw_fini"). It
> is meaningless to call amdgpu_irq_put() for gmc.ecc_irq. So, remove it
> from gmc_v9_0_hw_fini().
>
> Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2522
> Fixes: 3029c855d79f ("drm/amdgpu: Fix desktop freezed after gpu-reset")
> Signed-off-by: Hamza Mahfooz <hamza.mahfooz@amd.com>

Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>

> ---
>   drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
> index 290804a06e05..6ae5cee9b64b 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
> @@ -1999,7 +1999,6 @@ static int gmc_v9_0_hw_fini(void *handle)
>   	if (adev->mmhub.funcs->update_power_gating)
>   		adev->mmhub.funcs->update_power_gating(adev, false);
>   
> -	amdgpu_irq_put(adev, &adev->gmc.ecc_irq, 0);
>   	amdgpu_irq_put(adev, &adev->gmc.vm_fault, 0);
>   
>   	return 0;