Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
To:     raghuhack78@gmail.com, Raghu H <raghuhack78@gmail.com>
Cc:     linux-cxl@vger.kernel.org,
        Alison Schofield <alison.schofield@intel.com>,
        ira.weiny@intel.com, bwidawsk@kernel.org, dan.j.williams@intel.com,
        vishal.l.verma@intel.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] cxl/mbox: Remove redundant dev_err() after failed mem
 alloc
Date:   Wed, 03 May 2023 20:32:37 +0200
Message-ID: <3235466.44csPzL39Z@suse>
In-Reply-To: <20230428012235.119333-2-raghuhack78@gmail.com>
References: <20230428012235.119333-1-raghuhack78@gmail.com>
 <20230428012235.119333-2-raghuhack78@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"
Precedence: bulk

On venerd=EC 28 aprile 2023 03:22:34 CEST Raghu H wrote:
> Issue found with checkpatch
>=20
> A return of errno should be good enough if the memory allocation fails,
> the error message here is redundatant

Typo: it's "redundant". No problem, I think you shouldn't resend only for t=
he=20
purpose to fix this. But...

> as per the coding style, removing it.
>=20
> Signed-off-by: Raghu H <raghuhack78@gmail.com>

Is "Raghu H" the name you sign legal documents with?=20

If not, please send a new version signed-off-by your full legal name.=20
Otherwise... sorry for the noise.

Thanks,

=46abio

> ---
>  drivers/cxl/core/mbox.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>=20
> diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c
> index f2addb457172..11ea145b4b1f 100644
> --- a/drivers/cxl/core/mbox.c
> +++ b/drivers/cxl/core/mbox.c
> @@ -1112,10 +1112,8 @@ struct cxl_dev_state *cxl_dev_state_create(struct
> device *dev) struct cxl_dev_state *cxlds;
>=20
>  	cxlds =3D devm_kzalloc(dev, sizeof(*cxlds), GFP_KERNEL);
> -	if (!cxlds) {
> -		dev_err(dev, "No memory available\n");
> +	if (!cxlds)
>  		return ERR_PTR(-ENOMEM);
> -	}
>=20
>  	mutex_init(&cxlds->mbox_mutex);
>  	mutex_init(&cxlds->event.log_lock);
> --
> 2.39.2