Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755511AbXJBLPx (ORCPT ); Tue, 2 Oct 2007 07:15:53 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752553AbXJBLPp (ORCPT ); Tue, 2 Oct 2007 07:15:45 -0400 Received: from namei.org ([69.55.235.186]:47380 "EHLO us.intercode.com.au" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752775AbXJBLPo (ORCPT ); Tue, 2 Oct 2007 07:15:44 -0400 Date: Tue, 2 Oct 2007 04:15:29 -0700 (PDT) From: James Morris X-X-Sender: jmorris@us.intercode.com.au To: Kentaro Takeda cc: linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, chrisw@sous-sol.org Subject: Re: [TOMOYO 05/15](repost) Domain transition handler functions. In-Reply-To: <4701F419.8080103@nttdata.co.jp> Message-ID: References: <4701F285.5000206@nttdata.co.jp> <4701F419.8080103@nttdata.co.jp> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 692 Lines: 28 On Tue, 2 Oct 2007, Kentaro Takeda wrote: > + > + mb(); /* Instead of using spinlock. */ > + ptr = domain_initializer_list; > + if (ptr) { > + while (ptr->next) > + ptr = ptr->next; > + ptr->next = new_entry; > + } else > + domain_initializer_list = new_entry; > + Please use standard kernel list handling, per include/linux/list.h Why do you need to avoid spinlocks for these manipulations? - James -- James Morris - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/