Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Shenwei Wang <shenwei.wang@nxp.com>
To:     Simon Horman <horms@kernel.org>
CC:     Andrew Lunn <andrew@lunn.ch>, Wei Fang <wei.fang@nxp.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Clark Wang <xiaoning.wang@nxp.com>,
        dl-linux-imx <linux-imx@nxp.com>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Jesper Dangaard Brouer <hawk@kernel.org>,
        John Fastabend <john.fastabend@gmail.com>,
        Alexander Lobakin <alexandr.lobakin@intel.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "imx@lists.linux.dev" <imx@lists.linux.dev>
Subject: RE: [EXT] Re: [PATCH v2 net 2/2] net: fec: restructuring the
 functions to avoid forward declarations
Thread-Topic: [EXT] Re: [PATCH v2 net 2/2] net: fec: restructuring the
 functions to avoid forward declarations
Thread-Index: AQHZfUKo4ZwVUtEG3EOjLFQNjL7Wpa9HnlQAgADiOCCAAC5aAIAAM7tw
Date:   Wed, 3 May 2023 18:41:59 +0000
Message-ID: <PAXPR04MB918564D93054CEDF255DA251896C9@PAXPR04MB9185.eurprd04.prod.outlook.com>
References: <20230502220818.691444-1-shenwei.wang@nxp.com>
 <20230502220818.691444-2-shenwei.wang@nxp.com>
 <6dff0a5b-c74b-4516-8461-26fcd5d615f3@lunn.ch>
 <PAXPR04MB9185BD38BA486104EE5B7213896C9@PAXPR04MB9185.eurprd04.prod.outlook.com>
 <ZFJ+9Ij+jOJO1+wu@kernel.org>
In-Reply-To: <ZFJ+9Ij+jOJO1+wu@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?SbQp6nkj81I3eYbksvFva5xZ6YJT05pJdUiVnUfNziQnc/74m7v2BGUaPEaT?=
 =?us-ascii?Q?2XHfj/GIFTTiBVfAhfqkVG3zuSXLkg4vNv+fA95WWAjEu5Am6WWPEB9lWmEJ?=
 =?us-ascii?Q?EPKc/pLBFBteBUdx3hDIG6K1sOpQP5he5Fy3R58F6m2hU4tjBbcNcKNluUUN?=
 =?us-ascii?Q?m0uB0ER6C+T/vjW9ZVHZY/8b9WWqo8EXXDjxP1Zdja0z8BXqIvxEViIJWx+I?=
 =?us-ascii?Q?4sm3kI6Dz3bFslL/pqQPb5GgNg+gCpAYYRQ9zvsUb+2++V+ry1/Wmz8ndLK9?=
 =?us-ascii?Q?dpXbJWM/tSxvzbDo1qQ6TPGUmyq1t7tvUUkjJ0FnymuvqVoIspWcQ1mMllgi?=
 =?us-ascii?Q?BZWEEe4jdeU25pWsrJVy1roomKc/HhOuS+bLg+F9HtkBmRvKz5dnhshUbSw4?=
 =?us-ascii?Q?a//az8/znkP2gLM3+PpgqHhj5ief/15Wb7hl5mTHkdZgMGTCnmThAMJatkWx?=
 =?us-ascii?Q?9nyBHHuP+J44gwvY3UUSUYWrwTsHoUlMpxYPIh3pQAzWlXkFUBWToSCu4s/G?=
 =?us-ascii?Q?6TwCYf9lh4D6rKrxQxuFAqEtaIl3/jIkzJ/v6yvVC2zLP9WDOSqERhcAb9Y7?=
 =?us-ascii?Q?PI/I/i7+l1+Do0/RyZdR798myiy453Ms8Z16NHRaXv+GejIQtKU6jNTM2TtU?=
 =?us-ascii?Q?Bs2TaTHDfLq6aeKsblez9Rjtd33lDmWBJoNCc4/JEKxtujv2QsVXrEr2kWYt?=
 =?us-ascii?Q?tYUFvwVaG47Bk56hVL/6x+Iry7Ql9ZXx8UOUiL0r4LiSLT1nJzGFI51KNs4K?=
 =?us-ascii?Q?bkVfHQiBFtwA8y/pPnpdcvmW9SLavoymcSLC3ZEUHjvkQssuirBN1an4aLC7?=
 =?us-ascii?Q?jDiNq+sg34q1oxRLNYwxWqfQ3HhEbC2iPcZuRB+rmhOMgT6tzxJirgC8cajd?=
 =?us-ascii?Q?uXgIBsbKr92eQB2AXx4ZXW+Ivvg+KAVstYvVxpcCSMNNNY5BUo1A1+hLykRG?=
 =?us-ascii?Q?8YEpmzDn/rjnfkDroxR6j4q0cNmwoshBM6WezheMP93Rtihoo0O8HU0jtHf+?=
 =?us-ascii?Q?uCqFzhxql9fOsHMR8cAJ8tEEC9UTddXpnBWYNBU0ES7Xrg24ICvSzisCUUIZ?=
 =?us-ascii?Q?AEs1egzNEItfbc80syeBakNlvSSOpiQQjrZBpKuIygq5yIo/bO1cRJRmfbjt?=
 =?us-ascii?Q?jRTkzURlVLoaplF7A9nu+ALu5FC+Yy5o0uGKdxwkjdCNgsh6vmC9DuY4tUQx?=
 =?us-ascii?Q?qrI3aU0L8tErcJzK8SbMNj/EWV5awRblTi5S7xGFMBwdfOiTpTWZkbe9GEkT?=
 =?us-ascii?Q?/sshe2UxasW3ea48k0s6Qq34TKBL31sJiOy2X1ycokcE7rzcKFZslsQczhtT?=
 =?us-ascii?Q?ljkA7C0WoAWK3QMnEljX+NWhssuG0rXLdMY8LsiGPCdvi4q+f7q3CqpiwZO6?=
 =?us-ascii?Q?iPGmXO1X974PsSKQ/7zf3VmMVk4iGW0TTavF6Uq1A0QaFjNaBhrBkIZt+k8h?=
 =?us-ascii?Q?zXrKtGvSvzJyrxt37HBdFFLKF97hi3m+rRice8PsnA2jpusYo1nhstHk4BmK?=
 =?us-ascii?Q?79ES/OWBfwrwQKU12pTXZ/BEwY4/ccNszhNwhSOjvE4tTexplYUSgDvW0Atd?=
 =?us-ascii?Q?beNddW1BoJKPbt2zhEwNc7jn9wSVtLINmcrjo+oo?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9185.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 239fdba7-9c92-4ea0-8928-08db4c061434
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 May 2023 18:41:59.5233
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: /NZ/93cH+pBCBx9Gb8f7QkLi1FLEP9DHjCsvh3NLkJQRlBbECRnOO1E5xHPjecIJc/GBypCMFeWxjQxH+rcjcw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DUZPR04MB9982
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Simon Horman <horms@kernel.org>
> Sent: Wednesday, May 3, 2023 10:34 AM
> To: Shenwei Wang <shenwei.wang@nxp.com>
> Cc: Andrew Lunn <andrew@lunn.ch>; Wei Fang <wei.fang@nxp.com>; David S.
> Miller <davem@davemloft.net>; Eric Dumazet <edumazet@google.com>; Jakub
> Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>; Clark Wang
> <xiaoning.wang@nxp.com>; dl-linux-imx <linux-imx@nxp.com>; Alexei
> Starovoitov <ast@kernel.org>; Daniel Borkmann <daniel@iogearbox.net>;
> Jesper Dangaard Brouer <hawk@kernel.org>; John Fastabend
> <john.fastabend@gmail.com>; Alexander Lobakin
> <alexandr.lobakin@intel.com>; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org; imx@lists.linux.dev
> Subject: Re: [EXT] Re: [PATCH v2 net 2/2] net: fec: restructuring the fun=
ctions to
> avoid forward declarations
>=20
> Caution: This is an external email. Please take care when clicking links =
or
> opening attachments. When in doubt, report the message using the 'Report =
this
> email' button
>=20
>=20
> On Wed, May 03, 2023 at 12:53:57PM +0000, Shenwei Wang wrote:
> >
> >
> > > -----Original Message-----
> > > From: Andrew Lunn <andrew@lunn.ch>
> > > Sent: Tuesday, May 2, 2023 6:19 PM
> > > To: Shenwei Wang <shenwei.wang@nxp.com>
> > > Cc: Wei Fang <wei.fang@nxp.com>; David S. Miller
> > > <davem@davemloft.net>; Eric Dumazet <edumazet@google.com>; Jakub
> > > Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>; Clark
> > > Wang <xiaoning.wang@nxp.com>; dl- linux-imx <linux-imx@nxp.com>;
> > > Alexei Starovoitov <ast@kernel.org>; Daniel Borkmann
> > > <daniel@iogearbox.net>; Jesper Dangaard Brouer <hawk@kernel.org>;
> > > John Fastabend <john.fastabend@gmail.com>; Alexander Lobakin
> > > <alexandr.lobakin@intel.com>; netdev@vger.kernel.org; linux-
> > > kernel@vger.kernel.org; imx@lists.linux.dev
> > > Subject: [EXT] Re: [PATCH v2 net 2/2] net: fec: restructuring the
> > > functions to avoid forward declarations
> > >
> > > Caution: This is an external email. Please take care when clicking
> > > links or opening attachments. When in doubt, report the message
> > > using the 'Report this email' button
> > >
> > >
> > > On Tue, May 02, 2023 at 05:08:18PM -0500, Shenwei Wang wrote:
> > > > The patch reorganizes functions related to XDP frame transmission,
> > > > moving them above the fec_enet_run_xdp implementation. This
> > > > eliminates the need for forward declarations of these functions.
> > >
> > > I'm confused. Are these two patches in the wrong order?
> > >
> > > The reason that i asked you to fix the forward declaration in
> > > net-next is that it makes your fix two patches. Sometimes that is
> > > not obvious to people back porting patches, and one gets lost,
> > > causing build problems. So it is better to have a single patch which
> > > is maybe not 100% best practice merged to stable, and then a cleanup =
patch
> merged to the head of development.
> > >
> >
> > If that is the case, we should forgo the second patch. Its purpose was
> > to reorganize function order such that the subsequent patch to
> > net-next enabling XDP_TX would not encounter forward declaration issues=
.
>=20
> I think a good plan would be, as I understood Andrew's original suggestio=
n,
> to:
>=20
> 1. Only have patch 2/2, targeted at 'net', for now 2. Later, once that pa=
tch has
> been accepted into 'net', 'net-next' has
>    reopened, and that patch is present in 'net-next', then follow-up
>    with patch 1/2, which is a cleanup.

So should I re-submit the patch? Or you just take the 1st patch and drop th=
e 2nd one?

Thanks,
Shenwei