Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp1258246rwr; Wed, 3 May 2023 12:22:31 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7NcpwPA8HTIDOdeBJajA5Cfo5pYv0xnQDzaRo7fYzQb68Bamv/sElzWkYK+cKMzZywuNMZ X-Received: by 2002:a17:902:f68c:b0:1aa:ed72:5c2e with SMTP id l12-20020a170902f68c00b001aaed725c2emr1316635plg.61.1683141751577; Wed, 03 May 2023 12:22:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683141751; cv=none; d=google.com; s=arc-20160816; b=Iv0Uzcfk3h7woslhbGj2msdxPTRWt2FW9aTrhhPzbKKEa/Ecw6/J8yd/xdWHLCIjI7 g0wnQK4vDkJy1hEu4NCndfBJRbPGpXVsCV89sv/b5mgumX1zNXOYulrBMvxiEwrJdPTh tVAZQyl9lP+nnudWdDAf2eoULuHiCM9+rsasYnDcqemQ9dm93owBPxefv4Aq29+tTO97 3g+KiP3BocnxRz+/KKPTRKjdfNDs/wfc0wQGpBMkQ0+dq+d8tXyVlmsOUJ0NHdM76uQJ MRgw16E64Tlhv3lZxGZkKMseviXe0dhjO1pm7aB387ZSyCwnS5AGBaGL25SYbdZq+PsJ 3TuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:dkim-signature:date; bh=kvDb7bxJfzE9KfjpQKTTQijQZOsAXNXH2iadfpJ44Yc=; b=nYACivz0nE9bu9fhO9mN2BnBKqMJ6JOLd3o5rYoJrcl/nBJs3AeerR5mX7J5rmTWvb M/M/8e4nZNREk/LyTjbThVniMDJEC80BObkaFXsvHEaZEQzV5WvGhhoMdQU/Zx5rnFuj maZZGJ8K8EZbJB5qMRCl8ac38OBDkTLlxfhuEIHhaEA2bHG8021eVAzMeUVtcRT5WmmN XLlwtDt/D2nZ9SziOYEzWpqEJ4S9A/uPGCWps8184AMCMvtFKXGgpPkP6K4yBY4W863i u7GK/kEXniw5R+FN/pzU1763L/hjAO3zLOb/rC8/HhGBtyTRzOKvh46sfj504EvEnc35 xdTw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=h1g4T3Qh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l13-20020a170902f68d00b0019953ab9cf2si36727498plg.138.2023.05.03.12.22.13; Wed, 03 May 2023 12:22:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=h1g4T3Qh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229878AbjECS5J (ORCPT + 99 others); Wed, 3 May 2023 14:57:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59616 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229934AbjECS5H (ORCPT ); Wed, 3 May 2023 14:57:07 -0400 Received: from out-43.mta0.migadu.com (out-43.mta0.migadu.com [IPv6:2001:41d0:1004:224b::2b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A18E77EC4 for ; Wed, 3 May 2023 11:57:00 -0700 (PDT) Date: Wed, 3 May 2023 14:56:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1683140217; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kvDb7bxJfzE9KfjpQKTTQijQZOsAXNXH2iadfpJ44Yc=; b=h1g4T3QhYib2nBdpUAXTn+2qQD9ejDw6IFQM/FKbwPTcpONEOGJug9IN/JkcPzWXJb7WMP 26usKy4n6B80sjCITIgILHgS1JbDUF0CHEgjPjZCLkcCdcNgTyG39f1X0AAT4O4tYbSzBt CqImMwnUyz+b+HgDx7XUNM9L7g1vdag= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Tejun Heo Cc: Johannes Weiner , Michal Hocko , Suren Baghdasaryan , akpm@linux-foundation.org, vbabka@suse.cz, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, ldufour@linux.ibm.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org, Alexei Starovoitov , Andrii Nakryiko Subject: Re: [PATCH 00/40] Memory allocation profiling Message-ID: References: <20230501165450.15352-1-surenb@google.com> <20230503180726.GA196054@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 03, 2023 at 08:40:07AM -1000, Tejun Heo wrote: > > Yeah, easy / default visibility argument does make sense to me. > > So, a bit of addition here. If this is the thrust, the debugfs part seems > rather redundant, right? That's trivially obtainable with tracing / bpf and > in a more flexible and performant manner. Also, are we happy with recording > just single depth for persistent tracking? Not sure what you're envisioning? I'd consider the debugfs interface pretty integral; it's much more discoverable for users, and it's hardly any code out of the whole patchset. Single depth was discussed previously. It's what makes it cheap enough to be always-on (saving stack traces is expensive!), and I find the output much more usable than e.g. page owner.