Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Shenwei Wang <shenwei.wang@nxp.com>
To:     Simon Horman <horms@kernel.org>
CC:     Andrew Lunn <andrew@lunn.ch>, Wei Fang <wei.fang@nxp.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Clark Wang <xiaoning.wang@nxp.com>,
        dl-linux-imx <linux-imx@nxp.com>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Jesper Dangaard Brouer <hawk@kernel.org>,
        John Fastabend <john.fastabend@gmail.com>,
        Alexander Lobakin <alexandr.lobakin@intel.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "imx@lists.linux.dev" <imx@lists.linux.dev>
Subject: RE: [EXT] Re: [PATCH v2 net 2/2] net: fec: restructuring the
 functions to avoid forward declarations
Thread-Topic: [EXT] Re: [PATCH v2 net 2/2] net: fec: restructuring the
 functions to avoid forward declarations
Thread-Index: AQHZfUKo4ZwVUtEG3EOjLFQNjL7Wpa9HnlQAgADiOCCAAC5aAIAAM7twgAAHzwCAAAKzUA==
Date:   Wed, 3 May 2023 19:20:15 +0000
Message-ID: <PAXPR04MB9185FA526B63311C3899BD9C896C9@PAXPR04MB9185.eurprd04.prod.outlook.com>
References: <20230502220818.691444-1-shenwei.wang@nxp.com>
 <20230502220818.691444-2-shenwei.wang@nxp.com>
 <6dff0a5b-c74b-4516-8461-26fcd5d615f3@lunn.ch>
 <PAXPR04MB9185BD38BA486104EE5B7213896C9@PAXPR04MB9185.eurprd04.prod.outlook.com>
 <ZFJ+9Ij+jOJO1+wu@kernel.org>
 <PAXPR04MB918564D93054CEDF255DA251896C9@PAXPR04MB9185.eurprd04.prod.outlook.com>
 <ZFKw5seP5WclDCG2@kernel.org>
In-Reply-To: <ZFKw5seP5WclDCG2@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?9HfNk0/XRn4W2EaIrf8jnJ3kmHrYZQlSM5mDyDDVB/KyJolZhIYTblI4HsTm?=
 =?us-ascii?Q?52H2Jwp+t5GaYKTB1137ENVGFcUg2+t1lw+cSRVjsyGuUnTf0TwcY8dKN8hF?=
 =?us-ascii?Q?z+e5zKg00G+dLZdpIDEJJRVQYj9e6XbGUxr/Y0gehFh4AZTYYFM1i9yW5SRw?=
 =?us-ascii?Q?xuKzzO4A2KPdEMsyQnjX4lhMdduEQJM7m1VJ0bmkFlfpH8JC3EA4rkKLAKxe?=
 =?us-ascii?Q?xe4QNUgNiLT614J9UpLDJ89gYzJYPpgBizgYGBqzV1t7MScsqXoZK8LvXKrU?=
 =?us-ascii?Q?uAvi4kNbdBxbAeroun7rU42nBSSvo5bbnK36+T6ul4ZcIbA30gsWf5enKi3P?=
 =?us-ascii?Q?6UgUFGJhrJhlPOK4xMtw9KkEUkTgqsuBt+ylTzKlp09hGuUrPazyX5iJqzYq?=
 =?us-ascii?Q?glD7Cc6w4tn3vY4U9rdJNbzvhpRbUVm+rmagltKInVLXBDcOy05HhpArcQsa?=
 =?us-ascii?Q?nbkCPxjbqwiFLcdQWrautIl8UtwZR8xglZvN+WeqfGQC9QvbpdKFijq0sjZh?=
 =?us-ascii?Q?bFjJYLIiS9W1806C74k/TubxeVxWNJLwVFZyD8dEVEmf1FtQ1x5mHfRMbtkX?=
 =?us-ascii?Q?4MTSnVUk34l88cD847H5aJUbcpkr5G6MwH16XHi+WTJURpZNqgQn6P4iqT45?=
 =?us-ascii?Q?9D3b+issRTXC6lkKUqoudnN0SEgPm4WqS3y5CYHBVJdBKKAIXPUPJr7imon1?=
 =?us-ascii?Q?ACckmclYgeRNj0hK54IV4bCGqK7iwnv5ilZcQ2sA+YL+7iCb3q8H916WSC+L?=
 =?us-ascii?Q?7a00AbK3paHNRa84/QmVI2BsKaKg2Xd5V+5r781y2HinOXZ32J6T0BKcdjmj?=
 =?us-ascii?Q?l7lhjd3UX9UbtIk0GnwSUZpYHz4m3zW6u1ijQbGfYhKuNAHC9Ur7II/0WLIV?=
 =?us-ascii?Q?CsIDSSrqdG6MKOzqAmN//ymdpEkQhbdCPIRCKAV306tZ0umPSmMnHmtu57+/?=
 =?us-ascii?Q?MVP7qflhJ/hnN3KpYb2+8G1cH/oCi8hxKlMjyTVolg+32Xw23LKMu+jzhNkv?=
 =?us-ascii?Q?gbsdSWelKLteEf8fD0zA9yVrDDuU2zMZW6wRcCbRWFr+2cqsT9sELEADgYR2?=
 =?us-ascii?Q?AsI8RoxleyBH3zHt2GlDJIYg9U1kyLAGhqNW86XF9zlNd+IFi3zqTc/TCezQ?=
 =?us-ascii?Q?cDTTaudXQE4moE83AARZfxr0qFYp/bwsU4Omsal1KhFsTXyqRSlUgfkVWwTZ?=
 =?us-ascii?Q?azebcQvDo94SgQqmuNsNR8+e9HJSSoqGhUYm4XRYz42kKYElZ+JEqN8Hj+Z1?=
 =?us-ascii?Q?Nl92hRWdkRYJRjnTfkpg4OZCq+MtyFUbM9qh5QpjYbBhEBWGlsP/FgLkWBdv?=
 =?us-ascii?Q?JAYJGimuyg+KV7tYgqOOCIOQ1oIyKz/6lEgu/Xx1HyTgpoim1SJ+yu+lBsre?=
 =?us-ascii?Q?WM/wXKmw1mztvGiuHh7C15F/sYzSOBbryI7FQffFdOj6RTdmA9p1ltKjfHk6?=
 =?us-ascii?Q?yAcKBVu7oXSxQiOlnM8Ryl9ueCGD6Mzf9oZijdGvl7V2bszNAlUQsfNtjVSM?=
 =?us-ascii?Q?xKJQdiGiDixC3j+7OuO8Mf/UXShFFScc64/2GyX35zb/BsHMCiIe/WrDKlPr?=
 =?us-ascii?Q?27K/rcOv98wLmhV3V2CHWa2cufYsnQ+Awy4yVARC?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9185.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 23129748-2dc1-4c01-110d-08db4c0b6cc6
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 May 2023 19:20:15.5994
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: MqAp6LX3NytpM6pNaeqIsl+WeSq5hK10O77esI2l4l1kzsPibXmncaPX9gajhvzKzbkcptt5iBaAr0qXjpYW9g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR04MB9484
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Simon Horman <horms@kernel.org>
> Sent: Wednesday, May 3, 2023 2:07 PM
> To: Shenwei Wang <shenwei.wang@nxp.com>
> Cc: Andrew Lunn <andrew@lunn.ch>; Wei Fang <wei.fang@nxp.com>; David S.
> Miller <davem@davemloft.net>; Eric Dumazet <edumazet@google.com>; Jakub
> Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>; Clark Wang
> <xiaoning.wang@nxp.com>; dl-linux-imx <linux-imx@nxp.com>; Alexei
> Starovoitov <ast@kernel.org>; Daniel Borkmann <daniel@iogearbox.net>;
> Jesper Dangaard Brouer <hawk@kernel.org>; John Fastabend
> <john.fastabend@gmail.com>; Alexander Lobakin
> <alexandr.lobakin@intel.com>; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org; imx@lists.linux.dev
> Subject: Re: [EXT] Re: [PATCH v2 net 2/2] net: fec: restructuring the fun=
ctions to
> avoid forward declarations
>
> Caution: This is an external email. Please take care when clicking links =
or
> opening attachments. When in doubt, report the message using the 'Report =
this
> email' button
>
>
> On Wed, May 03, 2023 at 06:41:59PM +0000, Shenwei Wang wrote:
>
> ...
>
> > > > > On Tue, May 02, 2023 at 05:08:18PM -0500, Shenwei Wang wrote:
> > > > > > The patch reorganizes functions related to XDP frame
> > > > > > transmission, moving them above the fec_enet_run_xdp
> > > > > > implementation. This eliminates the need for forward declaratio=
ns of
> these functions.
> > > > >
> > > > > I'm confused. Are these two patches in the wrong order?
> > > > >
> > > > > The reason that i asked you to fix the forward declaration in
> > > > > net-next is that it makes your fix two patches. Sometimes that
> > > > > is not obvious to people back porting patches, and one gets
> > > > > lost, causing build problems. So it is better to have a single
> > > > > patch which is maybe not 100% best practice merged to stable,
> > > > > and then a cleanup patch
> > > merged to the head of development.
> > > > >
> > > >
> > > > If that is the case, we should forgo the second patch. Its purpose
> > > > was to reorganize function order such that the subsequent patch to
> > > > net-next enabling XDP_TX would not encounter forward declaration is=
sues.
> > >
> > > I think a good plan would be, as I understood Andrew's original
> > > suggestion,
> > > to:
> > >
> > > 1. Only have patch 2/2, targeted at 'net', for now 2. Later, once
> > > that patch has been accepted into 'net', 'net-next' has
> > >    reopened, and that patch is present in 'net-next', then follow-up
> > >    with patch 1/2, which is a cleanup.
> >
> > So should I re-submit the patch? Or you just take the 1st patch and
> > drop the 2nd one?
>
> net and net-next work on a granularity of patch-sets.
> So I would suggest re-submitting only patch 2/2 for 'net'.
>

Hi Simon,

I'm a bit confused.

Are you suggesting that I submit the following restructuring patch for 'net=
' at this time?
[PATCH v2 net 2/2] net: fec: restructuring the functions to avoid forward d=
eclarations

Thanks,
Shenwei


> I would also suggest waiting 24h between posting v2 and v3, as per
> https://kernel.or/
> g%2Fdoc%2Fhtml%2Fnext%2Fprocess%2Fmaintainer-
> netdev.html&data=3D05%7C01%7Cshenwei.wang%40nxp.com%7Ca451f7a0cf674
> 0b0561d08db4c09a558%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7
> C638187376528990151%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwM
> DAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C
> &sdata=3DwBrPt7eKO2Y8ve%2B%2BG8STtZZVS9YdQR11YUL6wcwJ29M%3D&rese
> rved=3D0
>