Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 3 May 2023 17:42:22 -0600
From:   Keith Busch <kbusch@kernel.org>
To:     jiweisun126@126.com
Cc:     linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
        axboe@fb.com, hch@lst.de, sagi@grimberg.me, ahuang12@lenovo.com,
        sunjw10@lenovo.com
Subject: Re: [PATCH] nvme: add cond_resched() to nvme_complete_batch()
Message-ID: <ZFLxXjiQUPl+tV8L@kbusch-mbp.dhcp.thefacebook.com>
References: <20230502125412.65633-1-jiweisun126@126.com>
 <ZFKLxfet7qUIwScd@kbusch-mbp.dhcp.thefacebook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZFKLxfet7qUIwScd@kbusch-mbp.dhcp.thefacebook.com>
Precedence: bulk

On Wed, May 03, 2023 at 10:28:53AM -0600, Keith Busch wrote:
> On Tue, May 02, 2023 at 08:54:12PM +0800, jiweisun126@126.com wrote:
> > According to the above two logs, we can know the nvme_irq() cost too much
> > time, in the above case, about 4.8 second. And we can also know that the
> > main bottlenecks is in the competition for the spin lock pool->lock.
> 
> I have a fix that makes pool->lock critical section much shorter and constant
> time. It was staged in mm tree for months, but mysteriously it's missing...

Well this is certainly odd: the commit I'm referring to is in Linus' log, but
the file it modified is not updated. What kind of 'git' madness is this??

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=a4de12a032fa6d0670aa0bb43a2bf9f812680d0f

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/log/mm/dmapool.c