Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Xiaolei Wang <xiaolei.wang@windriver.com>
To:     aisheng.dong@nxp.com, festevam@gmail.com, shawnguo@kernel.org,
        ping.bai@nxp.com, kernel@pengutronix.de, linus.walleij@linaro.org,
        shenwei.wang@nxp.com, peng.fan@nxp.com,
        bartosz.golaszewski@linaro.org
Cc:     linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v3 1/1] pinctrl: freescale: Fix a memory out of bounds when num_configs is 1
Date:   Thu,  4 May 2023 08:33:30 +0800
Message-Id: <20230504003330.1075531-2-xiaolei.wang@windriver.com>
In-Reply-To: <20230504003330.1075531-1-xiaolei.wang@windriver.com>
References: <20230504003330.1075531-1-xiaolei.wang@windriver.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?p1ViqC4GOz77aMEYhmg+6C/bnkqfLkLoM/CoRkgOT1nQ2vMOo0eQIj/9fnzV?=
 =?us-ascii?Q?vssg8NdYVFn9DW/PZ9k39b+Snkvy7FGHyx5BnQeYCWx7xvuoc0mZzfo+XXKL?=
 =?us-ascii?Q?vz6bA1x7ovdV3fInWJP+1fnIv56alJAF1023u858hGC9K+zov9oPtb5owSh0?=
 =?us-ascii?Q?3NUXBOzsOv4wdDD5CxB0betW8vYTMULlDwAMsNmHfT1v3S/dboWGVwc8SS6b?=
 =?us-ascii?Q?uqBEHui/MPixV/N5wl7Yp0ZuUOfzPxy+Ff2yanYDo2e9x1E8oZWxFollPvk4?=
 =?us-ascii?Q?K1P2bIpgc4DYOPqkrrhDDUxdBbmpbDpHUYZuYIX9nOvvzuec9PyRil5YXOBv?=
 =?us-ascii?Q?pacTwugs6OPGD8LPDAoCc3y4/DWcSWhARLOIqBQblYatMQISgE0L3Fq3WIba?=
 =?us-ascii?Q?0wOOapNU7ESIwd4QEpUl2mnLA5T8eJWDMoXRGlRFY38/9rPXPBIIthd1OmR6?=
 =?us-ascii?Q?IJcH1LNTXL9jMuv4vDmKKeD3ltBa7BoAvYoQc3AT35PNEd+nyt4WxB+6BeFj?=
 =?us-ascii?Q?WvG+WjuKS7rImVyl9VfmybTOgO3EXEt1rgjiZRTH/SjA/6RfgKYjPuGrivEt?=
 =?us-ascii?Q?ErJwc41dbDrHUamIR6v+97YhbTMFQ0ByU7B5YRKKbVxHyWqMS4wkcROAlvmr?=
 =?us-ascii?Q?2tfYuCPICP+6t3GvUTLKXPByPoj+W3XeMEPZzusRuJtDnR+/wfxhf7JOLmlN?=
 =?us-ascii?Q?L2+m4uNDpz3x4hpU8d4aUKDjljG/7IPbQtkI9qU7TstvfMWN8uDGr24xF5jv?=
 =?us-ascii?Q?AkhjKE8onkLJ0mpCoccIcRewH2qiGwuK7gRT3ucPfu0BiwHVYObmWYUqvmUZ?=
 =?us-ascii?Q?+Fe4fI1wurzcjYFXvnRqWjIpZ+aD1r/5IKd0GGLh2cq4kKt/e9YE53Yw4a0d?=
 =?us-ascii?Q?uSypYlnQA8nglZR6ciKJ+3XDAygHMCsghXTwZeITGTPp3vmx0S8Z7WBA4HiP?=
 =?us-ascii?Q?mammwpTmTNz25kSGdh1ZX9s64h60lv/Km1UtIqxvN6pVMnaw/3mYJ21ObNNp?=
 =?us-ascii?Q?KNSACk/NKSDG2NSno+9VgAX9TJ+aIqUQlPvDoezZTKmG9TDCEJ6GvlFS+vMm?=
 =?us-ascii?Q?BwHvzsyZ+clrx5umbUGS7eqQ1XGCIuT/Y4wFu+jEkwHd67VSg7t2qWTqU9mS?=
 =?us-ascii?Q?btFLhNxuhs6GxZkGyxPab2aTfTrWim4kCBjbTJi+6D3HIlXVTQDptYwQxBr6?=
 =?us-ascii?Q?t1Nx/cE/HmMvDkHnFVSgzPFMQKwlJp6fjrzBh9SxmC1ejgIuLMQi928UZ7e3?=
 =?us-ascii?Q?DcOQIwujpH49lHsZyrjKqtBBJRZrbewFGiYoc25IsZBnTfgIqY2GqEbcVg5w?=
 =?us-ascii?Q?x5ELdb8dq+SivQYldSB5b5xlK64TbtY2G5IjKtYYXz2EgMa2FPtQTv0ykmja?=
 =?us-ascii?Q?SpwbQDQTrjb+tiPD1f2eCydTpfbgxM/LriWcoVIGUSWHJDYcm63v85JST/TB?=
 =?us-ascii?Q?GCbJWRaExa7aXQ503CCk9lo7gPYqR1xD+qsNDAC8GJFmY8Ax/f/xbp3wLm4k?=
 =?us-ascii?Q?NcGq93Oc0vGPh3jtLBaQZsXbH48yUQtI/W/qARUCWhmb0jz3HgScRNw1gX5h?=
 =?us-ascii?Q?1I9BoRkDDorFpWIJYDoQ4eofFnYKLxpfRjiwlMvRwKw45d0UvOKNXgHJLerH?=
 =?us-ascii?Q?cQ=3D=3D?=
X-OriginatorOrg: windriver.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d9080282-f16e-4172-1992-08db4c374025
X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5764.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2023 00:33:58.8833
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kcCjiQPXBvc9LGQ0oWj80zI0plpAZuGEb8Hsfn1gSVlPdyM18Mr5h5QxXBL6BwsdYk/V66xkviQEvRdEx2VumWgTz1e7X8Lb/NhMaMQd7MA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB6664
X-Proofpoint-ORIG-GUID: ag8JoNVDj2TnzieBMSkZ9l6v6EwsUAxe
X-Proofpoint-GUID: ag8JoNVDj2TnzieBMSkZ9l6v6EwsUAxe
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-05-03_16,2023-05-03_01,2023-02-09_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 malwarescore=0
 bulkscore=0 clxscore=1015 mlxlogscore=648 adultscore=0 lowpriorityscore=0
 mlxscore=0 suspectscore=0 phishscore=0 impostorscore=0 priorityscore=1501
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000
 definitions=main-2305040002
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The config passed in by pad wakeup is 1, When num_configs is 1,
configs[1] should not be obtained, which will generate the
following memory out-of-bounds situation:

BUG: KASAN: stack out of bounds in imx_pinconf_set_scu+0x9c/0x160
  Read size 8 at address ffff8000104c7558 by task sh/664
  CPU: 3 PID: 664 Communication: sh Tainted: G WC 6.1.20 #1
     Hardware name: Freescale i.MX8QM MEK (DT)
  Call trace:
    dump_backtrace.part.0+0xe0/0xf0
    show stack+0x18/0x30
    dump_stack_lvl+0x64/0x80
    print report +0x154/0x458
    kasan_report+0xb8/0x100
    __asan_load8+0x80/0xac
    imx_pinconf_set_scu+0x9c/0x160
    imx_pinconf_set+0x6c/0x214
    pinconf_set_config+0x68/0x90
    pinctrl_gpio_set_config+0x138/0x170
    gpiochip_generic_config+0x44/0x60
    mxc_gpio_set_pad_wakeup+0x100/0x140

Fixes: f60c9eac54af ("gpio: mxc: enable pad wakeup on i.MX8x platforms")
Signed-off-by: Xiaolei Wang <xiaolei.wang@windriver.com>
---
 drivers/pinctrl/freescale/pinctrl-scu.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/pinctrl/freescale/pinctrl-scu.c b/drivers/pinctrl/freescale/pinctrl-scu.c
index ea261b6e7458..3b252d684d72 100644
--- a/drivers/pinctrl/freescale/pinctrl-scu.c
+++ b/drivers/pinctrl/freescale/pinctrl-scu.c
@@ -90,7 +90,7 @@ int imx_pinconf_set_scu(struct pinctrl_dev *pctldev, unsigned pin_id,
 	struct imx_sc_msg_req_pad_set msg;
 	struct imx_sc_rpc_msg *hdr = &msg.hdr;
 	unsigned int mux = configs[0];
-	unsigned int conf = configs[1];
+	unsigned int conf;
 	unsigned int val;
 	int ret;
 
@@ -115,6 +115,7 @@ int imx_pinconf_set_scu(struct pinctrl_dev *pctldev, unsigned pin_id,
 	 * Set mux and conf together in one IPC call
 	 */
 	WARN_ON(num_configs != 2);
+	conf = configs[1];
 
 	val = conf | BM_PAD_CTL_IFMUX_ENABLE | BM_PAD_CTL_GP_ENABLE;
 	val |= mux << BP_PAD_CTL_IFMUX;
-- 
2.25.1