Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0dc77b4b-1f8d-f21c-303b-3ea6d5b978db@intel.com>
Date:   Thu, 4 May 2023 09:11:08 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH v2 21/21] KVM:x86: Support CET supervisor shadow stack MSR
 access
Content-Language: en-US
To:     "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>,
        "peterz@infradead.org" <peterz@infradead.org>,
        "pbonzini@redhat.com" <pbonzini@redhat.com>,
        "Christopherson,, Sean" <seanjc@google.com>,
        "john.allen@amd.com" <john.allen@amd.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>
References: <20230421134615.62539-1-weijiang.yang@intel.com>
 <20230421134615.62539-22-weijiang.yang@intel.com>
 <918166a78f5306210b1877107609cbd340f79a67.camel@intel.com>
From:   "Yang, Weijiang" <weijiang.yang@intel.com>
In-Reply-To: <918166a78f5306210b1877107609cbd340f79a67.camel@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZENwZ1dCNHo1TlVMd3JTMHBiTXJEbkNRMmxyUVpqSEIzRzBXOHdxcDI5SWJM?=
 =?utf-8?B?VWRReGhhZWNubnJDYVkvbjNCL0I1VTgzL0t0ZlY0a252YzFJMW1aZWZjZ01J?=
 =?utf-8?B?OUtKa0d5dVU0aS85aElzclEyK09kMXA1c2dSa2N6VEdMek9uWGNiN0FaRlJR?=
 =?utf-8?B?M3gyYlN4dkJ1NVBHN1lWWTFGVzcxbWl3RWxDOWl6VUQxMHhyZFZGNUNIckFn?=
 =?utf-8?B?M3lGUlMvWHhCaVYyYlRXVVJtdndkNWszTDNwNkF3Q09vcEhyd051a3ZvL0Y2?=
 =?utf-8?B?RE9LUjU0N0Jnb0xvSVQ3YVJXT0JtdS8zODlEN0lJVUgwR1hkOVpSQW5MU0Ri?=
 =?utf-8?B?OXVGMFhzMWkzRHdvS2xncFRJSnEwb0laU3pCZ1ZlMEZkVVdCdXc3ekVIQ21T?=
 =?utf-8?B?K0pZdHhsbW5nWVRSeXVNdVVubWhKQm9RclY2SURkb0tpSUI1VHZ6KzNqQTl5?=
 =?utf-8?B?UUh0TVM3YUl6TjZ6b0hGbFY1M2xzbVgvQjF6MWZVSURxUllxV1JlcDBJZnVJ?=
 =?utf-8?B?UmZIRW5UcWpKeUM0ZkRFMm5zSFZ4SWNpMUIydzRpekcxbE1zZ3R6dGR5VThZ?=
 =?utf-8?B?RnVBTkcvN3JGMWhpNk5nK09VZUNEclpCVDEwb1ZNYm5ISzBjYVRVaTdkM0tP?=
 =?utf-8?B?NmdyU3NGaVcrY0tiY2dJNU5ZR3VzN3NuZlRocHJJZHNaRVF6YnBEdGMzQjlR?=
 =?utf-8?B?KytDUyswaXM0WVRDaFRUZFNERWN5aStPYXJ3UEJ0S3ZsVW9nK241blVrcys5?=
 =?utf-8?B?QlNjb0dFU2trYUxYM3NqaFIvVnEzVEt4WXBqcnhSU2dpems5Q3l6blZ1em5V?=
 =?utf-8?B?TFFRM3RRd1ZkTFFSVS9Jcm9oeWJaYndWWWhhVU8zUTV1RUdWdXVaZmMwcENy?=
 =?utf-8?B?c2FteHhJdURyTnZ1cDNzeXJXL0pFUHpoaXdHZ2ZSQWZEckZZWDBWRzk2dWJk?=
 =?utf-8?B?aWljVEIySGdiZDUrR0NwcG5ab1JrSXVJWERsT2xwRkpOTU9CNm9rcGdhZS9Q?=
 =?utf-8?B?dllqOXNWTW5TL1NYbE5CZlNnYWVDM1pwdndXWkpGaXdlTktUdXRmcDJhcnN0?=
 =?utf-8?B?MFR4VEt2V0swcXhJZjBwZFozSVNnbGRGWnFwK2VKTHJJTnZGbXh0N2JEejhX?=
 =?utf-8?B?TzU3ZnR2Z09vMkU4c0E1Y3VPUnF6dkNoQWFzQklwVEtON2FKckpzaFVkd21x?=
 =?utf-8?B?ZTkwOWpQZjF0VzQ5V1lhclVzNkRvUVhoOUJMTmJjVkluSXhoYk1YQktpWWxw?=
 =?utf-8?B?QW1wNWNZeFppTlV0TnNJM0ZiN3JFTWUrMkY1aERWRWlkNkQ1dHhibURPcGxV?=
 =?utf-8?B?WThxUk96eGZiSzJZdUFqakk0eFYvRnRNS2RQK0pSbUtrUElzQmVGY1hlYkFY?=
 =?utf-8?B?dDlwRTZObjlIQmg3aVliSHJXZldzTjJEVTI1cUlNU1ZJTHRpZHh5R0todkcw?=
 =?utf-8?B?MDlLNFR5WVRYV0IraUJsbmp5T3lhQ2V2T1RacFJMNCtON3J1WDcxdFhYSEpW?=
 =?utf-8?B?UW94UVVmSEo0NkdJOGZtcVgvVnM1d0JOdElMdzlxMkpRSUxxNWR3SUVheVgx?=
 =?utf-8?B?SGVIRkludjRBK2hTc0U1ZXZnSnM3aVJUNXlOTVFCbDZvdVRBVUIyMkFHQTQx?=
 =?utf-8?B?eXZoZXRSS1pYWDVhbWxkQXY4c3BkK2E4S3hzRndCaXdHLzNCaFRCMWRXaHZO?=
 =?utf-8?B?dnZyNzV5RE9sYVFJaFNob3dkTGZ5UFNaSjhjNnlpOUR6NWhWejZOWXNOQkEv?=
 =?utf-8?B?MTlxcURkVGp0T1BZempzMmIwMmFsQ3RYN1pxdEFlTzdNcWhnSjdpSFBYZFpS?=
 =?utf-8?B?dWFlT2l5L1IrZUFMTzQ1S0twNUx3dTN4Rm9lQnRwV1FaK0puM3NFTU12Umov?=
 =?utf-8?B?a0U1QVI2M1lHMjBDT0FuS3RVZDFRbWhvRjk1RlpDVFlDTGdLSHlhNmFVdGVx?=
 =?utf-8?B?ckVkUE9zTis0aE5yMFRQV1phUGJoS2xpZHMwMzdmYmdSMEIvQjFFT2NyMFlM?=
 =?utf-8?B?Z2xwWG5uRXozcWs2UHJKRzJtR1Y5NW8zQzVaR2Ewa05wS2VSMDhmMkovb3BQ?=
 =?utf-8?B?alRNNGYzVW5MSkFtY3JFamxrdUU5VDFtYSt6UHo3MWpTRkpETUNYTmtMOXpm?=
 =?utf-8?B?SUxJN2pRMklFUU1DK29DZW9YWjc4eUQ1clRHWHhQN3p1dXhpcTZHK3hyVmFx?=
 =?utf-8?B?ekE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b0710b4d-addf-4f5d-df25-08db4c3c7809
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4965.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2023 01:11:20.2666
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: B5G3qWXvqXIHVI8v3KapjdjmBS6FfwqnLGUYCLHEv89/IaH97n97Hp0ehxQTOf5dvr+BULhqaZ1b2+y6EFl/9Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR11MB6531
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 5/4/2023 1:06 AM, Edgecombe, Rick P wrote:
> On Fri, 2023-04-21 at 09:46 -0400, Yang Weijiang wrote:
>> @@ -2471,6 +2495,12 @@ static int vmx_set_msr(struct kvm_vcpu *vcpu,
>> struct msr_data *msr_info)
>>                  else
>>                          kvm_set_xsave_msr(msr_info);
>>                  break;
>> +       case MSR_IA32_PL0_SSP ... MSR_IA32_PL2_SSP:
>> +       case MSR_IA32_INT_SSP_TAB:
>> +               if (!cet_is_msr_accessible(vcpu, msr_info))
>> +                       return 1;
>> +               kvm_set_xsave_msr(msr_info);
>> +               break;
> These are supposed to be canonical too, right?

Yes, I'll add check in next version, thanks!