Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <645306fa.620a0220.a363f.f9d0@mx.google.com>
Date:   Wed, 3 May 2023 18:14:33 -0700
From:   Kees Cook <keescook@chromium.org>
To:     Yue Zhao <findns94@gmail.com>
Cc:     arnd@arndb.de, gregkh@linuxfoundation.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lkdtm: replace ll_rw_block with submit_bh
References: <20230503162944.3969-1-findns94@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230503162944.3969-1-findns94@gmail.com>
Precedence: bulk

On Thu, May 04, 2023 at 12:29:44AM +0800, Yue Zhao wrote:
> Function ll_rw_block was removed in commit 79f597842069 ("fs/buffer:
> remove ll_rw_block() helper"). There is no unified function to sumbit
> read or write buffer in block layer for now. Consider similar sematics,
> we can choose submit_bh() to replace ll_rw_block() as predefined crash
> point. In submit_bh(), it also takes read or write flag as the first
> argument and invoke submit_bio() to submit I/O request to block layer.
> 
> Fixes: 79f597842069 ("fs/buffer: remove ll_rw_block() helper")
> 
> Signed-off-by: Yue Zhao <findns94@gmail.com>

Acked-by: Kees Cook <keescook@chromium.org>

-- 
Kees Cook