Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp1600578rwr; Wed, 3 May 2023 18:37:13 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4hwySqAIo6tmCLLw7peo8oC9pev0VAWKc1EYNnTux46PNwOXZ9NRdl5sG50Yhc18ENvGim X-Received: by 2002:a17:902:ecc9:b0:1aa:f173:2892 with SMTP id a9-20020a170902ecc900b001aaf1732892mr2311639plh.57.1683164233241; Wed, 03 May 2023 18:37:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683164233; cv=none; d=google.com; s=arc-20160816; b=Mi/Fec845eknCPIlGmCFk322+2vxVtWwdFAOsnc8kOV3mQe0Ltw1exkgck4AOlGEHS ZT/HM1RX7Zo+QjUAaEZ48LqSWBJY3nuSx+DKBZQeDAVvHGHEmqOuWTr046O8/n41R3St Af/LVWJbhh6gPK8CELVzaNdPzxeMLlmB1tXJO4MWqj2b5f8BxeAOIieUqs8/0M5vq6R+ YQRcNpE/cNaJMMZx1jj/4ZQC/EVmew+e29kwQJtTQE2Vq1QNWOzVWQ2MoA9ONDuT1CGO tFa3Yzenhic5Oi2YlJVDV+z+fNQJ7YDjbQ+yLSYGpuqIRoklfXu2CMz3sDilpmRrBQKP KKfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id; bh=HOY9uDTrUvLjTP17eAaJsTDUqesakbjUFrMTrmPgRvE=; b=iL4Helsxe4nruPz9qgpZmPOKg6cqVUMw6JmP3hqY7lAwbpcDBJzkMPzQE1+4WvC7+h DFc5Rj7n7lIyYVMmBDeB6j+1IPdFMO55Z6uP1JHshpzyFMu6VmXegvcZayxpqTNWMx2D /JJ1whSHQg9HCb/ooZhOKAEWtcZHs2jdHHoRQWO+ddk2BUYbrxl33Uw1UxRd2I5G5p35 /ZlcJPwihZSHLJy+sueY6sJBDC8cRav6bWWlhbPGG1qGW9gvuG7E955ElhIYgd1tsn/z zP79P8gZDQFGKbnYGv3/QwKiuAodaWQsHh2cGReth8aNp6naql94Rc4137aHg0NE+2Pd u2Cw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t4-20020a170902e84400b001a80ddd372csi35819811plg.43.2023.05.03.18.37.02; Wed, 03 May 2023 18:37:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229612AbjEDBev (ORCPT + 99 others); Wed, 3 May 2023 21:34:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42740 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229565AbjEDBep (ORCPT ); Wed, 3 May 2023 21:34:45 -0400 Received: from ex01.ufhost.com (ex01.ufhost.com [61.152.239.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 733ED170A; Wed, 3 May 2023 18:34:43 -0700 (PDT) Received: from EXMBX165.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX165", Issuer "EXMBX165" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id 9B0B224E09F; Thu, 4 May 2023 09:34:33 +0800 (CST) Received: from EXMBX062.cuchost.com (172.16.6.62) by EXMBX165.cuchost.com (172.16.6.75) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Thu, 4 May 2023 09:34:33 +0800 Received: from [192.168.125.107] (183.27.99.121) by EXMBX062.cuchost.com (172.16.6.62) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Thu, 4 May 2023 09:34:32 +0800 Message-ID: <0b0f9187-ad6b-a1d9-6ec4-beb8989ca731@starfivetech.com> Date: Thu, 4 May 2023 09:34:37 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [RESEND v2 1/6] dt-bindings: power: Add JH7110 AON PMU support Content-Language: en-US To: Conor Dooley CC: Conor Dooley , Krzysztof Kozlowski , Rob Herring , "Krzysztof Kozlowski" , Emil Renner Berthing , Paul Walmsley , Palmer Dabbelt , Albert Ou , Walker Chen , Hal Feng , , , , , References: <20230419-labored-camper-644d51a7ca96@spud> <1a5b15fa-4f20-51c2-2ba1-a04a2911a694@starfivetech.com> <20230424-baffle-punch-ec73098f2b6a@spud> <20230425-unquote-eligible-09f743d81981@wendy> <68cb565d-bf39-10b0-9e3e-35ba7f54b90b@linaro.org> <0988495f-b87a-7f69-f222-37c67d6eae23@starfivetech.com> <20230425-resale-footrest-de667778c4fe@wendy> <663e9933-b9b3-a48f-98b6-2207215a8ed7@starfivetech.com> <20230425-commotion-prewashed-876247bed4ab@spud> From: Changhuang Liang In-Reply-To: <20230425-commotion-prewashed-876247bed4ab@spud> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [183.27.99.121] X-ClientProxiedBy: EXCAS064.cuchost.com (172.16.6.24) To EXMBX062.cuchost.com (172.16.6.62) X-YovoleRuleAgent: yovoleflag X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/4/26 0:56, Conor Dooley wrote: > On Tue, Apr 25, 2023 at 08:26:35PM +0800, Changhuang Liang wrote: >> On 2023/4/25 17:35, Conor Dooley wrote: >>> On Tue, Apr 25, 2023 at 05:18:10PM +0800, Changhuang Liang wrote: >>>> On 2023/4/25 16:19, Krzysztof Kozlowski wrote: >>>>> On 25/04/2023 09:57, Changhuang Liang wrote: >>>>>> Yes, "starfive,jh7110-aon-pmu" is a child-node of "starfive,jh7110-aon-syscon". >>>>>> In my opinion, "0x17010000" is "aon-syscon" on JH7110 SoC, and this "aon-pmu" is just >>>>>> a part of "aon-syscon" function, so I think it is inappropriate to make "aon-syscon" >>>>>> to a power domain controller. I think using the child-node description is closer to >>>>>> JH7110 SoC. >>>>> >>>>> Unfortunately, I do not see the correlation between these, any >>>>> connection. Why being a child of syscon block would mean that this >>>>> should no be power domain controller? Really, why? These are two >>>>> unrelated things. >>>> >>>> Let me summarize what has been discussed above. >>>> >>>> There has two ways to describe this "starfive,jh7110-aon-syscon"(0x17010000). >>>> 1. (0x17010000) is power-controller node: >>>> >>>> aon_pwrc: power-controller@17010000 { >>>> compatible = "starfive,jh7110-aon-pmu", "syscon"; >>>> reg = <0x0 0x17010000 0x0 0x1000>; >>>> #power-domain-cells = <1>; >>>> }; >>>> >>>> >>>> 2. (0x17010000) is syscon node, power-controller is child-node of syscon: >>>> >>>> aon_syscon: syscon@17010000 { >>>> compatible = "starfive,jh7110-aon-syscon", "syscon", "simple-mfd"; >>>> reg = <0x0 0x17010000 0x0 0x1000>; >>>> >>>> aon_pwrc: power-controller { >>>> compatible = "starfive,jh7110-aon-pmu"; >>>> #power-domain-cells = <1>; >>>> }; >>>> }; >>> >>> I thought that Rob was suggesting something like this: >>> aon_syscon: syscon@17010000 { >>> compatible = "starfive,jh7110-aon-syscon", ... >>> reg = <0x0 0x17010000 0x0 0x1000>; >>> #power-domain-cells = <1>; >>> }; > >> I see the kernel: >> https://elixir.bootlin.com/linux/latest/source/arch/arm64/boot/dts/mediatek/mt8167.dtsi >> this file line 42: >> it's power-controller also has no meaningful properties. >> What do you think? > > I'm not sure that I follow. It has a bunch of child-nodes does it not, > each of which is a domain? > > I didn't see such domains in your dts patch, they're defined directly in > the driver instead AFAIU. Assuming I have understood that correctly, > your situation is different to that mediatek one? > > Cheers, > Conor. Conor and Rob, How about this way: aon_syscon: syscon@17010000 { compatible = "starfive,jh7110-aon-syscon", "syscon", "simple-mfd"; reg = <0x0 0x17010000 0x0 0x1000>; aon_pwrc: power-controller { compatible = "starfive,jh7110-aon-pmu"; regmap = <&aon_syscon>; #power-domain-cells = <1>; }; }; Add a "regmap" property which is phandle. And it can keep the present child-node structure. This is more consistent with our soc design. Best regards, Changhuang