Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 3 May 2023 20:44:06 -0500
From:   Jeff LaBundy <jeff@labundy.com>
To:     Tomas Mudrunka <tomas.mudrunka@gmail.com>
Cc:     dmitry.torokhov@gmail.com, linux-input@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5] Fix freeze in lm8333 i2c keyboard driver
Message-ID: <ZFMN5nmqLAX170SE@nixie71>
References: <CAH2-hcJYVpBNwnMS6qUp4=MW8kSryDAz7G5cNA8R00QabC9bjg@mail.gmail.com>
 <20230503153231.1136114-1-tomas.mudrunka@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230503153231.1136114-1-tomas.mudrunka@gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?CoPuvmup8fQBIUjziDsAizvhQiRdd0zGDt7isMDITpVjDFVENA1DHdgktRyN?=
 =?us-ascii?Q?IEWZseXJfvlaiRnA2i2tgqr5eRTVVDl2iDppiXL79T7dDp9UcBhJ+e1D+Gi8?=
 =?us-ascii?Q?r8airs7wv0OPhQMCjfZq63UOFJ6HcPpXtFo49anqV5fimM78IxEtUdtzQZ2L?=
 =?us-ascii?Q?yKAOF02GtZ0nCSNe6Aoz9ntZM6AYCb6wjtC5hSnHzlNT4y63DM5x5b8g3WZv?=
 =?us-ascii?Q?U3jlSxmJIrpBktdZd6G3N02JS1mWrhdi+F9Y9kfblnm5RNMu7r5RrhG05mB0?=
 =?us-ascii?Q?nLggMEOqrXNLw6c3b56GANppYhmooBJuoYVoTMPniaCtanwY6BojecjQx2Wv?=
 =?us-ascii?Q?65HztuRgCXWk6aqTQQt78vMBGn08o1We4ldDZj6xDVB0Np3e9nltgdBAmH40?=
 =?us-ascii?Q?pLZ6NoqLtX/IwA+Fbzt3LndLMm3S/h9mKzH+KmgO9iaWGNNBI+HDx5Db/w9I?=
 =?us-ascii?Q?xXiA0y1EXUf/iWlUxRc8vIhAgOmLUpip549fsr9ud+c+Tk38g+Ssl1MmuR/u?=
 =?us-ascii?Q?+NHYXJVn6pIFKpBRaoLOLNqt1n5Ku5RrWhGR7Qq5rXDQ4NKFTnyffJtnXuoD?=
 =?us-ascii?Q?aqGuzStCW/u8IKvE3nGxgyIAEI4YGIp6Grnre1JrcQSC+neouuoG+jug9miV?=
 =?us-ascii?Q?oAWPVkGMFUDjywp3iaQhpUHdaeglP04uwW/VWdyuGV2GjBkSzdxlho+U70G6?=
 =?us-ascii?Q?krejkfkGgT2M5uYZA/Pbqv/A+7JvuW7ifjCMC+sr/Q8K/sU/+GWLaXt19Zqv?=
 =?us-ascii?Q?1vXPIQmaBfioy0aYuzyHUjY+FA2hN0bHWPasqkltjeKM5WZqK3rMo1FlrIX5?=
 =?us-ascii?Q?0osjh7h4mqEuFUJgPZ0pHtiE/yNG7Ny+9ag6WgSYmPVVIBngork68EXktBHk?=
 =?us-ascii?Q?RPA04zgxpPBq3+b0eBTDVL/jJckYAWohwlKIMptCcxH/DcHmUWv01nx+E7L3?=
 =?us-ascii?Q?kougFXcrqYy0WlIhg+saLEMc6C0zfVtFU4dg0QZLE+L7ledhVUF/fZqVKAfc?=
 =?us-ascii?Q?Jt70ez2o8ZY2DtSrcaSJwnffGwjcT93WEEtKLZf8rMHzELt7KwVCn3bIKC7h?=
 =?us-ascii?Q?bEvqT73V9+UbLgY5ROoBUW6R7CizMf4zHyDDAQK0dSbRhU7wH54wUsbxJVdf?=
 =?us-ascii?Q?YB0FccFve8wSzNApcntmHHy1liu333JiP6tYMPAvDLl7pNU3AvAfRSQRPXqk?=
 =?us-ascii?Q?ztglmOLuvsH49EZtLLW3INj6CLUj++799M6wdY8UJJTl9pwN+sbD5I9rQxpH?=
 =?us-ascii?Q?qH/WNojCfZk34NPp9RUPPGlfNnghits5I2EjGvETsKvVgsyNOZTGEQey882M?=
 =?us-ascii?Q?nQxC51SRgy98FfSC78g5O73V7mGnv1BNzlwrlIqQhvE74FHvYdIykjXV4TgB?=
 =?us-ascii?Q?azgRd4fT61Bk6+CXRiC37gD6ZNgVG/1w3rUTkq14qGObufVQwqilFa4pq4Wk?=
 =?us-ascii?Q?gOhBDygBHrvgzHRgx5tv9+CSxkuVxtWlQidSnVkSapTJJGSxnaeMhCaQxL1a?=
 =?us-ascii?Q?O5Xpb2tdBTmIXzBKs6hl8dVyQvSdIa/QDZdUXLZFFr/MNFR7XbxDhedFbhAS?=
 =?us-ascii?Q?lOS7LOch4FeiSLBN4JM1yLn1pfwc5gUt2S9Ymb5z?=
X-OriginatorOrg: labundy.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 22cf2979-27f2-4f4f-e1de-08db4c410d69
X-MS-Exchange-CrossTenant-AuthSource: SN4PR0801MB3774.namprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2023 01:44:09.5590
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 00b69d09-acab-4585-aca7-8fb7c6323e6f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7GheenDt+S60qBPgfVAeTAthrvL0xansz/E9z/1cphlzelfVZdQYFqBbOUTxIuER3P/6ksw0UUEMh9hsOPBoFg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR08MB7844
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Tomas,

On Wed, May 03, 2023 at 05:32:31PM +0200, Tomas Mudrunka wrote:
> LM8333 uses gpio interrupt line which is triggered by falling edge.
> When button is pressed before driver is loaded,
> driver will miss the edge and never respond again.
> To fix this we run the interrupt handler before registering IRQ
> to clear the interrupt via i2c command.
> 
> Signed-off-by: Tomas Mudrunka <tomas.mudrunka@gmail.com>
> ---

Reviewed-by: Jeff LaBundy <jeff@labundy.com>

>  drivers/input/keyboard/lm8333.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/input/keyboard/lm8333.c b/drivers/input/keyboard/lm8333.c
> index 7457c3220..52108c370 100644
> --- a/drivers/input/keyboard/lm8333.c
> +++ b/drivers/input/keyboard/lm8333.c
> @@ -178,6 +178,8 @@ static int lm8333_probe(struct i2c_client *client)
>  			dev_warn(&client->dev, "Unable to set active time\n");
>  	}
>  
> +	lm8333_irq_thread(client->irq, lm8333);
> +
>  	err = request_threaded_irq(client->irq, NULL, lm8333_irq_thread,
>  				   IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
>  				   "lm8333", lm8333);
> -- 
> 2.40.1

Thank you for the productive discussion.

Kind regards,
Jeff LaBundy