Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp1610994rwr; Wed, 3 May 2023 18:51:14 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7x2Rmgyz7DmgXHJcWPHe7fGIyabbweeMVgeYNf4hqNkcDW38uACgQq4uX5mCCM0AeYBGXq X-Received: by 2002:a05:6a21:1693:b0:f2:c2a3:3b4 with SMTP id np19-20020a056a21169300b000f2c2a303b4mr512539pzb.41.1683165074489; Wed, 03 May 2023 18:51:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683165074; cv=none; d=google.com; s=arc-20160816; b=MqADdLOmM/zaFKlCisFNJ7rEkLVfXjSpfhP7CBo/nW0/vbQmOt1XpquHLnxMJlohrv x2RwPlQw86r8zhdssgZGEiJmabMxhJQB4A9gJ87dA6LjAmnmAW8qKzVkwhOTo+YzlxOp gewh0+wtSmnTkL6jC0Ev4zgQt6cuM5Gby7pq9hIMA5n3icwBnDzFD7iqMvQI89Q1nlMH yfg0c9aAYxKW1ICQDZYK6fXEcOdmtBy05LWIPc5LBTiEz4J/kJqzV6Cs9mMKrreN4g4p xC38ujSBU8uNdweQYt6JIrl0btKpvh2AgLJw0D9uwOjVC0Qou9fTg1soiKJf+STJpBKT EgwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=zhAqFnNJHg2lHnJtJpqN8uSnVCo+9aFOBAlIlRuq7JY=; b=vbmAfYt58Ulg2bUOJwUIXwe5htOt5klQBLCJ8JxNpWbtcmVR32ANag+C2GimkSJkGJ NM4kwS5QfwudOLXfvYcTUKkW2/TolI+bFk8+V9obBeugizswi4HCODtzJOpOUIqRH47P uGtyhRdqYmwGgRjSPZGH7JXoKguTRtMC5phhE4d/ozZX1bPHZPy1EvOK1wiSbaLESkNF T347QwJkXBwKS04ViIq9aezpkyy66Uin/DbA53Voq3ZOVm1HIUu0PemfXuIDGYKi7UR1 PJvtkWkHQs1BNa8PvLxuOmSVypmEMG7n8wybysVa7IsnqyebGOlJJk63k/JSkefM/xD2 xmcw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=HkCNopdx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w4-20020a656944000000b0050bebc3e35bsi28805805pgq.766.2023.05.03.18.51.01; Wed, 03 May 2023 18:51:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=HkCNopdx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229514AbjEDBtd (ORCPT + 99 others); Wed, 3 May 2023 21:49:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45864 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229441AbjEDBtc (ORCPT ); Wed, 3 May 2023 21:49:32 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F41A5BD; Wed, 3 May 2023 18:49:30 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 87B94611FA; Thu, 4 May 2023 01:49:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6CB1FC433D2; Thu, 4 May 2023 01:49:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683164969; bh=6SyTKbVcajyYbNLJTfLkhCT7g/RGQ6mt+51ZNxG89JY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=HkCNopdxlGhmaXqy6jbwrBacnksKw0nWAGpajVw5/5AP/0p/6PgFN9Fqn8uDP/c8q uP9h7lQQgC67pEAH9Q6AiqlhqRAkcfHCwGqqv6zAMHfIc2hbb4Gi1bXuUTCeSQ1MOP WOjHnPXVfoZaGkRQtCDwu3mIh4BlMBfDuQWdT3fVAMbAXYTkKoG0PnbLz9FtHMw7UY p0M9WTq0y4b1BDNwALKhlhNvZVLnn3TmoC8rNwNRJ76fPGnSQn5H9S7QHQkF+RZ1mT 1V67W0SqP2swwDd1SeIkSw2jQqILJclB6onfOzG2RFWzakvs3CKBoA/6ERt92PPXgt PTSZAX3sVrhew== Date: Wed, 3 May 2023 18:49:28 -0700 From: Jakub Kicinski To: Gavrilov Ilia Cc: Marcelo Ricardo Leitner , Simon Horman , Neil Horman , Xin Long , "David S. Miller" , Eric Dumazet , Paolo Abeni , "linux-sctp@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "lvc-project@linuxtesting.org" Subject: Re: [PATCH net v4] sctp: fix a potential OOB access in sctp_sched_set_sched() Message-ID: <20230503184928.458eb0da@kernel.org> In-Reply-To: <20230503133752.4176720-1-Ilia.Gavrilov@infotecs.ru> References: <20230503133752.4176720-1-Ilia.Gavrilov@infotecs.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 3 May 2023 13:37:59 +0000 Gavrilov Ilia wrote: > The 'sched' index value must be checked before accessing an element > of the 'sctp_sched_ops' array. Otherwise, it can lead to OOB access. > > Note that it's harmless since the 'sched' parameter is checked before > calling 'sctp_sched_set_sched'. Not a fix, so it needs to wait for net-next to open, see below. When you repost please do so separately, not in the existing thread. ## Form letter - net-next-closed The merge window for v6.3 has begun and therefore net-next is closed for new drivers, features, code refactoring and optimizations. We are currently accepting bug fixes only. Please repost when net-next reopens after May 8th. RFC patches sent for review only are obviously welcome at any time. See: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#development-cycle -- pw-bot: defer