Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7bf51510-ca6e-d4b2-31bf-405258fd08e7@intel.com>
Date:   Thu, 4 May 2023 11:41:17 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH v2 10/21] KVM:x86: Add #CP support in guest exception
 classification
Content-Language: en-US
To:     Binbin Wu <binbin.wu@linux.intel.com>
CC:     <rick.p.edgecombe@intel.com>, <seanjc@google.com>,
        <pbonzini@redhat.com>, <peterz@infradead.org>,
        <john.allen@amd.com>, <kvm@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <20230421134615.62539-1-weijiang.yang@intel.com>
 <20230421134615.62539-11-weijiang.yang@intel.com>
 <d923f839-7505-21fc-2976-673c9e698b6f@linux.intel.com>
From:   "Yang, Weijiang" <weijiang.yang@intel.com>
In-Reply-To: <d923f839-7505-21fc-2976-673c9e698b6f@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QzFWMFpyMng0eHhveGtVVFh3cE42bkc5bHVORmpCOW1aTXFNbmw3b0ZJWVM2?=
 =?utf-8?B?Uy9uRTZNaTdNL2lEaHNNYUs3cjFDcTRXNkZaRE9EUFN5aGt6UkRvWW9ZQWhC?=
 =?utf-8?B?allIRGw3RFpQRUV2VjU5WHFrOUh6bjdxRkhtOGZRaUZIZUhnb2VNb2E2NHZ1?=
 =?utf-8?B?dGdMcTI4RCtXYmozZmI2NmNDcllDYk5qZ0VBQm1NZXdiYk0vNGYwREZzWVBl?=
 =?utf-8?B?VVJaeCtpZmNlTUczODA1dWF3RmxHUCtKeDM1YXlVaVpTQm5KcWVKeHRqMHNH?=
 =?utf-8?B?Yi9za3E3eGZpQklHcXIzSTcwd051anQ3SGM2dDY1MkFBdGR1VlhjOXY3R3Zi?=
 =?utf-8?B?UXNwbW1FcjVkS2VmUk1xblRYSC9QSmYwU3lSZWVqM1lZalBsSzBxMVV2WGVs?=
 =?utf-8?B?R2NZSHZPcnZKVzJCb2hNL29xOHl5Znk3Tlh5Um1kLzJucy8yYjRTQWU4bjNm?=
 =?utf-8?B?YkxCcDhCaXJxaTVCNVh1aHhWRDF3SzAyLy8wWCtoUnN4ZC9QZ3VndVJ4WmlU?=
 =?utf-8?B?R015YnJMT0xEdU9kUmdqWThtbldOV21BdnFWNWVRYjF2VHpSOWt5dW5WMmFk?=
 =?utf-8?B?VURIZW9zK1lYMVYxbk9sclpDZEJDZFpBbWRvc2FQWkkvV0VFdXdvSUYrbzZh?=
 =?utf-8?B?cksyZEU2YjliOW43Nis1Q0djREx5aThkQi8xUlhUeFBTZHQva2JmM1NLOWVy?=
 =?utf-8?B?YllBVmhvRXltMFN2VXltREsvWS9GSHI2WVpnTE1UVWZmNy9QM3ltL2RMN3hs?=
 =?utf-8?B?Z2llK3pLYWlRalZTU1JYNE5lU0NPZUluVTFuSkpnWVhPNHlFRHVtcU9TMkpm?=
 =?utf-8?B?Q3FkOW0xMGplU2dpdUhlalRLVmRmMUExWXppRU9RRkRPcVhHME96RzdFNk9r?=
 =?utf-8?B?bkxHSWtwWHBsQmFEczIrSjZPNG8rdzl0LzdGMWlUb3JMdTVaMzBFTVU3Tnh3?=
 =?utf-8?B?VlZ4c2s0R0x4ODBYTzNVK2lVUERWem85b0xUK3owNk84dWtWNXpROWVVL2V2?=
 =?utf-8?B?M1M2ZWV1WU90VE5YZ2tMVE5XU1kwWmFYT09RdTIxL25qZEZ3WFBzdEVNYUx6?=
 =?utf-8?B?NXAySVp6Y2J1ZVJyMzlETitCeE1RcjgxWXFjZTYyZi9KV2o1VE5VamFNaXB5?=
 =?utf-8?B?dTZldGp1MVg0WGJIbWFEYnhRTzZ1c3N5VkZnSm9GSmNGM29OV09BdlRHL2RE?=
 =?utf-8?B?Y0huTkNpWUtIMUtSbTN0TVNVTDJETlQrellaRGxGMHZTVytsZW83elBGNFRr?=
 =?utf-8?B?S0U1bE9ud01zS0VqZ1U2aUhjZzJnZmUvdmxoZ2txZ2NtZlBwTlRZMzF6ZWhs?=
 =?utf-8?B?R2xnNEczRHFYOStkaDFFcTFqOEp6b2lEVUJieXNOcEQ2UTNjaCsvL0VtZzla?=
 =?utf-8?B?R0RiclZYZFZKb2xQSjVmeEd5alBjL09rS1VYTWwrd0gxc1NINWZDMTV5NnUw?=
 =?utf-8?B?Z1JKVnU1YjQzSVBhbXBzSDhKUmpkOXVDMVBVRXRHY3lqMXVqL0FMaGxBa1Yr?=
 =?utf-8?B?dFMvWG0rZm5oeGJjdnZuZzBJQjlMbDZWMTFpaW9RTmU0Vld1UlJNS0tIZVhE?=
 =?utf-8?B?amNaZnAzM1pIOTl6ZUVMdjMzM3d0eTNiZGF3c04xODc1TzBUdW9lUUwyc3Rx?=
 =?utf-8?B?Q0lwZmVwRXZiUTRpVDFYOTRVMHU4VjU4Z3gya1JOcFY3MGREUFh2VEtzTnVN?=
 =?utf-8?B?U0tOR3ZRTU5yOXR1ejBaenQxMzR6Unl0c2h5V2pOblRpUTBDS1hadjJBNThL?=
 =?utf-8?B?RUhEcEl5em1MNUZZQkl4SjRvMW9TT3FLL0x1TzFGU2NPNHozT1FLekFzOHFP?=
 =?utf-8?B?cmhIbDhBMzgzQXdxMVRNVUVNejZnM05ZZklTRUR3RzN1K1Z0VHpBTjh0UGlt?=
 =?utf-8?B?V0doVTcwK1B6d0Z5SDArU1RuS1N5RHNPYTM1QmVqU2N5bXdub1JXZDFYTWFM?=
 =?utf-8?B?UkJRUVJjZ3oxZkFxTE1qenc0SkRyekJRWWQ3U0NDSENrUkQwMlUrNHhYRUQ3?=
 =?utf-8?B?WlJtSVh6T0trK3VjY0NSLy9rVnZ1b1hFMFNYd1AxRmk0R2gxSCtWdzM1eWpV?=
 =?utf-8?B?cm5DYkFhczZxTDRIYTU2eWJBc2Y0NWp2V1YwUEVlNHB0SDd0RzZBSVo2a3Vl?=
 =?utf-8?B?eEhkbnhtc0V6VkhhV29FdGtwdWZNcjBPNklmbnl2QjFLS1grcmNRSEYwL0NS?=
 =?utf-8?B?Vmc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 3271a20c-f5a0-43aa-2ae8-08db4c51722c
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4965.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2023 03:41:29.7444
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YY8iGyXi5pu+w8YbxzSOjIjZDwj8dD2Q5G5+tTPxPwuNY/TUV4FwEqAbaI7MM/OvGdoF4XhVeGslPuaX00S1bg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4865
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-8.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 4/28/2023 2:09 PM, Binbin Wu wrote:
>
>
> On 4/21/2023 9:46 PM, Yang Weijiang wrote:
>> Add handling for Control Protection (#CP) exceptions(vector 21).
>> The new vector is introduced for Intel's Control-Flow Enforcement
>> Technology (CET) relevant violation cases.
>> See Intel's SDM for details.
>>
[...]
>>   -static int exception_class(int vector)
>> +static int exception_class(struct kvm_vcpu *vcpu, int vector)
>>   {
>>       switch (vector) {
>>       case PF_VECTOR:
>>           return EXCPT_PF;
>> +    case CP_VECTOR:
>> +        if (vcpu->arch.cr4_guest_rsvd_bits & X86_CR4_CET)
>> +            return EXCPT_BENIGN;
>> +        return EXCPT_CONTRIBUTORY;
> By definition, #CP is Contributory.
> Can you explain more about this change here which treats #CP as 
> EXCPT_BENIGN when CET is not enabled in guest?

I check the history of this patch, found maintainer modified the patch 
due to some unit test issue in L1. You can check the

details here:

Re: [PATCH v15 04/14] KVM: x86: Add #CP support in guest exception 
dispatch - Sean Christopherson (kernel.org) 
<https://lore.kernel.org/all/YBsZwvwhshw+s7yQ@google.com/>


>
> In current KVM code, there is suppose no #CP triggered in guest if CET 
> is not enalbed in guest, right?

Yes.

>>       case DE_VECTOR:
>>       case TS_VECTOR:
>>       case NP_VECTOR:


[...]