Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <cover.1683022164.git.geert+renesas@glider.be> <483c4f520e4acc6357ebba3e605977b4c56374df.1683022164.git.geert+renesas@glider.be>
In-Reply-To: <483c4f520e4acc6357ebba3e605977b4c56374df.1683022164.git.geert+renesas@glider.be>
From:   David Gow <davidgow@google.com>
Date:   Thu, 4 May 2023 14:29:25 +0800
Message-ID: <CABVgOS=gH58gj9-Wf1K0CJ085XJag=oS-8ocx6oUhTHcW1gecw@mail.gmail.com>
Subject: Re: [PATCH 2/2] Input: tests - modular KUnit tests should not depend
 on KUNIT=y
To:     Geert Uytterhoeven <geert+renesas@glider.be>
Cc:     Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Javier Martinez Canillas <javierm@redhat.com>,
        Brendan Higgins <brendan.higgins@linux.dev>,
        linux-input@vger.kernel.org, linux-kselftest@vger.kernel.org,
        kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, 2 May 2023 at 18:17, Geert Uytterhoeven <geert+renesas@glider.be> wrote:
>
> While KUnit tests that cannot be built as a loadable module must depend
> on "KUNIT=y", this is not true for modular tests, where it adds an
> unnecessary limitation.
>
> Fix this by relaxing the dependency to "KUNIT".
>
> Fixes: fdefcbdd6f361841 ("Input: Add KUnit tests for some of the input core helper functions")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---

Works here, thanks!

Reviewed-by: David Gow <davidgow@google.com>

Cheers,
-- David

>  drivers/input/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/Kconfig b/drivers/input/Kconfig
> index 735f90b74ee5ad44..3bdbd34314b3495a 100644
> --- a/drivers/input/Kconfig
> +++ b/drivers/input/Kconfig
> @@ -168,7 +168,7 @@ config INPUT_EVBUG
>
>  config INPUT_KUNIT_TEST
>         tristate "KUnit tests for Input" if !KUNIT_ALL_TESTS
> -       depends on INPUT && KUNIT=y
> +       depends on INPUT && KUNIT
>         default KUNIT_ALL_TESTS
>         help
>           Say Y here if you want to build the KUnit tests for the input
> --
> 2.34.1
>