Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <81a2e61f-5b30-06c9-6773-70c89c836fa7@zonque.org>
Date:   Thu, 4 May 2023 08:54:24 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH] sound: caiaq: input: Add error handling for unsupported
 input methods in `snd_usb_caiaq_input_init`
To:     Ruliang Lin <u202112092@hust.edu.cn>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Karsten Wiese <fzu@wemgehoertderstaat.de>
Cc:     hust-os-kernel-patches@googlegroups.com,
        Dongliang Mu <dzm91@hust.edu.cn>,
        Jaroslav Kysela <perex@suse.cz>, Takashi Iwai <tiwai@suse.de>,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
References: <20230504065054.3309-1-u202112092@hust.edu.cn>
Content-Language: en-US
From:   Daniel Mack <daniel@zonque.org>
In-Reply-To: <20230504065054.3309-1-u202112092@hust.edu.cn>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 5/4/23 08:50, Ruliang Lin wrote:
> Smatch complains that:
> snd_usb_caiaq_input_init() warn: missing error code 'ret'
> 
> This patch adds a new case to handle the situation where the 
> device does not support any input methods in the 
> `snd_usb_caiaq_input_init` function. It returns an `-EINVAL` error code 
> to indicate that no input methods are supported on the device.
> 
> Fixes: 523f1dce3743 ("[ALSA] Add Native Instrument usb audio device support")
> Signed-off-by: Ruliang Lin <u202112092@hust.edu.cn>
> Reviewed-by: Dongliang Mu <dzm91@hust.edu.cn>

Acked-by: Daniel Mack <daniel@zonque.org>


> ---
> The issue is found by static analyzer. The patched code has passed
> Smatch checker, but remains untested on real device.
> ---
>  sound/usb/caiaq/input.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/usb/caiaq/input.c b/sound/usb/caiaq/input.c
> index 1e2cf2f08eec..84f26dce7f5d 100644
> --- a/sound/usb/caiaq/input.c
> +++ b/sound/usb/caiaq/input.c
> @@ -804,6 +804,7 @@ int snd_usb_caiaq_input_init(struct snd_usb_caiaqdev *cdev)
>  
>  	default:
>  		/* no input methods supported on this device */
> +		ret = -EINVAL;
>  		goto exit_free_idev;
>  	}
>