Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   luhongfei <luhongfei@vivo.com>
To:     Jens Axboe <axboe@kernel.dk>,
        Pavel Begunkov <asml.silence@gmail.com>,
        io-uring@vger.kernel.org (open list:IO_URING),
        linux-kernel@vger.kernel.org (open list)
Cc:     opensource.kernel@vivo.com, luhongfei <luhongfei@vivo.com>
Subject: [PATCH] Subject: io_uring: Remove the check of data->free_work and data->do_work in io_wq_create
Date:   Thu,  4 May 2023 14:59:06 +0800
Message-Id: <20230504065906.46574-1-luhongfei@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?T85hCCyskGKASS3/lMoM95TAWEYKSw0LD/UGL84IAcaMPxDr7EhG18L02kpb?=
 =?us-ascii?Q?88hu1F6QCIBJM+GIn3/GkqDF4dRXsz9IAbtzUapmpnWEMA7npxMBwf7u4eFE?=
 =?us-ascii?Q?H1LTC4/COavAqYKI3cqXYqWr+zn/N9byjYm4/pP2CsInwGoA75QBVYIWS0ES?=
 =?us-ascii?Q?pyYS0sAZig+V+z2trGTRkQ8d9x06ilctWbJcI7lb8h8FulZm/rhOWndI/kcp?=
 =?us-ascii?Q?m2rhjm9ClAQndMdqwtZWyvEyEOCbA3d7eto9BT8y+CaEmtowz5yjkhmTTn2N?=
 =?us-ascii?Q?xKtSH8bCxkOXHuRznwS9U/pqO80XleAF5WKgBfOgZcDuYluF6Ag+nMfm+khc?=
 =?us-ascii?Q?72b0y+Ans3Tv5Rz8AJZx3wP+s/g96UIva4PIsgwUBOACEB7RRYQh6Ne2bR8q?=
 =?us-ascii?Q?oNb5O72SmQLHJCIt8AENpjmO+DJNNeGEbt35evqBXvPMBm8X9ORgQjRAOEq5?=
 =?us-ascii?Q?m1YyoEjieHsHM90f1fKJ3+JhxtBZVbv4wNJg1x45P1bL6htMUw9TL8Vnp4YN?=
 =?us-ascii?Q?l/qu21PvnS1LW13e400GxBrxymWLUL0J3prA5hCfqLxlhtFpCbRtKX1Xc5iO?=
 =?us-ascii?Q?lcTUiNgQl5j1JKZs385UAabDFjzU74GzZTawfzk9qeqkEeH2EqnaYDBzfkWa?=
 =?us-ascii?Q?8/E9PN21yLmbxQ/tKvcDW09gqMBjI55q7m8hnnVTLRjm1Tn9oy5Hia7W1oId?=
 =?us-ascii?Q?iJHN7uLgH2JEWYsW3HaHjsQ00gha9GBz9P7Ohv8N6kGpk6OkWjquDY34c1JG?=
 =?us-ascii?Q?mMBWoWTSODPndGsX8dfvSUWLXwooXs4MjMAaNSst32+oZdCKlUrlcCdc2rAt?=
 =?us-ascii?Q?hM/HOoQTjKGZmHyPlPqDtkd2xqCVJ7/pJwYKDDfk6tkyti4iDBWE2VPfUDZ9?=
 =?us-ascii?Q?y/hexLRT+Re2r3/LEkPP7GD5Cc/e2qpKijPKCEtDaDH+gutuIiKEhvZjGTwh?=
 =?us-ascii?Q?IaiGvEDJeAKhIr9v3Tl2aagCNQDEaeQ9Is3au0/vy3CdGnWdV2rVhsgpVUQb?=
 =?us-ascii?Q?5a+nWyn2GeNWDLrLTzO+59Wrbhi4b7HA+PJI0nVy5Bn8Op4rcOUVSEMrWmSd?=
 =?us-ascii?Q?F8oj9/EIDQVrQtJqUnLA6sUytwTsk7qbY7EGrP0SZ5jMQ6fuhGkMXNASMMFK?=
 =?us-ascii?Q?fEVN0uB7+sbIb7XSwyZzGasjMukH9uhX9Heyvxd48k4luUwM+oQkDSTxzLrr?=
 =?us-ascii?Q?2FPW+h0LCzAUk5Is2GAQmE3OIN5Ga5awsxeJQmjKN5A6a0cQ6XvD8xJa89CA?=
 =?us-ascii?Q?ivIDG7sxDa1iUJttItEFAa9kb33VCORNaSt3qURFl8yDgrxGpljiOQnuO5XW?=
 =?us-ascii?Q?x4oCQRv7CMjDVPBVk6kdpd8l61YeVBZf1CgyhQBlPZjZYJLw+ONFVoDhFtt8?=
 =?us-ascii?Q?YhH75Brcn08AbS9fGRcvgrewDqVMswiXzbZp/RvFej75AjKZtg2NsK1fcJhX?=
 =?us-ascii?Q?rrT+cWYMUjNHck1nDQ+o8BAINmT3tYi6UflCWp1m8estjIBdX+n1qEokijLJ?=
 =?us-ascii?Q?/Hmc4ZxkBfW1Pyi01omBqqI9BLcQXK+ZUo9u1hLXsbVL/GZ1S/nGrRBGBDni?=
 =?us-ascii?Q?K50Oj7vRHraPQxNy9XZV4aN3WpC+yCM6Lsq7p1AQ?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 97485ad1-1581-4beb-b9c0-08db4c6d14ab
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB2169.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2023 06:59:18.6936
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: P6N/q7rpUo3jjLqCn5RX6nCjoUhmi+6GArMo5Oj8f8yJdUuomOrNXh3bn9zbTIksZXft5tU6gnoMF4rA4Lt3Kg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI2PR06MB5265
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Remove the check of data->free_work and data->do_work in io_wq_create
io_wq_create is only called in io_init_wq_offload, which has already
initialized free_work and do_work to io_wq_free_work and io_wq_submit_work
respectively, so there is no need to detect whether free_work and
do_work are null pointers in io_wq_create.

Signed-off-by: luhongfei <luhongfei@vivo.com>
---
 io_uring/io-wq.c | 2 --
 1 file changed, 2 deletions(-)
 mode change 100644 => 100755 io_uring/io-wq.c

diff --git a/io_uring/io-wq.c b/io_uring/io-wq.c
index f81c0a7136a5..b978a058ea51
--- a/io_uring/io-wq.c
+++ b/io_uring/io-wq.c
@@ -1143,8 +1143,6 @@ struct io_wq *io_wq_create(unsigned bounded, struct io_wq_data *data)
 	int ret, node, i;
 	struct io_wq *wq;
 
-	if (WARN_ON_ONCE(!data->free_work || !data->do_work))
-		return ERR_PTR(-EINVAL);
 	if (WARN_ON_ONCE(!bounded))
 		return ERR_PTR(-EINVAL);
 
-- 
2.39.0