Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <bf593f0f-5c62-f36a-a5d2-f6376f3babda@linux.alibaba.com>
Date:   Thu, 4 May 2023 15:31:58 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.10.1
Subject: Re: [PATCH v2 5/5] perf vendor events: Add JSON metrics for Yitian
 710 DDR
Content-Language: en-US
To:     Jing Zhang <renyu.zj@linux.alibaba.com>,
        John Garry <john.g.garry@oracle.com>,
        Ian Rogers <irogers@google.com>, Will Deacon <will@kernel.org>
Cc:     James Clark <james.clark@arm.com>,
        Mike Leach <mike.leach@linaro.org>,
        Leo Yan <leo.yan@linaro.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Ilkka Koskinen <ilkka@os.amperecomputing.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Adrian Hunter <adrian.hunter@intel.com>,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-perf-users@vger.kernel.org,
        Zhuo Song <zhuo.song@linux.alibaba.com>
References: <1682329456-19418-1-git-send-email-renyu.zj@linux.alibaba.com>
 <1682329456-19418-6-git-send-email-renyu.zj@linux.alibaba.com>
From:   Shuai Xue <xueshuai@linux.alibaba.com>
In-Reply-To: <1682329456-19418-6-git-send-email-renyu.zj@linux.alibaba.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2023/4/24 17:44, Jing Zhang wrote:
> Add JSON metrics for T-HEAD Yitian 710 SoC DDR.
> 
> Signed-off-by: Jing Zhang <renyu.zj@linux.alibaba.com>


Could you also update the Documentation/admin-guide/perf/alibaba_pmu.rst
with some example of how to use these metrics?

Best Regards,
Shuai


> ---
>  .../arch/arm64/freescale/yitian710/sys/metrics.json  | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
>  create mode 100644 tools/perf/pmu-events/arch/arm64/freescale/yitian710/sys/metrics.json
> 
> diff --git a/tools/perf/pmu-events/arch/arm64/freescale/yitian710/sys/metrics.json b/tools/perf/pmu-events/arch/arm64/freescale/yitian710/sys/metrics.json
> new file mode 100644
> index 0000000..1a92477
> --- /dev/null
> +++ b/tools/perf/pmu-events/arch/arm64/freescale/yitian710/sys/metrics.json
> @@ -0,0 +1,20 @@
> +[
> +	{
> +		"MetricName": "ddr_read_bandwidth.all",
> +		"BriefDescription": "The ddr read bandwidth(MB/s).",
> +		"MetricGroup": "ddr",
> +		"MetricExpr": "hif_rd * 64 / 1e6 / duration_time",
> +		"ScaleUnit": "1MB/s",
> +		"Unit": "ali_drw",
> +		"Compat": "ali_drw_pmu"
> +	},
> +	{
> +		"MetricName": "ddr_write_bandwidth.all",
> +		"BriefDescription": "The ddr write bandwidth(MB/s).",
> +		"MetricGroup": "ddr",
> +		"MetricExpr": "(hif_wr + hif_rmw) * 64 / 1e6 / duration_time",
> +		"ScaleUnit": "1MB/s",
> +		"Unit": "ali_drw",
> +		"Compat": "ali_drw_pmu"
> +	}
> +]