Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <fa6ad8a8-5cf0-0368-8ab4-991902ce38bf@ti.com>
Date:   Thu, 4 May 2023 13:13:23 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH v5 1/3] dt-bindings: misc: esm: Add ESM support for TI K3
 devices
Content-Language: en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>
CC:     <nm@ti.com>, <vigneshr@ti.com>, <kristo@kernel.org>,
        <u-kumar1@ti.com>
References: <20230503123212.208457-1-n-francis@ti.com>
 <20230503123212.208457-2-n-francis@ti.com>
 <9ece615f-0a6b-fff4-e129-ea7ca224a6a8@linaro.org>
From:   Neha Malcom Francis <n-francis@ti.com>
In-Reply-To: <9ece615f-0a6b-fff4-e129-ea7ca224a6a8@linaro.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Krzysztof

On 04/05/23 12:21, Krzysztof Kozlowski wrote:
> On 03/05/2023 14:32, Neha Malcom Francis wrote:
>> Document the binding for TI K3 ESM (Error Signaling Module) block.
>>
>> Signed-off-by: Neha Malcom Francis <n-francis@ti.com>
> 
> ???
> 
> You were already asked to keep it and it was in v4, so you had to
> explicitly remove it from your git... It takes me time to figure out
> what is happening here. But ok, if you do not keep my review, comment
> follows.
> 
> ...

Really sorry about that, forgot to add it back for v5. Sending next 
version soon...

> 
>> +  ti,esm-pins:
>> +    $ref: /schemas/types.yaml#/definitions/uint32-array
>> +    description:
>> +      integer array of ESM interrupt pins to route to external event pin
>> +      which can be used to reset the SoC.
>> +    minItems: 1
>> +    maxItems: 255
>> +
>> +additionalProperties: false
> 
> Put aditionalProperties after required:, just like in example-schema.
> 
>> +
>> +required:
>> +  - compatible
>> +  - reg
>> +  - ti,esm-pins
> 
> 
> 
> Best regards,
> Krzysztof
> 

-- 
Thanking You
Neha Malcom Francis