Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH v5] usb: dwc3: core: add support for realtek SoCs custom's
 global register start address
To:     Stanley Chang <stanley_chang@realtek.com>,
        Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230504034423.20813-1-stanley_chang@realtek.com>
From:   Sergei Shtylyov <sergei.shtylyov@gmail.com>
Message-ID: <96706396-7023-b895-169a-788aad11adcb@gmail.com>
Date:   Thu, 4 May 2023 10:50:15 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.1
MIME-Version: 1.0
In-Reply-To: <20230504034423.20813-1-stanley_chang@realtek.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hello!

On 5/4/23 6:44 AM, Stanley Chang wrote:

> The Realtek RTD1xxx SoCs were designed, the global register address
> offset at 0x8100.

  Can't parse that, perhaps "with" is missing?

> The default address offset is constant at
> DWC3_GLOBALS_REGS_START (0xc100). Therefore, add a check if the
> compatible name of the parent is "realtek,rtd1xxx-dwc3", then global

   Wildcards are not allowed in the "compatible" props...

> register start address will remap to 0x8100.
> 
> Signed-off-by: Stanley Chang <stanley_chang@realtek.com>
[...]

MBR, Sergey